Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate sign out to OAuth server #40

Open
rien opened this issue Aug 9, 2018 · 7 comments
Open

Propagate sign out to OAuth server #40

rien opened this issue Aug 9, 2018 · 7 comments

Comments

@rien
Copy link
Contributor

rien commented Aug 9, 2018

If you log out, you can immediately log in again without providing credentials because you are not logged out with the OAuth server. This should be fixed (redirect to https://adams.ugent.be/oauth/accounts/logout/ or something).

This should also be fixed for Tap.

@ninewise
Copy link
Member

I believe this is standard behaviour? You could offer a button to also logout from OAuth, but I'd leave the choice to the user.

@rien
Copy link
Contributor Author

rien commented Aug 10, 2018 via email

@ninewise
Copy link
Member

They might want to visit tap next, and not log in to OAuth again? And it's just not your decision, your app shouldn't mess with another app just because they authenticated a user.

https://stackoverflow.com/questions/12909332/how-to-logout-of-an-application-where-i-used-oauth2-to-login-with-google#12909563

@rien
Copy link
Contributor Author

rien commented Aug 10, 2018

The problem is that there is no straightforward way to log out of your Zeus account. If you're on someone else's computer and you log out, that person is able to log in again as your user.

I can understand that this is something you don't want to happen with google, but Zeus OAuth is really only used for our custom applications. If a user logs out, he really means to be logged out from Zeus I think.

@rien
Copy link
Contributor Author

rien commented Aug 10, 2018

Another option may be to have a button 'Also sign out of Zeus' after you've logged out.

@ninewise
Copy link
Member

You could offer a button to also logout from OAuth, but I'd leave the choice to the user.

:-)

@rien
Copy link
Contributor Author

rien commented Aug 13, 2018

I must've read over that part of your comment.

But OK, I guess that such a button would be the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants