Skip to content
This repository has been archived by the owner on Nov 15, 2020. It is now read-only.

capture bot stderr #231

Closed
iasoon opened this issue Apr 22, 2018 · 2 comments
Closed

capture bot stderr #231

iasoon opened this issue Apr 22, 2018 · 2 comments

Comments

@iasoon
Copy link
Member

iasoon commented Apr 22, 2018

Now that networking is getting ready for release, we have client-side bot runners. This allows us to capture bot stderr for local logs.

The question that remains is how we will actually handle this data. The issue that arises is that our log is event-based, and stderr is just a data stream. One approach would be to treat a line on stderr as an event, and log it as it occurs. Apart from the mild inconvenience that a three-line error trace would be three events in this case, this might cause buffering issues (some buffers might only get flushed after enough data is written, some might be flushed once the process exits). Since the bot writer does not always control this buffering (for example, error output by the python program when writing a python bot), we might have an issue there.

All input on designing a robust mechanism would be welcome :)

@iasoon
Copy link
Member Author

iasoon commented Aug 30, 2018

With the new client & logging structure, this is now

@iasoon
Copy link
Member Author

iasoon commented Sep 23, 2018

closing in favour of #267.

@iasoon iasoon closed this as completed Sep 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant