Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEUS-2701: Wallets: better highlighting of active node #2702

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Jan 3, 2025

Description

#2701

simulator_screenshot_AB7CF641-8D69-4959-B84D-E2EB1CB018BD

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added the Design Issue relating to design label Jan 3, 2025
@kaloudis kaloudis added this to the v0.9.5 milestone Jan 3, 2025
@kaloudis kaloudis linked an issue Jan 3, 2025 that may be closed by this pull request
@kaloudis kaloudis force-pushed the zeus-2701 branch 2 times, most recently from 40de15d to 4a91e93 Compare January 3, 2025 00:37
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see the highlighting in android

@kaloudis
Copy link
Contributor Author

kaloudis commented Jan 8, 2025

I can't see the highlighting in android

Could you try again and provide a screenshot or test different themes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Issue relating to design Wallet configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallets view: better highlighting of active node
2 participants