From a8f2a12112a220c6ec0a2779ceaa49f8a7f4675c Mon Sep 17 00:00:00 2001 From: Zentrik Date: Sun, 23 Jun 2024 13:04:24 +0100 Subject: [PATCH] Format --- .../artifact-size/artifact-size-table.vue | 2 +- .../src/pages/compare/compile/common.ts | 4 +- .../pages/compare/compile/compile-page.vue | 6 +-- .../src/pages/compare/compile/filters.vue | 8 ++-- .../compile/table/benchmark-detail-graph.vue | 8 ++-- .../compile/table/benchmark-detail.vue | 8 ++-- .../compile/table/comparisons-table.vue | 37 +++++++++++-------- .../pages/compare/summary/overall-summary.vue | 3 +- site/frontend/src/pages/compare/types.ts | 2 +- 9 files changed, 37 insertions(+), 41 deletions(-) diff --git a/site/frontend/src/pages/compare/artifact-size/artifact-size-table.vue b/site/frontend/src/pages/compare/artifact-size/artifact-size-table.vue index fef859336..9c130037c 100644 --- a/site/frontend/src/pages/compare/artifact-size/artifact-size-table.vue +++ b/site/frontend/src/pages/compare/artifact-size/artifact-size-table.vue @@ -176,4 +176,4 @@ table { text-align: right; } } - \ No newline at end of file + diff --git a/site/frontend/src/pages/compare/compile/common.ts b/site/frontend/src/pages/compare/compile/common.ts index e0faacc06..452b5e2c0 100644 --- a/site/frontend/src/pages/compare/compile/common.ts +++ b/site/frontend/src/pages/compare/compile/common.ts @@ -32,8 +32,8 @@ export function shouldShowTestCase( const name = comparison.test_case.benchmark; const nameFilter = filter.name && filter.name.trim(); if (!nameFilter) { - return true - } else if (filter.regex) { + return true; + } else if (filter.regex) { try { return name.match(nameFilter); } catch { diff --git a/site/frontend/src/pages/compare/compile/compile-page.vue b/site/frontend/src/pages/compare/compile/compile-page.vue index 9ee74031f..8d41c2604 100644 --- a/site/frontend/src/pages/compare/compile/compile-page.vue +++ b/site/frontend/src/pages/compare/compile/compile-page.vue @@ -29,11 +29,7 @@ function loadFilterFromUrl( ): CompileBenchmarkFilter { return { name: urlParams["name"] ?? defaultFilter.name, - regex: getBoolOrDefault( - urlParams, - "regex", - defaultFilter.regex - ), + regex: getBoolOrDefault(urlParams, "regex", defaultFilter.regex), nonRelevant: getBoolOrDefault( urlParams, "nonRelevant", diff --git a/site/frontend/src/pages/compare/compile/filters.vue b/site/frontend/src/pages/compare/compile/filters.vue index 30d4e5ba4..f92fca4df 100644 --- a/site/frontend/src/pages/compare/compile/filters.vue +++ b/site/frontend/src/pages/compare/compile/filters.vue @@ -46,13 +46,11 @@ const opened = createPersistedRef(PREF_FILTERS_OPENED);
diff --git a/site/frontend/src/pages/compare/compile/table/benchmark-detail-graph.vue b/site/frontend/src/pages/compare/compile/table/benchmark-detail-graph.vue index 977a0d4ac..c2a0b8bfe 100644 --- a/site/frontend/src/pages/compare/compile/table/benchmark-detail-graph.vue +++ b/site/frontend/src/pages/compare/compile/table/benchmark-detail-graph.vue @@ -110,7 +110,7 @@ async function renderGraph( ) { const opts: GraphRenderOpts = { width: Math.min(window.innerWidth - 40, 465), - renderTitle: false + renderTitle: false, }; if (date !== null) { drawCurrentDate(opts, date); @@ -235,8 +235,7 @@ onMounted(() => { Each plotted value is relative to the first commit of the commit range
- The shaded region shows values more recent than the - benchmarked commit + The shaded region shows values more recent than the benchmarked commit
@@ -248,8 +247,7 @@ onMounted(() => { Each plotted value is relative to its previous commit
- The shaded region shows values more recent than the - benchmarked commit + The shaded region shows values more recent than the benchmarked commit
diff --git a/site/frontend/src/pages/compare/compile/table/benchmark-detail.vue b/site/frontend/src/pages/compare/compile/table/benchmark-detail.vue index f5fa0267d..f8dd1490c 100644 --- a/site/frontend/src/pages/compare/compile/table/benchmark-detail.vue +++ b/site/frontend/src/pages/compare/compile/table/benchmark-detail.vue @@ -20,7 +20,9 @@ const props = defineProps<{ }>(); function benchmarkLink(benchmark: string): string { - return `https://github.com/JuliaCI/BaseBenchmarks.jl/tree/master/src/${benchmark.split('.')[0]}`; + return `https://github.com/JuliaCI/BaseBenchmarks.jl/tree/master/src/${ + benchmark.split(".")[0] + }`; } function graphLink( @@ -80,9 +82,7 @@ function graphLink( :base-artifact="baseArtifact" />
- +
diff --git a/site/frontend/src/pages/compare/compile/table/comparisons-table.vue b/site/frontend/src/pages/compare/compile/table/comparisons-table.vue index 315dd28f3..886d01960 100644 --- a/site/frontend/src/pages/compare/compile/table/comparisons-table.vue +++ b/site/frontend/src/pages/compare/compile/table/comparisons-table.vue @@ -4,7 +4,7 @@ import Tooltip from "../../tooltip.vue"; import {ArtifactDescription} from "../../types"; import {percentClass} from "../../shared"; import {CompileTestCase} from "../common"; -import {computed, onMounted, onBeforeUnmount, ref, watchEffect} from 'vue'; +import {computed, onMounted, onBeforeUnmount, ref, watchEffect} from "vue"; import {testCaseKey} from "../common"; import BenchmarkDetail from "./benchmark-detail.vue"; import Accordion from "../../../../components/accordion.vue"; @@ -29,16 +29,18 @@ function prettifyRawNumber(number: number): string { const showSignificanceData = ref(true); const updateShowSignificanceData = () => { let width_of_cols = 97.8 * (3 + (props.showRawData ? 2 : 0)) + 14 + 50; // Excluding benchmark name column - let width_with_sig_data = width_of_cols + 97.8*2 + 50; - showSignificanceData.value = !window.matchMedia(`(max-width: ${width_with_sig_data}px)`).matches; + let width_with_sig_data = width_of_cols + 97.8 * 2 + 50; + showSignificanceData.value = !window.matchMedia( + `(max-width: ${width_with_sig_data}px)` + ).matches; }; onMounted(() => { updateShowSignificanceData(); - window.addEventListener('resize', updateShowSignificanceData); + window.addEventListener("resize", updateShowSignificanceData); }); onBeforeUnmount(() => { - window.removeEventListener('resize', updateShowSignificanceData); + window.removeEventListener("resize", updateShowSignificanceData); }); // Modify this when changing the number of columns in the table! const columnCount = ref(5); // initial value @@ -88,8 +90,10 @@ const unit = computed(() => { the significance threshold, the noisier a test case is. You can see - here + href="https://github.com/rust-lang/rustc-perf/blob/master/docs/comparison-analysis.md#what-makes-a-test-result-significant" + > + here how the significance threshold is calculated. @@ -127,8 +131,8 @@ const unit = computed(() => { {{ comparison.comparison.significance_threshold ? ( - 100 * comparison.comparison.significance_threshold - ).toFixed(2) + "%" + 100 * comparison.comparison.significance_threshold + ).toFixed(2) + "%" : "-" }} @@ -139,7 +143,8 @@ const unit = computed(() => {
{{ comparison.comparison.significance_factor - ? comparison.comparison.significance_factor.toFixed(2) + "x" + ? comparison.comparison.significance_factor.toFixed(2) + + "x" : "-" }}
@@ -201,7 +206,6 @@ const unit = computed(() => { } .benches { - td, th { text-align: center; @@ -211,27 +215,28 @@ const unit = computed(() => { width: 5px; } - &.narrow, &.pct-change { + &.narrow, + &.pct-change { word-wrap: break-word; width: 90px; } &.raw-data { - width:90px; + width: 90px; text-align: right; } } } .benches td { - &>.numeric-aligned { + & > .numeric-aligned { display: flex; flex-direction: column; align-items: center; text-align: right; - &>div, - &>span { + & > div, + & > span { width: 60px; } } diff --git a/site/frontend/src/pages/compare/summary/overall-summary.vue b/site/frontend/src/pages/compare/summary/overall-summary.vue index e7d3f69c6..d56bcc5b6 100644 --- a/site/frontend/src/pages/compare/summary/overall-summary.vue +++ b/site/frontend/src/pages/compare/summary/overall-summary.vue @@ -37,7 +37,7 @@ const summary = computed(() => props.summary); .tooltip-container { position: absolute; right: -7px; - top: 5px + top: 5px; } :deep(.tooltiptext) { @@ -52,5 +52,4 @@ const summary = computed(() => props.summary); margin-left: -22px !important; } } - diff --git a/site/frontend/src/pages/compare/types.ts b/site/frontend/src/pages/compare/types.ts index a9fce5f3e..fbefae740 100644 --- a/site/frontend/src/pages/compare/types.ts +++ b/site/frontend/src/pages/compare/types.ts @@ -50,4 +50,4 @@ export interface CompareResponse { export enum Tab { CompileTime = "compile", ArtifactSize = "artifact-size", -} \ No newline at end of file +}