From a1e3d679e9f53838e883803f81bf634fae683d9b Mon Sep 17 00:00:00 2001
From: Daniel Eshkeri <de7924@zebra.com>
Date: Wed, 13 Nov 2024 13:19:03 +0000
Subject: [PATCH] fix: set navigation item highlight shape to rectangle

test: edited test to pass after merge
---
 lib/src/components/navigation bar/navigation_bar.dart       | 1 +
 test/src/components/navigation_bar/navigation_bar_test.dart | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/src/components/navigation bar/navigation_bar.dart b/lib/src/components/navigation bar/navigation_bar.dart
index ee3afe0c..a328a274 100644
--- a/lib/src/components/navigation bar/navigation_bar.dart	
+++ b/lib/src/components/navigation bar/navigation_bar.dart	
@@ -265,6 +265,7 @@ class NavigationItem extends ZetaStatelessWidget {
         borderRadius: context.rounded ? Zeta.of(context).radius.rounded : Zeta.of(context).radius.none,
         onTap: onTap,
         hoverColor: colors.surfaceHover,
+        highlightShape: BoxShape.rectangle,
         child: Semantics(
           button: true,
           excludeSemantics: true,
diff --git a/test/src/components/navigation_bar/navigation_bar_test.dart b/test/src/components/navigation_bar/navigation_bar_test.dart
index e7a74ff6..11c2e082 100644
--- a/test/src/components/navigation_bar/navigation_bar_test.dart
+++ b/test/src/components/navigation_bar/navigation_bar_test.dart
@@ -370,9 +370,10 @@ void main() {
 
       await tester.pumpAndSettle();
 
-      final inkwell = tester.widget<InkWell>(find.descendant(of: itemFinder, matching: find.byType(InkWell)).first);
+      final inkResponse =
+          tester.widget<InkResponse>(find.descendant(of: itemFinder, matching: find.byType(InkResponse)).first);
 
-      expect(inkwell.hoverColor, Zeta.of(context).colors.surfaceHover);
+      expect(inkResponse.hoverColor, Zeta.of(context).colors.surfaceHover);
     });
   });