False positive warning about missing __typename

[cmeeren]

Consider this query:

query MyFavorites {
  me {
    favorites {
      item {
        __typename
        ... on Order {
          id
        }
      }
    }
  }
}

It fails with:

Missing required __typename on sub type Order of type FavoriteItem selected on field item

But __typename is included outside the fragment, on every type.

I can work around it by adding __typename inside ... on Order, but it should not be necessary.

[Zaid-Ajaj]

I can work around it by adding __typename inside ... on Order, but it should not be necessary.

Hi there @cmeeren, this indeed doesn't sound necessary as long as the resulting __typename field value is adjacent to the fields of the sub types (Order in this case). This is required by the deserialization libraries to know which union case to unmarshall the data into.

It looks like a doable fix, any chance you could take a stab at it? I could probably look into it but very low on time these days for OSS work

[cmeeren]

It looks like a doable fix, any chance you could take a stab at it? I could probably look into it but very low on time these days for OSS work

Totally understand, I'm in the same position, so unfortunately, I'm not able to prioritize getting into a new codebase at the moment.