You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
if self.targets != {self.WILDCARD_TOKEN}:
if not self.actions >= permission.actions:
return False
This appears to be a copy+paste error. Line 124 is evaluating the actions part of the permission instead of the targets part. This causes permission checks to fail. Modifying it to evaluate self.targets seems to fix everything.
The text was updated successfully, but these errors were encountered:
A proper patch should include fixing whatever tests allowed this to slip through. I'm afraid I don't have time to setup the test suite and comb through them.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Line 123-125:
This appears to be a copy+paste error. Line 124 is evaluating the
actions
part of the permission instead of thetargets
part. This causes permission checks to fail. Modifying it to evaluateself.targets
seems to fix everything.The text was updated successfully, but these errors were encountered: