Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts & Experience #11

Open
dylan-digi opened this issue Nov 17, 2023 · 4 comments
Open

Thoughts & Experience #11

dylan-digi opened this issue Nov 17, 2023 · 4 comments

Comments

@dylan-digi
Copy link

This reference serves as a fantastic illustration of developing a phone natively whilst also providing some quick examples around streaming the contact images. Many developers will choose alternative methods for UI... with some interesting design choices to say the least.

Despite ongoing searches, I've struggled to find others adopting a lore-friendly approach for the phone. Thank you!!

Minor Issues:

  • The Mobile Radio Player app fails to recognize changes when adjusting the radio through another resource. To provide context, I am experimenting with JS Radio to understand the functionality of custom radios. For the record, the Mobile Radio idea is fantastic and has been very popular during testing.

  • When utilizing a development menu (such as vMenu, EasyAdmin, etc.), conflicts arise as the Phone pops up and interferes with menu navigation, given that both use the same arrow keys. Would it be overly complex to establish a system that communicates with "KGV-Phone" to prevent phone activation when another menu is open? A check of some sort to say, "Hey, don't open the phone!"

  • Currently, the phone appears abruptly in a static manner. In native GTA V, the phone smoothly transitions onto the screen. Based on the checklist provided, it seems that visual elements like this were deferred until the core functions were completed. If true, this can be safely ignored.

@Xinerki
Copy link
Owner

Xinerki commented Nov 17, 2023

i made this AGES ago as a silly little test and it got out of hand and became a full on phone resource, i have had plans to redo it completely from scratch with modern skill and mindset

  • mobile radio is a silly little experiment, that was surprisingly useful, that said - updating radio aspects in real time might not be that easy afaik
  • on my server that i made the resource, i intentionally avoid having easy shortcuts like vMenu or a trainer, to challenge myself to come up with better solutions. as a result - i have no idea how the phone behaves with other menus
  • the script i started with had animations, but i didnt understand the code so i had to remove it to get anywhere. nowadays i understand code FAR better. if i were to redo it from scratch, as mentioned earlier, i would absolutely have animations

@Xinerki
Copy link
Owner

Xinerki commented Nov 17, 2023

there's been modern attempts at doing the same thing which do a pretty damn good job too:
https://forum.cfx.re/t/scalephone-an-ifruit-phone-framework/4548049
https://github.com/CritteRo/scalePhone

@dylan-digi
Copy link
Author

I suppose that most of these issues would resolve themselves in a new hypothetical iteration. Thank you for the prompt response!

i have had plans to redo it completely from scratch with modern skill and mindset

Exciting to hear! It would be even more insightful to compare this old version with a new version, since I've worked with it so much recently, but I totally understand if you aren't interested in that anymore. As a side note, I've got another resource of yours on our server as well - Absolutely love KGV-Hipfire great work ❤️

there's been modern attempts at doing the same thing which do a pretty damn good job too

I'll make sure to explore them, thanks again! If they lack Mobile Radio functionality though, we might just stick with your resource. We've also been brainstorming ideas for custom phone variations like Badger or Whiz, so if you ever decide to revive this project, I've got a list of feature requests and ideas ready 😆

@Xinerki
Copy link
Owner

Xinerki commented Nov 17, 2023

you're welcome to submit PRs to the repo, i'll review and pull them without issues. the refactor would directly reference new features added through PRs too, so it's not all in vein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants