Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Disable ping check #38

Open
diaznet opened this issue Dec 16, 2024 · 1 comment · May be fixed by #458
Open

[Bug]: Disable ping check #38

diaznet opened this issue Dec 16, 2024 · 1 comment · May be fixed by #458
Assignees
Labels
enhancement New feature or request

Comments

@diaznet
Copy link

diaznet commented Dec 16, 2024

Describe the bug / 描述问题

Ping checks failing prevents setup of the integration

To Reproduce / 复现步骤

In my setup home assistant is not allowed to ping to teh Internet.
In custom_components/xiaomi_home/miot/miot_network.py access to various DNS servers via ping is checked prior to allowing setup of teh integration.
Please implement a mechanism so this could be bypassed or disabled.

Expected behavior / 预期结果

DNS check is disabled or bypassed when required by advanced users

Home Assistant Logs / 系统日志

No response

Home Assistant Core version / Home Assistant Core 版本

2024.11.3

Home Assistant Operation System version / Home Assistant Operation System 版本

Docker

Xiaomi Home integration version / 米家集成版本

v0.1.0

Additional context / 其他说明

No response

@diaznet diaznet added the bug Something isn't working label Dec 16, 2024
@diaznet diaznet changed the title [Bug]: Disaböle ping check [Bug]: Disable ping check Dec 16, 2024
@topsworld topsworld self-assigned this Dec 17, 2024
@topsworld
Copy link
Contributor

Thanks for your suggestion, we will update the network monitoring logic in the future

@topsworld topsworld added enhancement New feature or request and removed bug Something isn't working labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants