Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference and Details on BatchPaymentDetails cannot be saved on a Contact #488

Open
dgurram opened this issue Oct 10, 2023 · 2 comments
Open

Comments

@dgurram
Copy link

dgurram commented Oct 10, 2023

SDK you're using (please complete the following information):

  • Xero.NetStandard.OAuth2 3.32.0
  • Xero.NetStandard.OAuth2Client 1.6.0

Describe the bug
Creating a Contact with BatchPayments set has no effect for an Australian Xero contact. I just want to set the Reference field so that all payments automatically get this reference by default. I have tried setting the Reference field as well as the Details field (on Contact.BatchPayments), I've also tried setting both as below, and the SDK does not complain, yet the value is never reflected back on a GET, not visible on the UI and not present when generating payments. So my conclusion is that it's not being accepted and saved:

BatchPayments = new BatchPaymentDetails
{
    Details = "MyDefaultReference",
    Reference = "MyDefaultReference"
}

The documentation does say these are both NZ Only:
https://github.com/XeroAPI/Xero-NetStandard/blob/master/Xero.NetStandard.OAuth2/Model/Accounting/BatchPaymentDetails.cs#L62

But is there a reason this can't be supported for Australia too? The Xero UI does support saving this - Financial Details -> Reference. It's somehow not supported by the API, yet the API does not return a 4xx error, it just silently accepts the value but doesn't actually save it.

Expected behavior
Setting BatchPayments in a contact creation via the API should allow the Reference and/or Details to be saved.

@github-actions
Copy link

PETOSS-356

@github-actions
Copy link

Thanks for raising an issue, a ticket has been created to track your request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant