Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

PHP 7.3 error #174

Open
gabrielkoerich opened this issue Dec 18, 2018 · 1 comment
Open

PHP 7.3 error #174

gabrielkoerich opened this issue Dec 18, 2018 · 1 comment

Comments

@gabrielkoerich
Copy link

I got this when testing on PHP 7.3:

ErrorException: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

vendor/xamin/handlebars.php/src/Handlebars/Tokenizer.php:167
vendor/xamin/handlebars.php/src/Handlebars/Handlebars.php:569
vendor/xamin/handlebars.php/src/Handlebars/Handlebars.php:711
vendor/xamin/handlebars.php/src/Handlebars/Handlebars.php:635
vendor/xamin/handlebars.php/src/Handlebars/Handlebars.php:210

Should it be changed to break or continue 2?
@ivantcholakov
Copy link

I hit these:
vendor/xamin/handlebars.php/src/Handlebars/Tokenizer.php: 167
vendor/xamin/handlebars.php/src/Handlebars/Tokenizer.php: 213

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ivantcholakov @gabrielkoerich