-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert changes for net5 tfm #2103
Comments
ping @adamsitnik |
But it's still targeting netstandard2.0, so .NET 5, .NET Core 3.1 and even 2.1 apps can still use it. |
It's a question of another dimention. Look https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/master/src/HealthChecks.Uris/UriHealthCheck.cs#L41 |
One should not bump tfm requirements just because. |
Thanks for pointing that out! 👍
If we follow the .NET release schedule and use the same major version numbers, when should we drop non-supported TFMs? |
No |
"Not supported" is not applicable from api-set point of view. |
It should be reverted. It make no sence to require higher TFM in case no specific APIs are used from that TFM. Yes, net5 not supported anymore but this is story about runtime/end-applications but not about libraries. With such change as at picture above you make impossible for net5 apps to use this health check though healthcheck itself works perfectly targeted for net5.
Originally posted by @sungam3r in #2044 (comment)
The text was updated successfully, but these errors were encountered: