Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(parsing): refactor implementation of recurring attributes #50

Open
1 of 2 tasks
ReidWeb opened this issue May 15, 2022 · 0 comments
Open
1 of 2 tasks

(parsing): refactor implementation of recurring attributes #50

ReidWeb opened this issue May 15, 2022 · 0 comments
Labels
feature-request New feature or request

Comments

@ReidWeb
Copy link
Member

ReidWeb commented May 15, 2022

Description

For lists of attributes scrapable from DOM e.g. list of class levels, list of gear, list of FC members, list of means to acquire an item - add configurable rules in dom config to map it down in a generic way and reduce duplicitous code.

Use Case

Not user exposed

Minimises code (DRY)

Proposed Solution

Make recurring attribute handlers into functions in dom config.

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@ReidWeb ReidWeb added the feature-request New feature or request label May 15, 2022
@ReidWeb ReidWeb moved this to Todo in XIVStats Rebuild May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant