Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(mount/minion): Add support for parsing multi-lingual names #27

Open
1 of 2 tasks
ReidWeb opened this issue Jan 2, 2022 · 0 comments
Open
1 of 2 tasks

(mount/minion): Add support for parsing multi-lingual names #27

ReidWeb opened this issue Jan 2, 2022 · 0 comments
Assignees
Labels
feature-request New feature or request

Comments

@ReidWeb
Copy link
Member

ReidWeb commented Jan 2, 2022

Description

We may want to render versions of the census in Japanese, German, and French at some point in the future.

The mount and minion names are localised by Square to each language. So it would be valuable to retrieve those.

Use Case

As a consumer of the lodestone client I may wish to fetch a mount/minion name, and the name of the item that grants it in my local language.

Proposed Solution

  • Default language of english added to client initializer.
  • Client fetches only default language by default.
  • Client will fetch additional languages if instructed to.
  • Translated string values will be persisted in under their ISO-639-1 code as keys, even if only default language is selected

Other information

Keys should be:

  • de
  • en
  • en-us
  • fr
  • ja

Example urls:

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@ReidWeb ReidWeb added the feature-request New feature or request label Jan 2, 2022
@ReidWeb ReidWeb self-assigned this Jan 2, 2022
@ReidWeb ReidWeb moved this to Todo in XIVStats Rebuild Jan 2, 2022
@ReidWeb ReidWeb moved this from Todo to In Progress in XIVStats Rebuild Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

1 participant