From 47f3938e197596310b39fdbc829be0cae8dae414 Mon Sep 17 00:00:00 2001
From: b1ink0 <aditya.dhade@rtcamp.com>
Date: Thu, 7 Nov 2024 18:21:00 +0530
Subject: [PATCH 01/14] Update print plugin progress indicator script function
 to support ajax handling, add ajax callback for activation of plugin

---
 .../performance-lab/includes/admin/load.php   | 90 +++++++++++++++++--
 .../includes/admin/plugins.php                |  3 +-
 2 files changed, 87 insertions(+), 6 deletions(-)

diff --git a/plugins/performance-lab/includes/admin/load.php b/plugins/performance-lab/includes/admin/load.php
index 819c116e2..0d4c067a6 100644
--- a/plugins/performance-lab/includes/admin/load.php
+++ b/plugins/performance-lab/includes/admin/load.php
@@ -290,6 +290,36 @@ function perflab_install_activate_plugin_callback(): void {
 }
 add_action( 'admin_action_perflab_install_activate_plugin', 'perflab_install_activate_plugin_callback' );
 
+/**
+ * Callback for handling installation/activation of plugin using ajax.
+ */
+function perflab_install_activate_plugin_ajax_callback(): void {
+	check_ajax_referer( 'perflab_install_activate_plugin_ajax', '_ajax_nonce' );
+
+	require_once ABSPATH . 'wp-admin/includes/plugin.php';
+	require_once ABSPATH . 'wp-admin/includes/plugin-install.php';
+	require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
+	require_once ABSPATH . 'wp-admin/includes/class-wp-ajax-upgrader-skin.php';
+
+	if ( ! isset( $_POST['slug'] ) ) {
+		wp_send_json_error( __( 'Missing required parameter.', 'performance-lab' ), 400 );
+	}
+
+	$plugin_slug = perflab_sanitize_plugin_slug( wp_unslash( $_POST['slug'] ) );
+	if ( null === $plugin_slug ) {
+		wp_send_json_error( __( 'Invalid plugin.', 'performance-lab' ), 400 );
+	}
+
+	// Install and activate the plugin and its dependencies.
+	$result = perflab_install_and_activate_plugin( $plugin_slug );
+	if ( $result instanceof WP_Error ) {
+		wp_send_json_error( $result->get_error_message() );
+	}
+
+	wp_send_json_success();
+}
+add_action( 'wp_ajax_perflab_install_activate_plugin', 'perflab_install_activate_plugin_ajax_callback' );
+
 /**
  * Callback function to handle admin inline style.
  *
@@ -402,8 +432,18 @@ static function ( $name ) {
  * @since 3.1.0
  */
 function perflab_print_plugin_progress_indicator_script(): void {
+	$nonce = wp_create_nonce( 'perflab_install_activate_plugin_ajax' );
+
+	$script_data = array(
+		'ajaxUrl'        => admin_url( 'admin-ajax.php' ),
+		'nonce'          => $nonce,
+		'activatingText' => __( 'Activating...', 'performance-lab' ),
+		'activateText'   => __( 'Activate', 'performance-lab' ),
+		'activatedText'  => __( 'Active', 'performance-lab' ),
+	);
+
 	$js_function = <<<JS
-		function addPluginProgressIndicator( message ) {
+		function addPluginProgressIndicator( data ) {
 			document.addEventListener( 'DOMContentLoaded', function () {
 				document.addEventListener( 'click', function ( event ) {
 					if (
@@ -411,11 +451,51 @@ function addPluginProgressIndicator( message ) {
 							'perflab-install-active-plugin'
 						)
 					) {
+						// Prevent the default link behavior.
+						event.preventDefault();
+
 						const target = event.target;
 						target.classList.add( 'updating-message' );
-						target.textContent = message;
-
-						wp.a11y.speak( message );
+						target.textContent = data.activatingText;
+
+						wp.a11y.speak( data.activatingText );
+
+						const pluginSlug = target.getAttribute('data-plugin-slug');
+
+						fetch(data.ajaxUrl, {
+							method: 'POST',
+							credentials: 'same-origin',
+							headers: {
+								'Content-Type': 'application/x-www-form-urlencoded',
+							},
+							body: new URLSearchParams({
+								action: 'perflab_install_activate_plugin',
+								slug: pluginSlug,
+								_ajax_nonce: data.nonce,
+							}),
+						})
+						.then(response => response.json())
+						.then(response => {
+							if (response.success) {
+								const newButton = document.createElement('button');
+								newButton.type = 'button';
+								newButton.className = 'button button-disabled';
+								newButton.disabled = true;
+								newButton.textContent = data.activatedText;
+								target.parentNode.replaceChild(newButton, target);
+							} else {
+								console.error('Error:', response);
+								// TODO: Show error using admin notice.
+								target.classList.remove('updating-message');
+								target.textContent = data.activateText;
+							}
+                    	})
+						.catch(error => {
+							console.error('Error:', error);
+							// TODO: Show error using admin notice.
+							target.classList.remove('updating-message');
+							target.textContent = data.activateText;
+						});
 					}
 				} );
 			} );
@@ -426,7 +506,7 @@ function addPluginProgressIndicator( message ) {
 		sprintf(
 			'( %s )( %s );',
 			$js_function,
-			wp_json_encode( __( 'Activating...', 'default' ) )
+			wp_json_encode( $script_data )
 		),
 		array( 'type' => 'module' )
 	);
diff --git a/plugins/performance-lab/includes/admin/plugins.php b/plugins/performance-lab/includes/admin/plugins.php
index 709300061..95b43d1e5 100644
--- a/plugins/performance-lab/includes/admin/plugins.php
+++ b/plugins/performance-lab/includes/admin/plugins.php
@@ -426,8 +426,9 @@ function perflab_render_plugin_card( array $plugin_data ): void {
 		);
 
 		$action_links[] = sprintf(
-			'<a class="button perflab-install-active-plugin" href="%s">%s</a>',
+			'<a class="button perflab-install-active-plugin" href="%s" data-plugin-slug="%s">%s</a>',
 			esc_url( $url ),
+			esc_attr( $plugin_data['slug'] ),
 			esc_html__( 'Activate', 'default' )
 		);
 	} else {

From 9d97f597501a618fb17fa872a050fa73ad411d2f Mon Sep 17 00:00:00 2001
From: b1ink0 <aditya.dhade@rtcamp.com>
Date: Fri, 8 Nov 2024 15:23:39 +0530
Subject: [PATCH 02/14] Add admin notice dynamically, Update to use async/await

---
 .../performance-lab/includes/admin/load.php   | 148 ++++++++++++++----
 1 file changed, 115 insertions(+), 33 deletions(-)

diff --git a/plugins/performance-lab/includes/admin/load.php b/plugins/performance-lab/includes/admin/load.php
index 0d4c067a6..502c12a68 100644
--- a/plugins/performance-lab/includes/admin/load.php
+++ b/plugins/performance-lab/includes/admin/load.php
@@ -316,6 +316,15 @@ function perflab_install_activate_plugin_ajax_callback(): void {
 		wp_send_json_error( $result->get_error_message() );
 	}
 
+	$plugin_settings_url = perflab_get_plugin_settings_url( $plugin_slug );
+	if ( null !== $plugin_settings_url ) {
+		wp_send_json_success(
+			array(
+				'pluginSettingsURL' => esc_url( $plugin_settings_url ),
+			)
+		);
+	}
+
 	wp_send_json_success();
 }
 add_action( 'wp_ajax_perflab_install_activate_plugin', 'perflab_install_activate_plugin_ajax_callback' );
@@ -440,12 +449,18 @@ function perflab_print_plugin_progress_indicator_script(): void {
 		'activatingText' => __( 'Activating...', 'performance-lab' ),
 		'activateText'   => __( 'Activate', 'performance-lab' ),
 		'activatedText'  => __( 'Active', 'performance-lab' ),
+		'dismissText'    => __( 'Dismiss this notice.', 'performance-lab' ),
+		'successText'    => __( 'Feature activated.', 'performance-lab' ),
+		'reviewText'     => __( ' Review ', 'performance-lab' ),
+		'settingsText'   => __( 'settings', 'performance-lab' ),
+		'endText'        => _x( '.', 'Punctuation mark', 'performance-lab' ),
+		'errorText'      => __( 'There was an error activating the plugin. Please try again.', 'performance-lab' ),
 	);
 
 	$js_function = <<<JS
 		function addPluginProgressIndicator( data ) {
 			document.addEventListener( 'DOMContentLoaded', function () {
-				document.addEventListener( 'click', function ( event ) {
+				document.addEventListener( 'click', async function ( event ) {
 					if (
 						event.target.classList.contains(
 							'perflab-install-active-plugin'
@@ -460,45 +475,112 @@ function addPluginProgressIndicator( data ) {
 
 						wp.a11y.speak( data.activatingText );
 
-						const pluginSlug = target.getAttribute('data-plugin-slug');
-
-						fetch(data.ajaxUrl, {
-							method: 'POST',
-							credentials: 'same-origin',
-							headers: {
-								'Content-Type': 'application/x-www-form-urlencoded',
-							},
-							body: new URLSearchParams({
-								action: 'perflab_install_activate_plugin',
-								slug: pluginSlug,
-								_ajax_nonce: data.nonce,
-							}),
-						})
-						.then(response => response.json())
-						.then(response => {
-							if (response.success) {
-								const newButton = document.createElement('button');
-								newButton.type = 'button';
-								newButton.className = 'button button-disabled';
-								newButton.disabled = true;
-								newButton.textContent = data.activatedText;
-								target.parentNode.replaceChild(newButton, target);
-							} else {
-								console.error('Error:', response);
-								// TODO: Show error using admin notice.
+						const pluginSlug = target.getAttribute( 'data-plugin-slug' );
+
+						try {
+							const response = await fetch( data.ajaxUrl, {
+								method: 'POST',
+								credentials: 'same-origin',
+								headers: {
+									'Content-Type': 'application/x-www-form-urlencoded',
+								},
+								body: new URLSearchParams( {
+									action: 'perflab_install_activate_plugin',
+									slug: pluginSlug,
+									_ajax_nonce: data.nonce,
+								} ),
+							} );
+
+							const responseData = await response.json();
+
+							if ( !responseData.success ) {
+								showAdminNotice( data.errorText );
+
 								target.classList.remove('updating-message');
 								target.textContent = data.activateText;
+
+								return;
 							}
-                    	})
-						.catch(error => {
-							console.error('Error:', error);
-							// TODO: Show error using admin notice.
-							target.classList.remove('updating-message');
+
+							const newButton = document.createElement( 'button' );
+
+							newButton.type = 'button';
+							newButton.className = 'button button-disabled';
+							newButton.disabled = true;
+							newButton.textContent = data.activatedText;
+
+							target.parentNode.replaceChild( newButton, target );
+							console.log(responseData)
+							showAdminNotice( data.successText, 'success', responseData?.data?.pluginSettingsURL );
+						} catch (error) {
+							showAdminNotice( data.errorText );
+
+							target.classList.remove( 'updating-message' );
 							target.textContent = data.activateText;
-						});
+						}
 					}
 				} );
 			} );
+
+			function showAdminNotice( message, type = 'error', pluginSettingsURL = undefined ) {
+				// Create the notice container elements.
+				const notice = document.createElement( 'div' );
+				const para = document.createElement( 'p' );
+				
+				notice.className = 'notice is-dismissible notice-' + type;
+				para.textContent = message;
+				
+				if ( pluginSettingsURL ) {
+					para.textContent = para.textContent + data.reviewText;
+					
+					const anchor = document.createElement( 'a' );
+					anchor.setAttribute( 'href', pluginSettingsURL );
+					anchor.textContent = data.settingsText;
+					
+					para.appendChild( anchor );
+					para.appendChild( document.createTextNode( data.endText ) );
+				}
+				
+				notice.appendChild( para );
+				
+				const dismissButton = document.createElement( 'button' );
+				const dismissButtonTextWrap = document.createElement( 'span' );
+
+				dismissButton.type = 'button';
+				dismissButton.className = 'notice-dismiss';
+	
+				dismissButtonTextWrap.className = 'screen-reader-text';
+				dismissButtonTextWrap.textContent = data.dismissText;	
+
+				dismissButton.appendChild( dismissButtonTextWrap );
+
+				// Add event listener to remove the notice when dismissed.
+				dismissButton.addEventListener( 'click', () => {
+					notice.remove();
+				} );
+
+				notice.appendChild( dismissButton );
+	
+				// Insert the notice at the top of the admin notices area.
+				const noticeContainer = document.querySelector( '.wrap.plugin-install-php' ) || document.body;
+	
+				if ( !noticeContainer ) {
+					// Fallback append to body if no suitable container is found.
+					document.body.prepend( notice );
+
+					return;
+				} 
+
+				if ( noticeContainer.children.length >= 1 ) {
+					// Insert as the second child.
+					noticeContainer.insertBefore( notice, noticeContainer.children[1] );
+
+					return;
+				}
+
+				// If there's only one child or none, append as the last child.
+				noticeContainer.appendChild( notice );
+			}
 		}
 JS;
 

From 6f172adaf5ea10d4227993707a79cd38abd2e07c Mon Sep 17 00:00:00 2001
From: b1ink0 <aditya.dhade@rtcamp.com>
Date: Mon, 11 Nov 2024 13:33:30 +0530
Subject: [PATCH 03/14] Add settings URL of plugin in admin notice

---
 .../performance-lab/includes/admin/load.php   | 46 +++++++++++++------
 1 file changed, 31 insertions(+), 15 deletions(-)

diff --git a/plugins/performance-lab/includes/admin/load.php b/plugins/performance-lab/includes/admin/load.php
index 502c12a68..cd9f007ab 100644
--- a/plugins/performance-lab/includes/admin/load.php
+++ b/plugins/performance-lab/includes/admin/load.php
@@ -444,17 +444,18 @@ function perflab_print_plugin_progress_indicator_script(): void {
 	$nonce = wp_create_nonce( 'perflab_install_activate_plugin_ajax' );
 
 	$script_data = array(
-		'ajaxUrl'        => admin_url( 'admin-ajax.php' ),
-		'nonce'          => $nonce,
-		'activatingText' => __( 'Activating...', 'performance-lab' ),
-		'activateText'   => __( 'Activate', 'performance-lab' ),
-		'activatedText'  => __( 'Active', 'performance-lab' ),
-		'dismissText'    => __( 'Dismiss this notice.', 'performance-lab' ),
-		'successText'    => __( 'Feature activated.', 'performance-lab' ),
-		'reviewText'     => __( ' Review ', 'performance-lab' ),
-		'settingsText'   => __( 'settings', 'performance-lab' ),
-		'endText'        => _x( '.', 'Punctuation mark', 'performance-lab' ),
-		'errorText'      => __( 'There was an error activating the plugin. Please try again.', 'performance-lab' ),
+		'ajaxUrl'               => admin_url( 'admin-ajax.php' ),
+		'nonce'                 => $nonce,
+		'activatingText'        => __( 'Activating...', 'performance-lab' ),
+		'activateText'          => __( 'Activate', 'performance-lab' ),
+		'activatedText'         => __( 'Active', 'performance-lab' ),
+		'dismissText'           => __( 'Dismiss this notice.', 'performance-lab' ),
+		'successText'           => __( 'Feature activated.', 'performance-lab' ),
+		'reviewText'            => __( ' Review ', 'performance-lab' ),
+		'settingsPrimaryText'   => __( 'settings', 'performance-lab' ),
+		'settingsSecondaryText' => __( 'Settings', 'performance-lab' ),
+		'endText'               => _x( '.', 'Punctuation mark', 'performance-lab' ),
+		'errorText'             => __( 'There was an error activating the plugin. Please try again.', 'performance-lab' ),
 	);
 
 	$js_function = <<<JS
@@ -475,7 +476,7 @@ function addPluginProgressIndicator( data ) {
 
 						wp.a11y.speak( data.activatingText );
 
-						const pluginSlug = target.getAttribute( 'data-plugin-slug' );
+						const pluginSlug = target.getAttribute( 'data-plugin-slug' ).trim();
 
 						try {
 							const response = await fetch( data.ajaxUrl, {
@@ -510,8 +511,23 @@ function addPluginProgressIndicator( data ) {
 							newButton.textContent = data.activatedText;
 
 							target.parentNode.replaceChild( newButton, target );
-							console.log(responseData)
-							showAdminNotice( data.successText, 'success', responseData?.data?.pluginSettingsURL );
+
+							const pluginSettingsURL = responseData?.data?.pluginSettingsURL;
+
+							const actionButtonList = document.querySelector( '.plugin-card-' + pluginSlug + ' .plugin-action-buttons' )
+
+							if ( pluginSettingsURL && actionButtonList ) {
+								const listItem = document.createElement( 'li' );
+								const anchor = document.createElement( 'a' );
+
+								anchor.setAttribute( 'href', pluginSettingsURL );
+								anchor.textContent = data.settingsSecondaryText;
+
+								listItem.appendChild( anchor );
+								actionButtonList.appendChild( listItem );
+							}
+							
+							showAdminNotice( data.successText, 'success', pluginSettingsURL );
 						} catch (error) {
 							showAdminNotice( data.errorText );
 
@@ -535,7 +551,7 @@ function showAdminNotice( message, type = 'error', pluginSettingsURL = undefined
 					
 					const anchor = document.createElement( 'a' );
 					anchor.setAttribute( 'href', pluginSettingsURL );
-					anchor.textContent = data.settingsText;
+					anchor.textContent = data.settingsPrimaryText;
 					
 					para.appendChild( anchor );
 					para.appendChild( document.createTextNode( data.endText ) );

From 337da6c389e6ba6e50064c868c6b27d3c6aed25b Mon Sep 17 00:00:00 2001
From: b1ink0 <aditya.dhade@rtcamp.com>
Date: Mon, 11 Nov 2024 15:02:37 +0530
Subject: [PATCH 04/14] Move inline JavaScript to separate file

---
 .../performance-lab/includes/admin/load.php   | 199 ++----------------
 .../includes/admin/plugin-activate-ajax.js    | 193 +++++++++++++++++
 plugins/performance-lab/load.php              |   1 +
 3 files changed, 215 insertions(+), 178 deletions(-)
 create mode 100644 plugins/performance-lab/includes/admin/plugin-activate-ajax.js

diff --git a/plugins/performance-lab/includes/admin/load.php b/plugins/performance-lab/includes/admin/load.php
index cd9f007ab..862f83fce 100644
--- a/plugins/performance-lab/includes/admin/load.php
+++ b/plugins/performance-lab/includes/admin/load.php
@@ -39,6 +39,8 @@ function perflab_add_features_page(): void {
  * @since 1.0.0
  * @since 3.0.0 Renamed to perflab_load_features_page(), and the
  *              $module and $hook_suffix parameters were removed.
+ * @since n.e.x.t Removed added action for perflab_print_plugin_progress_indicator_script
+ *                as this function is removed.
  */
 function perflab_load_features_page(): void {
 	// Handle script enqueuing for settings page.
@@ -49,9 +51,6 @@ function perflab_load_features_page(): void {
 
 	// Handle style for settings page.
 	add_action( 'admin_head', 'perflab_print_features_page_style' );
-
-	// Handle script for settings page.
-	add_action( 'admin_footer', 'perflab_print_plugin_progress_indicator_script' );
 }
 
 /**
@@ -221,6 +220,7 @@ function perflab_dismiss_wp_pointer_wrapper(): void {
  *
  * @since 2.8.0
  * @since 3.0.0 Renamed to perflab_enqueue_features_page_scripts().
+ * @since n.e.x.t Added enqueue plugin activate AJAX script.
  */
 function perflab_enqueue_features_page_scripts(): void {
 	// These assets are needed for the "Learn more" popover.
@@ -230,6 +230,24 @@ function perflab_enqueue_features_page_scripts(): void {
 
 	// Enqueue the a11y script.
 	wp_enqueue_script( 'wp-a11y' );
+
+	// Enqueue plugin activate AJAX script and localize script data.
+	wp_enqueue_script(
+		'perflab-plugin-activate-ajax',
+		PERFLAB_PLUGIN_DIR_URL . 'includes/admin/plugin-activate-ajax.js',
+		array( 'jquery', 'wp-i18n', 'wp-a11y' ),
+		(string) filemtime( PERFLAB_PLUGIN_DIR_PATH . 'includes/admin/plugin-activate-ajax.js' ),
+		true
+	);
+
+	wp_localize_script(
+		'perflab-plugin-activate-ajax',
+		'perflabPluginActivateAjaxData',
+		array(
+			'ajaxUrl' => admin_url( 'admin-ajax.php' ),
+			'nonce'   => wp_create_nonce( 'perflab_install_activate_plugin_ajax' ),
+		)
+	);
 }
 
 /**
@@ -435,181 +453,6 @@ static function ( $name ) {
 	}
 }
 
-/**
- * Callback function that print plugin progress indicator script.
- *
- * @since 3.1.0
- */
-function perflab_print_plugin_progress_indicator_script(): void {
-	$nonce = wp_create_nonce( 'perflab_install_activate_plugin_ajax' );
-
-	$script_data = array(
-		'ajaxUrl'               => admin_url( 'admin-ajax.php' ),
-		'nonce'                 => $nonce,
-		'activatingText'        => __( 'Activating...', 'performance-lab' ),
-		'activateText'          => __( 'Activate', 'performance-lab' ),
-		'activatedText'         => __( 'Active', 'performance-lab' ),
-		'dismissText'           => __( 'Dismiss this notice.', 'performance-lab' ),
-		'successText'           => __( 'Feature activated.', 'performance-lab' ),
-		'reviewText'            => __( ' Review ', 'performance-lab' ),
-		'settingsPrimaryText'   => __( 'settings', 'performance-lab' ),
-		'settingsSecondaryText' => __( 'Settings', 'performance-lab' ),
-		'endText'               => _x( '.', 'Punctuation mark', 'performance-lab' ),
-		'errorText'             => __( 'There was an error activating the plugin. Please try again.', 'performance-lab' ),
-	);
-
-	$js_function = <<<JS
-		function addPluginProgressIndicator( data ) {
-			document.addEventListener( 'DOMContentLoaded', function () {
-				document.addEventListener( 'click', async function ( event ) {
-					if (
-						event.target.classList.contains(
-							'perflab-install-active-plugin'
-						)
-					) {
-						// Prevent the default link behavior.
-						event.preventDefault();
-
-						const target = event.target;
-						target.classList.add( 'updating-message' );
-						target.textContent = data.activatingText;
-
-						wp.a11y.speak( data.activatingText );
-
-						const pluginSlug = target.getAttribute( 'data-plugin-slug' ).trim();
-
-						try {
-							const response = await fetch( data.ajaxUrl, {
-								method: 'POST',
-								credentials: 'same-origin',
-								headers: {
-									'Content-Type': 'application/x-www-form-urlencoded',
-								},
-								body: new URLSearchParams( {
-									action: 'perflab_install_activate_plugin',
-									slug: pluginSlug,
-									_ajax_nonce: data.nonce,
-								} ),
-							} );
-
-							const responseData = await response.json();
-
-							if ( !responseData.success ) {
-								showAdminNotice( data.errorText );
-
-								target.classList.remove('updating-message');
-								target.textContent = data.activateText;
-
-								return;
-							}
-
-							const newButton = document.createElement( 'button' );
-
-							newButton.type = 'button';
-							newButton.className = 'button button-disabled';
-							newButton.disabled = true;
-							newButton.textContent = data.activatedText;
-
-							target.parentNode.replaceChild( newButton, target );
-
-							const pluginSettingsURL = responseData?.data?.pluginSettingsURL;
-
-							const actionButtonList = document.querySelector( '.plugin-card-' + pluginSlug + ' .plugin-action-buttons' )
-
-							if ( pluginSettingsURL && actionButtonList ) {
-								const listItem = document.createElement( 'li' );
-								const anchor = document.createElement( 'a' );
-
-								anchor.setAttribute( 'href', pluginSettingsURL );
-								anchor.textContent = data.settingsSecondaryText;
-
-								listItem.appendChild( anchor );
-								actionButtonList.appendChild( listItem );
-							}
-							
-							showAdminNotice( data.successText, 'success', pluginSettingsURL );
-						} catch (error) {
-							showAdminNotice( data.errorText );
-
-							target.classList.remove( 'updating-message' );
-							target.textContent = data.activateText;
-						}
-					}
-				} );
-			} );
-
-			function showAdminNotice( message, type = 'error', pluginSettingsURL = undefined ) {
-				// Create the notice container elements.
-				const notice = document.createElement( 'div' );
-				const para = document.createElement( 'p' );
-				
-				notice.className = 'notice is-dismissible notice-' + type;
-				para.textContent = message;
-				
-				if ( pluginSettingsURL ) {
-					para.textContent = para.textContent + data.reviewText;
-					
-					const anchor = document.createElement( 'a' );
-					anchor.setAttribute( 'href', pluginSettingsURL );
-					anchor.textContent = data.settingsPrimaryText;
-					
-					para.appendChild( anchor );
-					para.appendChild( document.createTextNode( data.endText ) );
-				}
-				
-				notice.appendChild( para );
-				
-				const dismissButton = document.createElement( 'button' );
-				const dismissButtonTextWrap = document.createElement( 'span' );
-
-				dismissButton.type = 'button';
-				dismissButton.className = 'notice-dismiss';
-	
-				dismissButtonTextWrap.className = 'screen-reader-text';
-				dismissButtonTextWrap.textContent = data.dismissText;	
-
-				dismissButton.appendChild( dismissButtonTextWrap );
-
-				// Add event listener to remove the notice when dismissed.
-				dismissButton.addEventListener( 'click', () => {
-					notice.remove();
-				} );
-
-				notice.appendChild( dismissButton );
-	
-				// Insert the notice at the top of the admin notices area.
-				const noticeContainer = document.querySelector( '.wrap.plugin-install-php' ) || document.body;
-	
-				if ( !noticeContainer ) {
-					// Fallback append to body if no suitable container is found.
-					document.body.prepend( notice );
-
-					return;
-				} 
-
-				if ( noticeContainer.children.length >= 1 ) {
-					// Insert as the second child.
-					noticeContainer.insertBefore( notice, noticeContainer.children[1] );
-
-					return;
-				}
-
-				// If there's only one child or none, append as the last child.
-				noticeContainer.appendChild( notice );
-			}
-		}
-JS;
-
-	wp_print_inline_script_tag(
-		sprintf(
-			'( %s )( %s );',
-			$js_function,
-			wp_json_encode( $script_data )
-		),
-		array( 'type' => 'module' )
-	);
-}
-
 /**
  * Gets the URL to the plugin settings screen if one exists.
  *
diff --git a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
new file mode 100644
index 000000000..81e225aee
--- /dev/null
+++ b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
@@ -0,0 +1,193 @@
+/**
+ * Handles activation of Performance Features (Plugins) using AJAX.
+ */
+
+/* global perflabPluginActivateAjaxData */
+document.addEventListener( 'DOMContentLoaded', function () {
+	// @ts-ignore
+	const { i18n, a11y } = wp;
+	const { __, _x } = i18n;
+
+	/**
+	 * Adds a click event listener to the document.
+	 *
+	 * This asynchronous function listens for click events on the document and executes
+	 * the provided callback function if triggered.
+	 *
+	 * @param {MouseEvent} event - The click event object that is triggered when the user clicks on the document.
+	 *
+	 * @return {Promise<void>} - The asynchronous function returns a promise that resolves to void.
+	 */
+	document.addEventListener( 'click', async function ( event ) {
+		const target = /** @type {HTMLElement} */ ( event.target );
+
+		if ( target.classList.contains( 'perflab-install-active-plugin' ) ) {
+			// Prevent the default link behavior.
+			event.preventDefault();
+
+			target.classList.add( 'updating-message' );
+			target.textContent = __( 'Activating…', 'performance-lab' );
+
+			a11y.speak( __( 'Activating…', 'performance-lab' ) );
+
+			const pluginSlug = target.getAttribute( 'data-plugin-slug' ).trim();
+
+			try {
+				const response = await fetch(
+					// @ts-ignore
+					perflabPluginActivateAjaxData.ajaxUrl,
+					{
+						method: 'POST',
+						credentials: 'same-origin',
+						headers: {
+							'Content-Type': 'application/x-www-form-urlencoded',
+						},
+						body: new URLSearchParams( {
+							action: 'perflab_install_activate_plugin',
+							slug: pluginSlug,
+							// @ts-ignore
+							_ajax_nonce: perflabPluginActivateAjaxData.nonce,
+						} ),
+					}
+				);
+
+				const responseData = await response.json();
+
+				if ( ! responseData.success ) {
+					showAdminNotice(
+						__(
+							'There was an error activating the plugin. Please try again.',
+							'performance-lab'
+						)
+					);
+
+					target.classList.remove( 'updating-message' );
+					target.textContent = __( 'Activate', 'performance-lab' );
+
+					return;
+				}
+
+				const newButton = document.createElement( 'button' );
+
+				newButton.type = 'button';
+				newButton.className = 'button button-disabled';
+				newButton.disabled = true;
+				newButton.textContent = __( 'Active', 'performance-lab' );
+
+				target.parentNode.replaceChild( newButton, target );
+
+				const pluginSettingsURL = responseData?.data?.pluginSettingsURL;
+
+				const actionButtonList = document.querySelector(
+					'.plugin-card-' + pluginSlug + ' .plugin-action-buttons'
+				);
+
+				if ( pluginSettingsURL && actionButtonList ) {
+					const listItem = document.createElement( 'li' );
+					const anchor = document.createElement( 'a' );
+
+					anchor.setAttribute( 'href', pluginSettingsURL );
+					anchor.textContent = __( 'Settings', 'performance-lab' );
+
+					listItem.appendChild( anchor );
+					actionButtonList.appendChild( listItem );
+				}
+
+				showAdminNotice(
+					__( 'Feature activated.', 'performance-lab' ),
+					'success',
+					pluginSettingsURL
+				);
+			} catch ( error ) {
+				showAdminNotice(
+					__(
+						'There was an error activating the plugin. Please try again.',
+						'performance-lab'
+					)
+				);
+
+				target.classList.remove( 'updating-message' );
+				target.textContent = __( 'Activate', 'performance-lab' );
+			}
+		}
+	} );
+
+	function showAdminNotice(
+		message,
+		type = 'error',
+		pluginSettingsURL = undefined
+	) {
+		// Create the notice container elements.
+		const notice = document.createElement( 'div' );
+		const para = document.createElement( 'p' );
+
+		notice.className = 'notice is-dismissible notice-' + type;
+		para.textContent = message;
+
+		if ( pluginSettingsURL ) {
+			para.textContent = `${ para.textContent } ${ __(
+				'Review',
+				'performance-lab'
+			) } `;
+
+			const anchor = document.createElement( 'a' );
+			anchor.setAttribute( 'href', pluginSettingsURL );
+			anchor.textContent = __( 'settings', 'performance-lab' );
+
+			para.appendChild( anchor );
+			para.appendChild(
+				document.createTextNode(
+					_x( '.', 'Punctuation mark', 'performance-lab' )
+				)
+			);
+		}
+
+		notice.appendChild( para );
+
+		const dismissButton = document.createElement( 'button' );
+		const dismissButtonTextWrap = document.createElement( 'span' );
+
+		dismissButton.type = 'button';
+		dismissButton.className = 'notice-dismiss';
+
+		dismissButtonTextWrap.className = 'screen-reader-text';
+		dismissButtonTextWrap.textContent = __(
+			'Dismiss this notice.',
+			'performance-lab'
+		);
+
+		dismissButton.appendChild( dismissButtonTextWrap );
+
+		// Add event listener to remove the notice when dismissed.
+		dismissButton.addEventListener( 'click', () => {
+			notice.remove();
+		} );
+
+		notice.appendChild( dismissButton );
+
+		// Insert the notice at the top of the admin notices area.
+		const noticeContainer =
+			document.querySelector( '.wrap.plugin-install-php' ) ||
+			document.body;
+
+		if ( ! noticeContainer ) {
+			// Fallback append to body if no suitable container is found.
+			document.body.prepend( notice );
+
+			return;
+		}
+
+		if ( noticeContainer.children.length >= 1 ) {
+			// Insert as the second child.
+			noticeContainer.insertBefore(
+				notice,
+				noticeContainer.children[ 1 ]
+			);
+
+			return;
+		}
+
+		// If there's only one child or none, append as the last child.
+		noticeContainer.appendChild( notice );
+	}
+} );
diff --git a/plugins/performance-lab/load.php b/plugins/performance-lab/load.php
index 304089d13..2a80a2906 100644
--- a/plugins/performance-lab/load.php
+++ b/plugins/performance-lab/load.php
@@ -22,6 +22,7 @@
 define( 'PERFLAB_VERSION', '3.5.1' );
 define( 'PERFLAB_MAIN_FILE', __FILE__ );
 define( 'PERFLAB_PLUGIN_DIR_PATH', plugin_dir_path( PERFLAB_MAIN_FILE ) );
+define( 'PERFLAB_PLUGIN_DIR_URL', plugin_dir_url( PERFLAB_MAIN_FILE ) );
 define( 'PERFLAB_SCREEN', 'performance-lab' );
 
 // If the constant isn't defined yet, it means the Performance Lab object cache file is not loaded.

From 58c37d9cfd6aa1600297872aa1cc42f6c0380fd0 Mon Sep 17 00:00:00 2001
From: b1ink0 <aditya.dhade@rtcamp.com>
Date: Mon, 11 Nov 2024 17:10:46 +0530
Subject: [PATCH 05/14] Refactor JavaScript code to use jQuery

---
 .../performance-lab/includes/admin/load.php   |   2 +
 .../includes/admin/plugin-activate-ajax.js    | 202 ++++++++----------
 .../includes/admin/plugins.php                |   1 +
 3 files changed, 94 insertions(+), 111 deletions(-)

diff --git a/plugins/performance-lab/includes/admin/load.php b/plugins/performance-lab/includes/admin/load.php
index 862f83fce..84037958a 100644
--- a/plugins/performance-lab/includes/admin/load.php
+++ b/plugins/performance-lab/includes/admin/load.php
@@ -310,6 +310,8 @@ function perflab_install_activate_plugin_callback(): void {
 
 /**
  * Callback for handling installation/activation of plugin using ajax.
+ *
+ * @since n.e.x.t
  */
 function perflab_install_activate_plugin_ajax_callback(): void {
 	check_ajax_referer( 'perflab_install_activate_plugin_ajax', '_ajax_nonce' );
diff --git a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
index 81e225aee..f56db4ed2 100644
--- a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
+++ b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
@@ -3,56 +3,54 @@
  */
 
 /* global perflabPluginActivateAjaxData */
-document.addEventListener( 'DOMContentLoaded', function () {
+/* global jQuery */
+// @ts-ignore
+jQuery( document ).ready( ( $ ) => {
 	// @ts-ignore
 	const { i18n, a11y } = wp;
 	const { __, _x } = i18n;
 
 	/**
-	 * Adds a click event listener to the document.
-	 *
-	 * This asynchronous function listens for click events on the document and executes
-	 * the provided callback function if triggered.
+	 * Adds a click event listener to the plugin activate buttons.
 	 *
 	 * @param {MouseEvent} event - The click event object that is triggered when the user clicks on the document.
 	 *
-	 * @return {Promise<void>} - The asynchronous function returns a promise that resolves to void.
+	 * @return {Promise<void>} - The asynchronous function returns a promise.
 	 */
-	document.addEventListener( 'click', async function ( event ) {
-		const target = /** @type {HTMLElement} */ ( event.target );
-
-		if ( target.classList.contains( 'perflab-install-active-plugin' ) ) {
+	$( document ).on(
+		'click',
+		'.perflab-install-active-plugin',
+		async function ( event ) {
 			// Prevent the default link behavior.
 			event.preventDefault();
 
-			target.classList.add( 'updating-message' );
-			target.textContent = __( 'Activating…', 'performance-lab' );
+			// Get the clicked element as a jQuery object.
+			const target = $( this );
+
+			target
+				.addClass( 'updating-message' )
+				.text( __( 'Activating…', 'performance-lab' ) );
 
 			a11y.speak( __( 'Activating…', 'performance-lab' ) );
 
-			const pluginSlug = target.getAttribute( 'data-plugin-slug' ).trim();
+			// Retrieve the plugin slug from the data attribute.
+			const pluginSlug = $.trim( target.attr( 'data-plugin-slug' ) );
 
 			try {
-				const response = await fetch(
+				// Send an AJAX POST request to activate the plugin.
+				const responseData = await $.post(
 					// @ts-ignore
 					perflabPluginActivateAjaxData.ajaxUrl,
 					{
-						method: 'POST',
-						credentials: 'same-origin',
-						headers: {
-							'Content-Type': 'application/x-www-form-urlencoded',
-						},
-						body: new URLSearchParams( {
-							action: 'perflab_install_activate_plugin',
-							slug: pluginSlug,
-							// @ts-ignore
-							_ajax_nonce: perflabPluginActivateAjaxData.nonce,
-						} ),
-					}
+						action: 'perflab_install_activate_plugin',
+						slug: pluginSlug,
+						// @ts-ignore
+						_ajax_nonce: perflabPluginActivateAjaxData.nonce,
+					},
+					null,
+					'json'
 				);
 
-				const responseData = await response.json();
-
 				if ( ! responseData.success ) {
 					showAdminNotice(
 						__(
@@ -61,36 +59,40 @@ document.addEventListener( 'DOMContentLoaded', function () {
 						)
 					);
 
-					target.classList.remove( 'updating-message' );
-					target.textContent = __( 'Activate', 'performance-lab' );
+					target
+						.removeClass( 'updating-message' )
+						.text( __( 'Activate', 'performance-lab' ) );
 
 					return;
 				}
 
-				const newButton = document.createElement( 'button' );
-
-				newButton.type = 'button';
-				newButton.className = 'button button-disabled';
-				newButton.disabled = true;
-				newButton.textContent = __( 'Active', 'performance-lab' );
-
-				target.parentNode.replaceChild( newButton, target );
+				// Replace the 'Activate' button with a disabled 'Active' button.
+				target.replaceWith(
+					$( '<button>', {
+						type: 'button',
+						class: 'button button-disabled',
+						disabled: true,
+						text: __( 'Active', 'performance-lab' ),
+					} )
+				);
 
 				const pluginSettingsURL = responseData?.data?.pluginSettingsURL;
 
-				const actionButtonList = document.querySelector(
-					'.plugin-card-' + pluginSlug + ' .plugin-action-buttons'
+				// Select the container for action buttons related to the plugin.
+				const actionButtonList = $(
+					`.plugin-card-${ pluginSlug } .plugin-action-buttons`
 				);
 
 				if ( pluginSettingsURL && actionButtonList ) {
-					const listItem = document.createElement( 'li' );
-					const anchor = document.createElement( 'a' );
-
-					anchor.setAttribute( 'href', pluginSettingsURL );
-					anchor.textContent = __( 'Settings', 'performance-lab' );
-
-					listItem.appendChild( anchor );
-					actionButtonList.appendChild( listItem );
+					// Append a 'Settings' link to the action buttons.
+					actionButtonList.append(
+						$( '<li>' ).append(
+							$( '<a>', {
+								href: pluginSettingsURL,
+								text: __( 'Settings', 'performance-lab' ),
+							} )
+						)
+					);
 				}
 
 				showAdminNotice(
@@ -106,88 +108,66 @@ document.addEventListener( 'DOMContentLoaded', function () {
 					)
 				);
 
-				target.classList.remove( 'updating-message' );
-				target.textContent = __( 'Activate', 'performance-lab' );
+				target
+					.removeClass( 'updating-message' )
+					.text( __( 'Activate', 'performance-lab' ) );
 			}
 		}
-	} );
+	);
 
+	/**
+	 * Displays an admin notice with the given message and type.
+	 *
+	 * @param {string} message             - The message to display in the notice.
+	 * @param {string} [type='error']      - The type of notice ('error', 'success', etc.).
+	 * @param {string} [pluginSettingsURL] - Optional URL for the plugin settings.
+	 */
 	function showAdminNotice(
 		message,
 		type = 'error',
 		pluginSettingsURL = undefined
 	) {
+		a11y.speak( message );
+
 		// Create the notice container elements.
-		const notice = document.createElement( 'div' );
-		const para = document.createElement( 'p' );
+		const notice = $( '<div>', {
+			class: `notice is-dismissible notice-${ type }`,
+		} );
 
-		notice.className = 'notice is-dismissible notice-' + type;
-		para.textContent = message;
+		const para = $( '<p>' ).text( message );
 
+		// If a plugin settings URL is provided, append a 'Review settings.' link.
 		if ( pluginSettingsURL ) {
-			para.textContent = `${ para.textContent } ${ __(
-				'Review',
-				'performance-lab'
-			) } `;
-
-			const anchor = document.createElement( 'a' );
-			anchor.setAttribute( 'href', pluginSettingsURL );
-			anchor.textContent = __( 'settings', 'performance-lab' );
-
-			para.appendChild( anchor );
-			para.appendChild(
-				document.createTextNode(
-					_x( '.', 'Punctuation mark', 'performance-lab' )
+			para.append( ` ${ __( 'Review', 'performance-lab' ) } ` )
+				.append(
+					$( '<a>', {
+						href: pluginSettingsURL,
+						text: __( 'settings', 'performance-lab' ),
+					} )
 				)
-			);
+				.append( _x( '.', 'Punctuation mark', 'performance-lab' ) );
 		}
 
-		notice.appendChild( para );
-
-		const dismissButton = document.createElement( 'button' );
-		const dismissButtonTextWrap = document.createElement( 'span' );
-
-		dismissButton.type = 'button';
-		dismissButton.className = 'notice-dismiss';
-
-		dismissButtonTextWrap.className = 'screen-reader-text';
-		dismissButtonTextWrap.textContent = __(
-			'Dismiss this notice.',
-			'performance-lab'
+		const dismissButton = $( '<button>', {
+			type: 'button',
+			class: 'notice-dismiss',
+			click: () => notice.remove(),
+		} ).append(
+			$( '<span>', {
+				class: 'screen-reader-text',
+				text: __( 'Dismiss this notice.', 'performance-lab' ),
+			} )
 		);
 
-		dismissButton.appendChild( dismissButtonTextWrap );
-
-		// Add event listener to remove the notice when dismissed.
-		dismissButton.addEventListener( 'click', () => {
-			notice.remove();
-		} );
+		notice.append( para, dismissButton );
 
-		notice.appendChild( dismissButton );
+		const noticeContainer = $( '.wrap.plugin-install-php' );
 
-		// Insert the notice at the top of the admin notices area.
-		const noticeContainer =
-			document.querySelector( '.wrap.plugin-install-php' ) ||
-			document.body;
-
-		if ( ! noticeContainer ) {
-			// Fallback append to body if no suitable container is found.
-			document.body.prepend( notice );
-
-			return;
-		}
-
-		if ( noticeContainer.children.length >= 1 ) {
-			// Insert as the second child.
-			noticeContainer.insertBefore(
-				notice,
-				noticeContainer.children[ 1 ]
-			);
-
-			return;
+		if ( noticeContainer.length ) {
+			// If the container exists, insert the notice after the first child.
+			noticeContainer.children().eq( 0 ).after( notice );
+		} else {
+			$( 'body' ).prepend( notice );
 		}
-
-		// If there's only one child or none, append as the last child.
-		noticeContainer.appendChild( notice );
 	}
 } );
diff --git a/plugins/performance-lab/includes/admin/plugins.php b/plugins/performance-lab/includes/admin/plugins.php
index 95b43d1e5..8808ce7c9 100644
--- a/plugins/performance-lab/includes/admin/plugins.php
+++ b/plugins/performance-lab/includes/admin/plugins.php
@@ -383,6 +383,7 @@ function perflab_install_and_activate_plugin( string $plugin_slug, array &$proce
  * This is adapted from `WP_Plugin_Install_List_Table::display_rows()` in core.
  *
  * @since 2.8.0
+ * @since n.e.x.t Added data attribute `data-plugin-slug` in plugin activate link.
  *
  * @see WP_Plugin_Install_List_Table::display_rows()
  * @link https://github.com/WordPress/wordpress-develop/blob/0b8ca16ea3bd9722bd1a38f8ab68901506b1a0e7/src/wp-admin/includes/class-wp-plugin-install-list-table.php#L467-L830

From a59909d0bb58c997afaf4bed757c509642453917 Mon Sep 17 00:00:00 2001
From: b1ink0 <aditya.dhade@rtcamp.com>
Date: Mon, 11 Nov 2024 22:46:02 +0530
Subject: [PATCH 06/14] Update to use IIFE, Remove unnecessary doc comment

---
 .../performance-lab/includes/admin/load.php   |   3 -
 .../includes/admin/plugin-activate-ajax.js    | 146 +++++++++---------
 .../includes/admin/plugins.php                |   1 -
 3 files changed, 74 insertions(+), 76 deletions(-)

diff --git a/plugins/performance-lab/includes/admin/load.php b/plugins/performance-lab/includes/admin/load.php
index 84037958a..43ca50a8c 100644
--- a/plugins/performance-lab/includes/admin/load.php
+++ b/plugins/performance-lab/includes/admin/load.php
@@ -39,8 +39,6 @@ function perflab_add_features_page(): void {
  * @since 1.0.0
  * @since 3.0.0 Renamed to perflab_load_features_page(), and the
  *              $module and $hook_suffix parameters were removed.
- * @since n.e.x.t Removed added action for perflab_print_plugin_progress_indicator_script
- *                as this function is removed.
  */
 function perflab_load_features_page(): void {
 	// Handle script enqueuing for settings page.
@@ -220,7 +218,6 @@ function perflab_dismiss_wp_pointer_wrapper(): void {
  *
  * @since 2.8.0
  * @since 3.0.0 Renamed to perflab_enqueue_features_page_scripts().
- * @since n.e.x.t Added enqueue plugin activate AJAX script.
  */
 function perflab_enqueue_features_page_scripts(): void {
 	// These assets are needed for the "Learn more" popover.
diff --git a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
index f56db4ed2..33e955b79 100644
--- a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
+++ b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
@@ -3,9 +3,7 @@
  */
 
 /* global perflabPluginActivateAjaxData */
-/* global jQuery */
-// @ts-ignore
-jQuery( document ).ready( ( $ ) => {
+( function ( $ ) {
 	// @ts-ignore
 	const { i18n, a11y } = wp;
 	const { __, _x } = i18n;
@@ -36,22 +34,71 @@ jQuery( document ).ready( ( $ ) => {
 			// Retrieve the plugin slug from the data attribute.
 			const pluginSlug = $.trim( target.attr( 'data-plugin-slug' ) );
 
-			try {
-				// Send an AJAX POST request to activate the plugin.
-				const responseData = await $.post(
+			// Send an AJAX POST request to activate the plugin.
+			$.ajax( {
+				// @ts-ignore
+				url: perflabPluginActivateAjaxData.ajaxUrl,
+				method: 'POST',
+				dataType: 'json',
+				data: {
+					action: 'perflab_install_activate_plugin',
+					slug: pluginSlug,
 					// @ts-ignore
-					perflabPluginActivateAjaxData.ajaxUrl,
-					{
-						action: 'perflab_install_activate_plugin',
-						slug: pluginSlug,
-						// @ts-ignore
-						_ajax_nonce: perflabPluginActivateAjaxData.nonce,
-					},
-					null,
-					'json'
-				);
-
-				if ( ! responseData.success ) {
+					_ajax_nonce: perflabPluginActivateAjaxData.nonce,
+				},
+				success( responseData ) {
+					if ( ! responseData.success ) {
+						showAdminNotice(
+							__(
+								'There was an error activating the plugin. Please try again.',
+								'performance-lab'
+							)
+						);
+
+						target
+							.removeClass( 'updating-message' )
+							.text( __( 'Activate', 'performance-lab' ) );
+
+						return;
+					}
+
+					// Replace the 'Activate' button with a disabled 'Active' button.
+					target.replaceWith(
+						$( '<button>', {
+							type: 'button',
+							class: 'button button-disabled',
+							disabled: true,
+							text: __( 'Active', 'performance-lab' ),
+						} )
+					);
+
+					const pluginSettingsURL =
+						responseData?.data?.pluginSettingsURL;
+
+					// Select the container for action buttons related to the plugin.
+					const actionButtonList = $(
+						`.plugin-card-${ pluginSlug } .plugin-action-buttons`
+					);
+
+					if ( pluginSettingsURL && actionButtonList ) {
+						// Append a 'Settings' link to the action buttons.
+						actionButtonList.append(
+							$( '<li>' ).append(
+								$( '<a>', {
+									href: pluginSettingsURL,
+									text: __( 'Settings', 'performance-lab' ),
+								} )
+							)
+						);
+					}
+
+					showAdminNotice(
+						__( 'Feature activated.', 'performance-lab' ),
+						'success',
+						pluginSettingsURL
+					);
+				},
+				error() {
 					showAdminNotice(
 						__(
 							'There was an error activating the plugin. Please try again.',
@@ -62,56 +109,8 @@ jQuery( document ).ready( ( $ ) => {
 					target
 						.removeClass( 'updating-message' )
 						.text( __( 'Activate', 'performance-lab' ) );
-
-					return;
-				}
-
-				// Replace the 'Activate' button with a disabled 'Active' button.
-				target.replaceWith(
-					$( '<button>', {
-						type: 'button',
-						class: 'button button-disabled',
-						disabled: true,
-						text: __( 'Active', 'performance-lab' ),
-					} )
-				);
-
-				const pluginSettingsURL = responseData?.data?.pluginSettingsURL;
-
-				// Select the container for action buttons related to the plugin.
-				const actionButtonList = $(
-					`.plugin-card-${ pluginSlug } .plugin-action-buttons`
-				);
-
-				if ( pluginSettingsURL && actionButtonList ) {
-					// Append a 'Settings' link to the action buttons.
-					actionButtonList.append(
-						$( '<li>' ).append(
-							$( '<a>', {
-								href: pluginSettingsURL,
-								text: __( 'Settings', 'performance-lab' ),
-							} )
-						)
-					);
-				}
-
-				showAdminNotice(
-					__( 'Feature activated.', 'performance-lab' ),
-					'success',
-					pluginSettingsURL
-				);
-			} catch ( error ) {
-				showAdminNotice(
-					__(
-						'There was an error activating the plugin. Please try again.',
-						'performance-lab'
-					)
-				);
-
-				target
-					.removeClass( 'updating-message' )
-					.text( __( 'Activate', 'performance-lab' ) );
-			}
+				},
+			} );
 		}
 	);
 
@@ -134,11 +133,12 @@ jQuery( document ).ready( ( $ ) => {
 			class: `notice is-dismissible notice-${ type }`,
 		} );
 
-		const para = $( '<p>' ).text( message );
+		const messageWrap = $( '<p>' ).text( message );
 
 		// If a plugin settings URL is provided, append a 'Review settings.' link.
 		if ( pluginSettingsURL ) {
-			para.append( ` ${ __( 'Review', 'performance-lab' ) } ` )
+			messageWrap
+				.append( ` ${ __( 'Review', 'performance-lab' ) } ` )
 				.append(
 					$( '<a>', {
 						href: pluginSettingsURL,
@@ -159,7 +159,7 @@ jQuery( document ).ready( ( $ ) => {
 			} )
 		);
 
-		notice.append( para, dismissButton );
+		notice.append( messageWrap, dismissButton );
 
 		const noticeContainer = $( '.wrap.plugin-install-php' );
 
@@ -170,4 +170,6 @@ jQuery( document ).ready( ( $ ) => {
 			$( 'body' ).prepend( notice );
 		}
 	}
-} );
+
+	// @ts-ignore
+} )( window.jQuery );
diff --git a/plugins/performance-lab/includes/admin/plugins.php b/plugins/performance-lab/includes/admin/plugins.php
index 8808ce7c9..95b43d1e5 100644
--- a/plugins/performance-lab/includes/admin/plugins.php
+++ b/plugins/performance-lab/includes/admin/plugins.php
@@ -383,7 +383,6 @@ function perflab_install_and_activate_plugin( string $plugin_slug, array &$proce
  * This is adapted from `WP_Plugin_Install_List_Table::display_rows()` in core.
  *
  * @since 2.8.0
- * @since n.e.x.t Added data attribute `data-plugin-slug` in plugin activate link.
  *
  * @see WP_Plugin_Install_List_Table::display_rows()
  * @link https://github.com/WordPress/wordpress-develop/blob/0b8ca16ea3bd9722bd1a38f8ab68901506b1a0e7/src/wp-admin/includes/class-wp-plugin-install-list-table.php#L467-L830

From e6710a3aab6c9847ff79b5a37d3c3678dfb4762d Mon Sep 17 00:00:00 2001
From: b1ink0 <aditya.dhade@rtcamp.com>
Date: Tue, 12 Nov 2024 14:27:35 +0530
Subject: [PATCH 07/14] Remove admin notice part, Remove constant, Use
 plugin_url for JS file path

---
 .../performance-lab/includes/admin/load.php   |  6 +-
 .../includes/admin/plugin-activate-ajax.js    | 93 ++-----------------
 plugins/performance-lab/load.php              |  1 -
 3 files changed, 11 insertions(+), 89 deletions(-)

diff --git a/plugins/performance-lab/includes/admin/load.php b/plugins/performance-lab/includes/admin/load.php
index 43ca50a8c..7610ed64a 100644
--- a/plugins/performance-lab/includes/admin/load.php
+++ b/plugins/performance-lab/includes/admin/load.php
@@ -231,9 +231,9 @@ function perflab_enqueue_features_page_scripts(): void {
 	// Enqueue plugin activate AJAX script and localize script data.
 	wp_enqueue_script(
 		'perflab-plugin-activate-ajax',
-		PERFLAB_PLUGIN_DIR_URL . 'includes/admin/plugin-activate-ajax.js',
+		plugins_url( 'includes/admin/plugin-activate-ajax.js', PERFLAB_MAIN_FILE ),
 		array( 'jquery', 'wp-i18n', 'wp-a11y' ),
-		(string) filemtime( PERFLAB_PLUGIN_DIR_PATH . 'includes/admin/plugin-activate-ajax.js' ),
+		PERFLAB_VERSION,
 		true
 	);
 
@@ -337,7 +337,7 @@ function perflab_install_activate_plugin_ajax_callback(): void {
 	if ( null !== $plugin_settings_url ) {
 		wp_send_json_success(
 			array(
-				'pluginSettingsURL' => esc_url( $plugin_settings_url ),
+				'pluginSettingsURL' => esc_url_raw( $plugin_settings_url ),
 			)
 		);
 	}
diff --git a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
index 33e955b79..adcbd7248 100644
--- a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
+++ b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
@@ -6,18 +6,18 @@
 ( function ( $ ) {
 	// @ts-ignore
 	const { i18n, a11y } = wp;
-	const { __, _x } = i18n;
+	const { __ } = i18n;
 
-	/**
-	 * Adds a click event listener to the plugin activate buttons.
-	 *
-	 * @param {MouseEvent} event - The click event object that is triggered when the user clicks on the document.
-	 *
-	 * @return {Promise<void>} - The asynchronous function returns a promise.
-	 */
 	$( document ).on(
 		'click',
 		'.perflab-install-active-plugin',
+		/**
+		 * Adds a click event listener to the plugin activate buttons.
+		 *
+		 * @param {MouseEvent} event - The click event object that is triggered when the user clicks on the document.
+		 *
+		 * @return {Promise<void>} - The asynchronous function returns a promise.
+		 */
 		async function ( event ) {
 			// Prevent the default link behavior.
 			event.preventDefault();
@@ -48,13 +48,6 @@
 				},
 				success( responseData ) {
 					if ( ! responseData.success ) {
-						showAdminNotice(
-							__(
-								'There was an error activating the plugin. Please try again.',
-								'performance-lab'
-							)
-						);
-
 						target
 							.removeClass( 'updating-message' )
 							.text( __( 'Activate', 'performance-lab' ) );
@@ -91,21 +84,8 @@
 							)
 						);
 					}
-
-					showAdminNotice(
-						__( 'Feature activated.', 'performance-lab' ),
-						'success',
-						pluginSettingsURL
-					);
 				},
 				error() {
-					showAdminNotice(
-						__(
-							'There was an error activating the plugin. Please try again.',
-							'performance-lab'
-						)
-					);
-
 					target
 						.removeClass( 'updating-message' )
 						.text( __( 'Activate', 'performance-lab' ) );
@@ -114,62 +94,5 @@
 		}
 	);
 
-	/**
-	 * Displays an admin notice with the given message and type.
-	 *
-	 * @param {string} message             - The message to display in the notice.
-	 * @param {string} [type='error']      - The type of notice ('error', 'success', etc.).
-	 * @param {string} [pluginSettingsURL] - Optional URL for the plugin settings.
-	 */
-	function showAdminNotice(
-		message,
-		type = 'error',
-		pluginSettingsURL = undefined
-	) {
-		a11y.speak( message );
-
-		// Create the notice container elements.
-		const notice = $( '<div>', {
-			class: `notice is-dismissible notice-${ type }`,
-		} );
-
-		const messageWrap = $( '<p>' ).text( message );
-
-		// If a plugin settings URL is provided, append a 'Review settings.' link.
-		if ( pluginSettingsURL ) {
-			messageWrap
-				.append( ` ${ __( 'Review', 'performance-lab' ) } ` )
-				.append(
-					$( '<a>', {
-						href: pluginSettingsURL,
-						text: __( 'settings', 'performance-lab' ),
-					} )
-				)
-				.append( _x( '.', 'Punctuation mark', 'performance-lab' ) );
-		}
-
-		const dismissButton = $( '<button>', {
-			type: 'button',
-			class: 'notice-dismiss',
-			click: () => notice.remove(),
-		} ).append(
-			$( '<span>', {
-				class: 'screen-reader-text',
-				text: __( 'Dismiss this notice.', 'performance-lab' ),
-			} )
-		);
-
-		notice.append( messageWrap, dismissButton );
-
-		const noticeContainer = $( '.wrap.plugin-install-php' );
-
-		if ( noticeContainer.length ) {
-			// If the container exists, insert the notice after the first child.
-			noticeContainer.children().eq( 0 ).after( notice );
-		} else {
-			$( 'body' ).prepend( notice );
-		}
-	}
-
 	// @ts-ignore
 } )( window.jQuery );
diff --git a/plugins/performance-lab/load.php b/plugins/performance-lab/load.php
index 2a80a2906..304089d13 100644
--- a/plugins/performance-lab/load.php
+++ b/plugins/performance-lab/load.php
@@ -22,7 +22,6 @@
 define( 'PERFLAB_VERSION', '3.5.1' );
 define( 'PERFLAB_MAIN_FILE', __FILE__ );
 define( 'PERFLAB_PLUGIN_DIR_PATH', plugin_dir_path( PERFLAB_MAIN_FILE ) );
-define( 'PERFLAB_PLUGIN_DIR_URL', plugin_dir_url( PERFLAB_MAIN_FILE ) );
 define( 'PERFLAB_SCREEN', 'performance-lab' );
 
 // If the constant isn't defined yet, it means the Performance Lab object cache file is not loaded.

From c3d35883190e2612dafa70e80d911428d4816b99 Mon Sep 17 00:00:00 2001
From: b1ink0 <aditya.dhade@rtcamp.com>
Date: Tue, 12 Nov 2024 15:31:01 +0530
Subject: [PATCH 08/14] Refactor to use vanilla JavaScript

---
 .../performance-lab/includes/admin/load.php   |   2 +-
 .../includes/admin/plugin-activate-ajax.js    | 174 +++++++++---------
 2 files changed, 89 insertions(+), 87 deletions(-)

diff --git a/plugins/performance-lab/includes/admin/load.php b/plugins/performance-lab/includes/admin/load.php
index 7610ed64a..d9ead6b09 100644
--- a/plugins/performance-lab/includes/admin/load.php
+++ b/plugins/performance-lab/includes/admin/load.php
@@ -232,7 +232,7 @@ function perflab_enqueue_features_page_scripts(): void {
 	wp_enqueue_script(
 		'perflab-plugin-activate-ajax',
 		plugins_url( 'includes/admin/plugin-activate-ajax.js', PERFLAB_MAIN_FILE ),
-		array( 'jquery', 'wp-i18n', 'wp-a11y' ),
+		array( 'wp-i18n', 'wp-a11y' ),
 		PERFLAB_VERSION,
 		true
 	);
diff --git a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
index adcbd7248..5f5cc0078 100644
--- a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
+++ b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
@@ -3,96 +3,98 @@
  */
 
 /* global perflabPluginActivateAjaxData */
-( function ( $ ) {
+( function () {
 	// @ts-ignore
 	const { i18n, a11y } = wp;
 	const { __ } = i18n;
 
-	$( document ).on(
-		'click',
-		'.perflab-install-active-plugin',
-		/**
-		 * Adds a click event listener to the plugin activate buttons.
-		 *
-		 * @param {MouseEvent} event - The click event object that is triggered when the user clicks on the document.
-		 *
-		 * @return {Promise<void>} - The asynchronous function returns a promise.
-		 */
-		async function ( event ) {
-			// Prevent the default link behavior.
-			event.preventDefault();
-
-			// Get the clicked element as a jQuery object.
-			const target = $( this );
-
-			target
-				.addClass( 'updating-message' )
-				.text( __( 'Activating…', 'performance-lab' ) );
-
-			a11y.speak( __( 'Activating…', 'performance-lab' ) );
-
-			// Retrieve the plugin slug from the data attribute.
-			const pluginSlug = $.trim( target.attr( 'data-plugin-slug' ) );
-
-			// Send an AJAX POST request to activate the plugin.
-			$.ajax( {
+	/**
+	 * Handles click events on elements with the class 'perflab-install-active-plugin'.
+	 *
+	 * This asynchronous function listens for click events on the document and executes
+	 * the provided callback function if triggered.
+	 *
+	 * @param {MouseEvent} event - The click event object that is triggered when the user clicks on the document.
+	 *
+	 * @return {Promise<void>} - The asynchronous function returns a promise that resolves to void.
+	 */
+	async function handlePluginActivationClick( event ) {
+		const target = /** @type {HTMLElement} */ ( event.target );
+
+		if ( ! target.classList.contains( 'perflab-install-active-plugin' ) ) {
+			return;
+		}
+
+		// Prevent the default link behavior.
+		event.preventDefault();
+
+		target.classList.add( 'updating-message' );
+		target.textContent = __( 'Activating…', 'performance-lab' );
+
+		a11y.speak( __( 'Activating…', 'performance-lab' ) );
+
+		const pluginSlug = target.getAttribute( 'data-plugin-slug' ).trim();
+
+		// Send an AJAX POST request to activate the plugin.
+		try {
+			const response = await fetch(
 				// @ts-ignore
-				url: perflabPluginActivateAjaxData.ajaxUrl,
-				method: 'POST',
-				dataType: 'json',
-				data: {
-					action: 'perflab_install_activate_plugin',
-					slug: pluginSlug,
-					// @ts-ignore
-					_ajax_nonce: perflabPluginActivateAjaxData.nonce,
-				},
-				success( responseData ) {
-					if ( ! responseData.success ) {
-						target
-							.removeClass( 'updating-message' )
-							.text( __( 'Activate', 'performance-lab' ) );
-
-						return;
-					}
-
-					// Replace the 'Activate' button with a disabled 'Active' button.
-					target.replaceWith(
-						$( '<button>', {
-							type: 'button',
-							class: 'button button-disabled',
-							disabled: true,
-							text: __( 'Active', 'performance-lab' ),
-						} )
-					);
-
-					const pluginSettingsURL =
-						responseData?.data?.pluginSettingsURL;
-
-					// Select the container for action buttons related to the plugin.
-					const actionButtonList = $(
-						`.plugin-card-${ pluginSlug } .plugin-action-buttons`
-					);
-
-					if ( pluginSettingsURL && actionButtonList ) {
-						// Append a 'Settings' link to the action buttons.
-						actionButtonList.append(
-							$( '<li>' ).append(
-								$( '<a>', {
-									href: pluginSettingsURL,
-									text: __( 'Settings', 'performance-lab' ),
-								} )
-							)
-						);
-					}
-				},
-				error() {
-					target
-						.removeClass( 'updating-message' )
-						.text( __( 'Activate', 'performance-lab' ) );
-				},
-			} );
+				perflabPluginActivateAjaxData.ajaxUrl,
+				{
+					method: 'POST',
+					credentials: 'same-origin',
+					headers: {
+						'Content-Type': 'application/x-www-form-urlencoded',
+					},
+					body: new URLSearchParams( {
+						action: 'perflab_install_activate_plugin',
+						slug: pluginSlug,
+						// @ts-ignore
+						_ajax_nonce: perflabPluginActivateAjaxData.nonce,
+					} ),
+				}
+			);
+
+			const responseData = await response.json();
+
+			if ( ! responseData.success ) {
+				target.classList.remove( 'updating-message' );
+				target.textContent = __( 'Activate', 'performance-lab' );
+
+				return;
+			}
+
+			const newButton = document.createElement( 'button' );
+
+			newButton.type = 'button';
+			newButton.className = 'button button-disabled';
+			newButton.disabled = true;
+			newButton.textContent = __( 'Active', 'performance-lab' );
+
+			target.parentNode.replaceChild( newButton, target );
+
+			const pluginSettingsURL = responseData?.data?.pluginSettingsURL;
+
+			const actionButtonList = document.querySelector(
+				`.plugin-card-${ pluginSlug } .plugin-action-buttons`
+			);
+
+			if ( pluginSettingsURL && actionButtonList ) {
+				const listItem = document.createElement( 'li' );
+				const anchor = document.createElement( 'a' );
+
+				anchor.setAttribute( 'href', pluginSettingsURL );
+				anchor.textContent = __( 'Settings', 'performance-lab' );
+
+				listItem.appendChild( anchor );
+				actionButtonList.appendChild( listItem );
+			}
+		} catch ( error ) {
+			target.classList.remove( 'updating-message' );
+			target.textContent = __( 'Activate', 'performance-lab' );
 		}
-	);
+	}
 
-	// @ts-ignore
-} )( window.jQuery );
+	// Attach the event listener.
+	document.addEventListener( 'click', handlePluginActivationClick );
+} )();

From fdf7e0bc31fe7b7f76f3bbf68c3b0b71260270c5 Mon Sep 17 00:00:00 2001
From: b1ink0 <aditya.dhade@rtcamp.com>
Date: Tue, 12 Nov 2024 16:43:01 +0530
Subject: [PATCH 09/14] Fix duplicate request on multiple click, Fix settings
 URL not showing for Speculative Loading plugin

---
 .../includes/admin/plugin-activate-ajax.js    |  7 ++++
 plugins/speculation-rules/load.php            | 40 +++++++++++--------
 2 files changed, 30 insertions(+), 17 deletions(-)

diff --git a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
index 5f5cc0078..9aa9e2b46 100644
--- a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
+++ b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
@@ -30,6 +30,8 @@
 
 		target.classList.add( 'updating-message' );
 		target.textContent = __( 'Activating…', 'performance-lab' );
+		target.style.pointerEvents = 'none';
+		target.parentElement.style.cursor = 'not-allowed';
 
 		a11y.speak( __( 'Activating…', 'performance-lab' ) );
 
@@ -60,6 +62,8 @@
 			if ( ! responseData.success ) {
 				target.classList.remove( 'updating-message' );
 				target.textContent = __( 'Activate', 'performance-lab' );
+				target.style.pointerEvents = '';
+				target.parentElement.style.cursor = '';
 
 				return;
 			}
@@ -70,6 +74,7 @@
 			newButton.className = 'button button-disabled';
 			newButton.disabled = true;
 			newButton.textContent = __( 'Active', 'performance-lab' );
+			target.parentElement.style.cursor = '';
 
 			target.parentNode.replaceChild( newButton, target );
 
@@ -92,6 +97,8 @@
 		} catch ( error ) {
 			target.classList.remove( 'updating-message' );
 			target.textContent = __( 'Activate', 'performance-lab' );
+			target.style.pointerEvents = '';
+			target.parentElement.style.cursor = '';
 		}
 	}
 
diff --git a/plugins/speculation-rules/load.php b/plugins/speculation-rules/load.php
index ad186c06b..1c8cddff4 100644
--- a/plugins/speculation-rules/load.php
+++ b/plugins/speculation-rules/load.php
@@ -29,7 +29,24 @@
 	 * @param Closure $load            Callback that loads the plugin.
 	 */
 	static function ( string $global_var_name, string $version, Closure $load ): void {
-		if ( ! isset( $GLOBALS[ $global_var_name ] ) ) {
+		$needs_bootstrap = ! isset( $GLOBALS[ $global_var_name ] );
+
+		// Register this copy of the plugin.
+		if (
+			// Register this copy if none has been registered yet.
+			! isset( $GLOBALS[ $global_var_name ]['version'] )
+			||
+			// Or register this copy if the version greater than what is currently registered.
+			version_compare( $version, $GLOBALS[ $global_var_name ]['version'], '>' )
+			||
+			// Otherwise, register this copy if it is actually the one installed in the directory for plugins.
+			rtrim( WP_PLUGIN_DIR, '/' ) === dirname( __DIR__ )
+		) {
+			$GLOBALS[ $global_var_name ]['version'] = $version;
+			$GLOBALS[ $global_var_name ]['load']    = $load;
+		}
+
+		if ( $needs_bootstrap ) {
 			$bootstrap = static function () use ( $global_var_name ): void {
 				if (
 					isset( $GLOBALS[ $global_var_name ]['load'], $GLOBALS[ $global_var_name ]['version'] )
@@ -45,22 +62,11 @@ static function ( string $global_var_name, string $version, Closure $load ): voi
 
 			// Wait until after the plugins have loaded and the theme has loaded. The after_setup_theme action is used
 			// because it is the first action that fires once the theme is loaded.
-			add_action( 'after_setup_theme', $bootstrap, PHP_INT_MIN );
-		}
-
-		// Register this copy of the plugin.
-		if (
-			// Register this copy if none has been registered yet.
-			! isset( $GLOBALS[ $global_var_name ]['version'] )
-			||
-			// Or register this copy if the version greater than what is currently registered.
-			version_compare( $version, $GLOBALS[ $global_var_name ]['version'], '>' )
-			||
-			// Otherwise, register this copy if it is actually the one installed in the directory for plugins.
-			rtrim( WP_PLUGIN_DIR, '/' ) === dirname( __DIR__ )
-		) {
-			$GLOBALS[ $global_var_name ]['version'] = $version;
-			$GLOBALS[ $global_var_name ]['load']    = $load;
+			if ( (bool) did_action( 'after_setup_theme' ) ) {
+				$bootstrap();
+			} else {
+				add_action( 'after_setup_theme', $bootstrap, PHP_INT_MIN );
+			}
 		}
 	}
 )(

From b3ecc98cd2dacdb670a34d36bf1e431e8f6fe955 Mon Sep 17 00:00:00 2001
From: b1ink0 <aditya.dhade@rtcamp.com>
Date: Wed, 13 Nov 2024 14:00:56 +0530
Subject: [PATCH 10/14] Remove wp-a11y enqueue, Revert changes to Speculative
 Loading plugin load, Don't replace anchor with button

---
 .../performance-lab/includes/admin/load.php   |  3 --
 .../includes/admin/plugin-activate-ajax.js    | 36 ++++++++---------
 plugins/speculation-rules/load.php            | 40 ++++++++-----------
 3 files changed, 33 insertions(+), 46 deletions(-)

diff --git a/plugins/performance-lab/includes/admin/load.php b/plugins/performance-lab/includes/admin/load.php
index d9ead6b09..2f7be457c 100644
--- a/plugins/performance-lab/includes/admin/load.php
+++ b/plugins/performance-lab/includes/admin/load.php
@@ -225,9 +225,6 @@ function perflab_enqueue_features_page_scripts(): void {
 	wp_enqueue_style( 'thickbox' );
 	wp_enqueue_script( 'plugin-install' );
 
-	// Enqueue the a11y script.
-	wp_enqueue_script( 'wp-a11y' );
-
 	// Enqueue plugin activate AJAX script and localize script data.
 	wp_enqueue_script(
 		'perflab-plugin-activate-ajax',
diff --git a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
index 9aa9e2b46..1bffbba05 100644
--- a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
+++ b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
@@ -28,14 +28,19 @@
 		// Prevent the default link behavior.
 		event.preventDefault();
 
+		if (
+			target.classList.contains( 'updating-message' ) ||
+			target.classList.contains( 'disabled' )
+		) {
+			return;
+		}
+
 		target.classList.add( 'updating-message' );
 		target.textContent = __( 'Activating…', 'performance-lab' );
-		target.style.pointerEvents = 'none';
-		target.parentElement.style.cursor = 'not-allowed';
 
 		a11y.speak( __( 'Activating…', 'performance-lab' ) );
 
-		const pluginSlug = target.getAttribute( 'data-plugin-slug' ).trim();
+		const pluginSlug = target.dataset.pluginSlug;
 
 		// Send an AJAX POST request to activate the plugin.
 		try {
@@ -60,23 +65,14 @@
 			const responseData = await response.json();
 
 			if ( ! responseData.success ) {
-				target.classList.remove( 'updating-message' );
-				target.textContent = __( 'Activate', 'performance-lab' );
-				target.style.pointerEvents = '';
-				target.parentElement.style.cursor = '';
-
-				return;
+				throw Error();
 			}
 
-			const newButton = document.createElement( 'button' );
+			a11y.speak( __( 'Plugin activated.', 'performance-lab' ) );
 
-			newButton.type = 'button';
-			newButton.className = 'button button-disabled';
-			newButton.disabled = true;
-			newButton.textContent = __( 'Active', 'performance-lab' );
-			target.parentElement.style.cursor = '';
-
-			target.parentNode.replaceChild( newButton, target );
+			target.textContent = __( 'Active', 'performance-lab' );
+			target.classList.remove( 'updating-message' );
+			target.classList.add( 'disabled' );
 
 			const pluginSettingsURL = responseData?.data?.pluginSettingsURL;
 
@@ -88,17 +84,17 @@
 				const listItem = document.createElement( 'li' );
 				const anchor = document.createElement( 'a' );
 
-				anchor.setAttribute( 'href', pluginSettingsURL );
+				anchor.href = pluginSettingsURL;
 				anchor.textContent = __( 'Settings', 'performance-lab' );
 
 				listItem.appendChild( anchor );
 				actionButtonList.appendChild( listItem );
 			}
 		} catch ( error ) {
+			a11y.speak( __( 'Plugin failed to activate.', 'performance-lab' ) );
+
 			target.classList.remove( 'updating-message' );
 			target.textContent = __( 'Activate', 'performance-lab' );
-			target.style.pointerEvents = '';
-			target.parentElement.style.cursor = '';
 		}
 	}
 
diff --git a/plugins/speculation-rules/load.php b/plugins/speculation-rules/load.php
index 1c8cddff4..ad186c06b 100644
--- a/plugins/speculation-rules/load.php
+++ b/plugins/speculation-rules/load.php
@@ -29,24 +29,7 @@
 	 * @param Closure $load            Callback that loads the plugin.
 	 */
 	static function ( string $global_var_name, string $version, Closure $load ): void {
-		$needs_bootstrap = ! isset( $GLOBALS[ $global_var_name ] );
-
-		// Register this copy of the plugin.
-		if (
-			// Register this copy if none has been registered yet.
-			! isset( $GLOBALS[ $global_var_name ]['version'] )
-			||
-			// Or register this copy if the version greater than what is currently registered.
-			version_compare( $version, $GLOBALS[ $global_var_name ]['version'], '>' )
-			||
-			// Otherwise, register this copy if it is actually the one installed in the directory for plugins.
-			rtrim( WP_PLUGIN_DIR, '/' ) === dirname( __DIR__ )
-		) {
-			$GLOBALS[ $global_var_name ]['version'] = $version;
-			$GLOBALS[ $global_var_name ]['load']    = $load;
-		}
-
-		if ( $needs_bootstrap ) {
+		if ( ! isset( $GLOBALS[ $global_var_name ] ) ) {
 			$bootstrap = static function () use ( $global_var_name ): void {
 				if (
 					isset( $GLOBALS[ $global_var_name ]['load'], $GLOBALS[ $global_var_name ]['version'] )
@@ -62,11 +45,22 @@ static function ( string $global_var_name, string $version, Closure $load ): voi
 
 			// Wait until after the plugins have loaded and the theme has loaded. The after_setup_theme action is used
 			// because it is the first action that fires once the theme is loaded.
-			if ( (bool) did_action( 'after_setup_theme' ) ) {
-				$bootstrap();
-			} else {
-				add_action( 'after_setup_theme', $bootstrap, PHP_INT_MIN );
-			}
+			add_action( 'after_setup_theme', $bootstrap, PHP_INT_MIN );
+		}
+
+		// Register this copy of the plugin.
+		if (
+			// Register this copy if none has been registered yet.
+			! isset( $GLOBALS[ $global_var_name ]['version'] )
+			||
+			// Or register this copy if the version greater than what is currently registered.
+			version_compare( $version, $GLOBALS[ $global_var_name ]['version'], '>' )
+			||
+			// Otherwise, register this copy if it is actually the one installed in the directory for plugins.
+			rtrim( WP_PLUGIN_DIR, '/' ) === dirname( __DIR__ )
+		) {
+			$GLOBALS[ $global_var_name ]['version'] = $version;
+			$GLOBALS[ $global_var_name ]['load']    = $load;
 		}
 	}
 )(

From c713e4704ab6156beb11575330ee32073331be02 Mon Sep 17 00:00:00 2001
From: b1ink0 <aditya.dhade@rtcamp.com>
Date: Wed, 13 Nov 2024 18:31:01 +0530
Subject: [PATCH 11/14] Add REST API endpoints for activating plugin and
 getting plugin settings URL, Refactor JavaScript code to use apiFetch

---
 .../performance-lab/includes/admin/load.php   |  52 +----
 .../includes/admin/plugin-activate-ajax.js    |  46 ++--
 .../includes/admin/rest-api.php               | 201 ++++++++++++++++++
 plugins/performance-lab/load.php              |   3 +
 4 files changed, 221 insertions(+), 81 deletions(-)
 create mode 100644 plugins/performance-lab/includes/admin/rest-api.php

diff --git a/plugins/performance-lab/includes/admin/load.php b/plugins/performance-lab/includes/admin/load.php
index 2f7be457c..6294173ff 100644
--- a/plugins/performance-lab/includes/admin/load.php
+++ b/plugins/performance-lab/includes/admin/load.php
@@ -229,19 +229,10 @@ function perflab_enqueue_features_page_scripts(): void {
 	wp_enqueue_script(
 		'perflab-plugin-activate-ajax',
 		plugins_url( 'includes/admin/plugin-activate-ajax.js', PERFLAB_MAIN_FILE ),
-		array( 'wp-i18n', 'wp-a11y' ),
+		array( 'wp-i18n', 'wp-a11y', 'wp-api-fetch' ),
 		PERFLAB_VERSION,
 		true
 	);
-
-	wp_localize_script(
-		'perflab-plugin-activate-ajax',
-		'perflabPluginActivateAjaxData',
-		array(
-			'ajaxUrl' => admin_url( 'admin-ajax.php' ),
-			'nonce'   => wp_create_nonce( 'perflab_install_activate_plugin_ajax' ),
-		)
-	);
 }
 
 /**
@@ -302,47 +293,6 @@ function perflab_install_activate_plugin_callback(): void {
 }
 add_action( 'admin_action_perflab_install_activate_plugin', 'perflab_install_activate_plugin_callback' );
 
-/**
- * Callback for handling installation/activation of plugin using ajax.
- *
- * @since n.e.x.t
- */
-function perflab_install_activate_plugin_ajax_callback(): void {
-	check_ajax_referer( 'perflab_install_activate_plugin_ajax', '_ajax_nonce' );
-
-	require_once ABSPATH . 'wp-admin/includes/plugin.php';
-	require_once ABSPATH . 'wp-admin/includes/plugin-install.php';
-	require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
-	require_once ABSPATH . 'wp-admin/includes/class-wp-ajax-upgrader-skin.php';
-
-	if ( ! isset( $_POST['slug'] ) ) {
-		wp_send_json_error( __( 'Missing required parameter.', 'performance-lab' ), 400 );
-	}
-
-	$plugin_slug = perflab_sanitize_plugin_slug( wp_unslash( $_POST['slug'] ) );
-	if ( null === $plugin_slug ) {
-		wp_send_json_error( __( 'Invalid plugin.', 'performance-lab' ), 400 );
-	}
-
-	// Install and activate the plugin and its dependencies.
-	$result = perflab_install_and_activate_plugin( $plugin_slug );
-	if ( $result instanceof WP_Error ) {
-		wp_send_json_error( $result->get_error_message() );
-	}
-
-	$plugin_settings_url = perflab_get_plugin_settings_url( $plugin_slug );
-	if ( null !== $plugin_settings_url ) {
-		wp_send_json_success(
-			array(
-				'pluginSettingsURL' => esc_url_raw( $plugin_settings_url ),
-			)
-		);
-	}
-
-	wp_send_json_success();
-}
-add_action( 'wp_ajax_perflab_install_activate_plugin', 'perflab_install_activate_plugin_ajax_callback' );
-
 /**
  * Callback function to handle admin inline style.
  *
diff --git a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
index 1bffbba05..7cb9a6a11 100644
--- a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
+++ b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
@@ -2,10 +2,9 @@
  * Handles activation of Performance Features (Plugins) using AJAX.
  */
 
-/* global perflabPluginActivateAjaxData */
 ( function () {
 	// @ts-ignore
-	const { i18n, a11y } = wp;
+	const { i18n, a11y, apiFetch } = wp;
 	const { __ } = i18n;
 
 	/**
@@ -42,31 +41,20 @@
 
 		const pluginSlug = target.dataset.pluginSlug;
 
-		// Send an AJAX POST request to activate the plugin.
 		try {
-			const response = await fetch(
-				// @ts-ignore
-				perflabPluginActivateAjaxData.ajaxUrl,
-				{
-					method: 'POST',
-					credentials: 'same-origin',
-					headers: {
-						'Content-Type': 'application/x-www-form-urlencoded',
-					},
-					body: new URLSearchParams( {
-						action: 'perflab_install_activate_plugin',
-						slug: pluginSlug,
-						// @ts-ignore
-						_ajax_nonce: perflabPluginActivateAjaxData.nonce,
-					} ),
-				}
-			);
-
-			const responseData = await response.json();
-
-			if ( ! responseData.success ) {
-				throw Error();
-			}
+			// Activate the plugin via the REST API.
+			await apiFetch( {
+				path: '/performance-lab/v1/activate-plugin',
+				method: 'POST',
+				data: { slug: pluginSlug },
+			} );
+
+			// Fetch the plugin settings URL via the REST API.
+			const settingsResponse = await apiFetch( {
+				path: '/performance-lab/v1/plugin-settings-url',
+				method: 'POST',
+				data: { slug: pluginSlug },
+			} );
 
 			a11y.speak( __( 'Plugin activated.', 'performance-lab' ) );
 
@@ -74,17 +62,15 @@
 			target.classList.remove( 'updating-message' );
 			target.classList.add( 'disabled' );
 
-			const pluginSettingsURL = responseData?.data?.pluginSettingsURL;
-
 			const actionButtonList = document.querySelector(
 				`.plugin-card-${ pluginSlug } .plugin-action-buttons`
 			);
 
-			if ( pluginSettingsURL && actionButtonList ) {
+			if ( settingsResponse?.pluginSettingsURL && actionButtonList ) {
 				const listItem = document.createElement( 'li' );
 				const anchor = document.createElement( 'a' );
 
-				anchor.href = pluginSettingsURL;
+				anchor.href = settingsResponse?.pluginSettingsURL;
 				anchor.textContent = __( 'Settings', 'performance-lab' );
 
 				listItem.appendChild( anchor );
diff --git a/plugins/performance-lab/includes/admin/rest-api.php b/plugins/performance-lab/includes/admin/rest-api.php
new file mode 100644
index 000000000..8303f8899
--- /dev/null
+++ b/plugins/performance-lab/includes/admin/rest-api.php
@@ -0,0 +1,201 @@
+<?php
+/**
+ * REST API integration for the plugin.
+ *
+ * @package performance-lab
+ * @since n.e.x.t
+ */
+
+if ( ! defined( 'ABSPATH' ) ) {
+	exit; // Exit if accessed directly.
+}
+
+/**
+ * Namespace for performance-lab REST API.
+ *
+ * @var string
+ */
+const PERFLAB_REST_API_NAMESPACE = 'performance-lab/v1';
+
+/**
+ * Route for activating plugin.
+ *
+ * @var string
+ */
+const PERFLAB_ACTIVATE_PLUGIN_ROUTE = '/activate-plugin';
+
+/**
+ * Route for fetching plugin settings URL.
+ *
+ * @var string
+ */
+const PERFLAB_PLUGIN_SETTINGS_URL_ROUTE = '/plugin-settings-url';
+
+/**
+ * Registers endpoint for performance-lab REST API.
+ *
+ * @since n.e.x.t
+ * @access private
+ */
+function perflab_register_endpoint(): void {
+	register_rest_route(
+		PERFLAB_REST_API_NAMESPACE,
+		PERFLAB_ACTIVATE_PLUGIN_ROUTE,
+		array(
+			'methods'             => 'POST',
+			'args'                => array(
+				'slug' => array(
+					'type'        => 'string',
+					'description' => __( 'Plugin slug of plugin that needs to be activated.', 'performance-lab' ),
+					'required'    => true,
+				),
+			),
+			'callback'            => 'perflab_handle_activate_plugin',
+			'permission_callback' => static function () {
+				if ( current_user_can( 'install_plugins' ) ) {
+					return true;
+				}
+
+				return new WP_Error( 'cannot_install_plugin', __( 'Sorry, you are not allowed to install plugins on this site.', 'performance-lab' ) );
+			},
+		)
+	);
+
+	register_rest_route(
+		PERFLAB_REST_API_NAMESPACE,
+		PERFLAB_PLUGIN_SETTINGS_URL_ROUTE,
+		array(
+			'methods'             => 'POST',
+			'args'                => array(
+				'slug' => array(
+					'type'        => 'string',
+					'description' => __( 'Plugin slug of plugin whose settings URL is needed.', 'performance-lab' ),
+					'required'    => true,
+				),
+			),
+			'callback'            => 'perflab_handle_get_plugin_settings_url',
+			'permission_callback' => static function () {
+				if ( current_user_can( 'manage_options' ) ) {
+					return true;
+				}
+
+				return new WP_Error( 'cannot_access_plugin_settings_url', __( 'Sorry, you are not allowed to access plugin settings URL on this site.', 'performance-lab' ) );
+			},
+		)
+	);
+}
+add_action( 'rest_api_init', 'perflab_register_endpoint' );
+
+/**
+ * Handles REST API request to activate plugin.
+ *
+ * @since n.e.x.t
+ * @access private
+ *
+ * @phpstan-param WP_REST_Request<array<string, mixed>> $request
+ *
+ * @param WP_REST_Request $request Request.
+ * @return WP_REST_Response|WP_Error Response.
+ */
+function perflab_handle_activate_plugin( WP_REST_Request $request ) {
+	require_once ABSPATH . 'wp-admin/includes/plugin.php';
+	require_once ABSPATH . 'wp-admin/includes/plugin-install.php';
+	require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
+	require_once ABSPATH . 'wp-admin/includes/class-wp-ajax-upgrader-skin.php';
+
+	// Require to make helper functions available.
+	require_once PERFLAB_PLUGIN_DIR_PATH . 'includes/admin/load.php';
+	require_once PERFLAB_PLUGIN_DIR_PATH . 'includes/admin/plugins.php';
+
+	$params = $request->get_json_params();
+
+	// Ensure the 'slug' parameter is present.
+	if ( ! isset( $params['slug'] ) ) {
+		return new WP_Error(
+			'missing_parameter',
+			__( 'Missing required parameter "slug".', 'performance-lab' ),
+			array( 'status' => 400 )
+		);
+	}
+
+	$plugin_slug = perflab_sanitize_plugin_slug( wp_unslash( $params['slug'] ) );
+	if ( null === $plugin_slug ) {
+		return new WP_Error(
+			'invalid_plugin',
+			__( 'Invalid plugin slug provided.', 'performance-lab' ),
+			array( 'status' => 400 )
+		);
+	}
+
+	// Install and activate the plugin and its dependencies.
+	$result = perflab_install_and_activate_plugin( $plugin_slug );
+	if ( is_wp_error( $result ) ) {
+		return new WP_Error(
+			'plugin_activation_failed',
+			$result->get_error_message(),
+			array( 'status' => 500 )
+		);
+	}
+
+	return new WP_REST_Response(
+		array(
+			'success' => true,
+		)
+	);
+}
+
+/**
+ * Handles REST API request to get plugin settings URL.
+ *
+ * @since n.e.x.t
+ * @access private
+ *
+ * @phpstan-param WP_REST_Request<array<string, mixed>> $request
+ *
+ * @param WP_REST_Request $request Request.
+ * @return WP_REST_Response|WP_Error Response.
+ */
+function perflab_handle_get_plugin_settings_url( WP_REST_Request $request ) {
+	require_once ABSPATH . 'wp-admin/includes/plugin.php';
+
+	// Require to make helper functions available.
+	require_once PERFLAB_PLUGIN_DIR_PATH . 'includes/admin/load.php';
+	require_once PERFLAB_PLUGIN_DIR_PATH . 'includes/admin/plugins.php';
+
+	$params = $request->get_json_params();
+
+	// Ensure the 'slug' parameter is present.
+	if ( ! isset( $params['slug'] ) ) {
+		return new WP_Error(
+			'missing_parameter',
+			__( 'Missing required parameter "slug".', 'performance-lab' ),
+			array( 'status' => 400 )
+		);
+	}
+
+	$plugin_slug = perflab_sanitize_plugin_slug( wp_unslash( $params['slug'] ) );
+	if ( null === $plugin_slug ) {
+		return new WP_Error(
+			'invalid_plugin',
+			__( 'Invalid plugin slug provided.', 'performance-lab' ),
+			array( 'status' => 400 )
+		);
+	}
+
+	$plugin_settings_url = perflab_get_plugin_settings_url( $plugin_slug );
+	if ( null === $plugin_settings_url ) {
+		return new WP_REST_Response(
+			array(
+				'success'           => true,
+				'pluginSettingsURL' => false,
+			)
+		);
+	}
+
+	return new WP_REST_Response(
+		array(
+			'success'           => true,
+			'pluginSettingsURL' => esc_url_raw( $plugin_settings_url ),
+		)
+	);
+}
diff --git a/plugins/performance-lab/load.php b/plugins/performance-lab/load.php
index 304089d13..02ee034ca 100644
--- a/plugins/performance-lab/load.php
+++ b/plugins/performance-lab/load.php
@@ -339,3 +339,6 @@ function perflab_cleanup_option(): void {
 	require_once PERFLAB_PLUGIN_DIR_PATH . 'includes/admin/server-timing.php';
 	require_once PERFLAB_PLUGIN_DIR_PATH . 'includes/admin/plugins.php';
 }
+
+// Load REST API.
+require_once PERFLAB_PLUGIN_DIR_PATH . 'includes/admin/rest-api.php';

From c134fe2a2cecccdbe6f5e63a4585f63e4d7b87e7 Mon Sep 17 00:00:00 2001
From: b1ink0 <aditya.dhade@rtcamp.com>
Date: Thu, 14 Nov 2024 14:32:05 +0530
Subject: [PATCH 12/14] Update REST API routes, Add validation to args of REST
 API request, Refactor to separate plugin activate and settings URL request in
 there own try catch

---
 .../includes/admin/plugin-activate-ajax.js    |  58 +++++----
 .../includes/admin/rest-api.php               | 114 +++++++-----------
 2 files changed, 69 insertions(+), 103 deletions(-)

diff --git a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
index 7cb9a6a11..eb2c14399 100644
--- a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
+++ b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
@@ -15,15 +15,11 @@
 	 *
 	 * @param {MouseEvent} event - The click event object that is triggered when the user clicks on the document.
 	 *
-	 * @return {Promise<void>} - The asynchronous function returns a promise that resolves to void.
+	 * @return {Promise<void>} The asynchronous function returns a promise that resolves to void.
 	 */
 	async function handlePluginActivationClick( event ) {
 		const target = /** @type {HTMLElement} */ ( event.target );
 
-		if ( ! target.classList.contains( 'perflab-install-active-plugin' ) ) {
-			return;
-		}
-
 		// Prevent the default link behavior.
 		event.preventDefault();
 
@@ -44,16 +40,8 @@
 		try {
 			// Activate the plugin via the REST API.
 			await apiFetch( {
-				path: '/performance-lab/v1/activate-plugin',
+				path: `/performance-lab/v1/plugins/${ pluginSlug }:activate`,
 				method: 'POST',
-				data: { slug: pluginSlug },
-			} );
-
-			// Fetch the plugin settings URL via the REST API.
-			const settingsResponse = await apiFetch( {
-				path: '/performance-lab/v1/plugin-settings-url',
-				method: 'POST',
-				data: { slug: pluginSlug },
 			} );
 
 			a11y.speak( __( 'Plugin activated.', 'performance-lab' ) );
@@ -61,29 +49,39 @@
 			target.textContent = __( 'Active', 'performance-lab' );
 			target.classList.remove( 'updating-message' );
 			target.classList.add( 'disabled' );
+		} catch ( error ) {
+			a11y.speak( __( 'Plugin failed to activate.', 'performance-lab' ) );
+
+			target.classList.remove( 'updating-message' );
+			target.textContent = __( 'Activate', 'performance-lab' );
+		}
+
+		try {
+			// Fetch the plugin settings URL via the REST API.
+			const settingsResponse = await apiFetch( {
+				path: `/performance-lab/v1/plugin-settings-url/${ pluginSlug }`,
+				method: 'GET',
+			} );
 
 			const actionButtonList = document.querySelector(
 				`.plugin-card-${ pluginSlug } .plugin-action-buttons`
 			);
 
-			if ( settingsResponse?.pluginSettingsURL && actionButtonList ) {
-				const listItem = document.createElement( 'li' );
-				const anchor = document.createElement( 'a' );
+			const listItem = document.createElement( 'li' );
+			const anchor = document.createElement( 'a' );
 
-				anchor.href = settingsResponse?.pluginSettingsURL;
-				anchor.textContent = __( 'Settings', 'performance-lab' );
+			anchor.href = settingsResponse.pluginSettingsURL;
+			anchor.textContent = __( 'Settings', 'performance-lab' );
 
-				listItem.appendChild( anchor );
-				actionButtonList.appendChild( listItem );
-			}
-		} catch ( error ) {
-			a11y.speak( __( 'Plugin failed to activate.', 'performance-lab' ) );
-
-			target.classList.remove( 'updating-message' );
-			target.textContent = __( 'Activate', 'performance-lab' );
-		}
+			listItem.appendChild( anchor );
+			actionButtonList.appendChild( listItem );
+		} catch ( error ) {}
 	}
 
-	// Attach the event listener.
-	document.addEventListener( 'click', handlePluginActivationClick );
+	// Attach the event listeners.
+	document
+		.querySelectorAll( '.perflab-install-active-plugin' )
+		.forEach( ( item ) => {
+			item.addEventListener( 'click', handlePluginActivationClick );
+		} );
 } )();
diff --git a/plugins/performance-lab/includes/admin/rest-api.php b/plugins/performance-lab/includes/admin/rest-api.php
index 8303f8899..474186eac 100644
--- a/plugins/performance-lab/includes/admin/rest-api.php
+++ b/plugins/performance-lab/includes/admin/rest-api.php
@@ -20,16 +20,20 @@
 /**
  * Route for activating plugin.
  *
+ * Note the `:activate` art of the endpoint follows Google's guidance in AIP-136 for the use of the POST method in a way
+ * that does not strictly follow the standard usage.
+ *
+ * @link https://google.aip.dev/136
  * @var string
  */
-const PERFLAB_ACTIVATE_PLUGIN_ROUTE = '/activate-plugin';
+const PERFLAB_ACTIVATE_PLUGIN_ROUTE = '/plugins/(?P<slug>[a-z0-9_-]+):activate';
 
 /**
  * Route for fetching plugin settings URL.
  *
  * @var string
  */
-const PERFLAB_PLUGIN_SETTINGS_URL_ROUTE = '/plugin-settings-url';
+const PERFLAB_PLUGIN_SETTINGS_URL_ROUTE = '/plugin-settings-url/(?P<slug>[a-z0-9_-]+)';
 
 /**
  * Registers endpoint for performance-lab REST API.
@@ -45,9 +49,10 @@ function perflab_register_endpoint(): void {
 			'methods'             => 'POST',
 			'args'                => array(
 				'slug' => array(
-					'type'        => 'string',
-					'description' => __( 'Plugin slug of plugin that needs to be activated.', 'performance-lab' ),
-					'required'    => true,
+					'type'              => 'string',
+					'description'       => __( 'Plugin slug of plugin that needs to be activated.', 'performance-lab' ),
+					'required'          => true,
+					'validate_callback' => 'perflab_validate_slug_endpoint_arg',
 				),
 			),
 			'callback'            => 'perflab_handle_activate_plugin',
@@ -65,12 +70,13 @@ function perflab_register_endpoint(): void {
 		PERFLAB_REST_API_NAMESPACE,
 		PERFLAB_PLUGIN_SETTINGS_URL_ROUTE,
 		array(
-			'methods'             => 'POST',
+			'methods'             => 'GET',
 			'args'                => array(
 				'slug' => array(
-					'type'        => 'string',
-					'description' => __( 'Plugin slug of plugin whose settings URL is needed.', 'performance-lab' ),
-					'required'    => true,
+					'type'              => 'string',
+					'description'       => __( 'Plugin slug of plugin whose settings URL is needed.', 'performance-lab' ),
+					'required'          => true,
+					'validate_callback' => 'perflab_validate_slug_endpoint_arg',
 				),
 			),
 			'callback'            => 'perflab_handle_get_plugin_settings_url',
@@ -86,6 +92,25 @@ function perflab_register_endpoint(): void {
 }
 add_action( 'rest_api_init', 'perflab_register_endpoint' );
 
+/**
+ * Validates whether the provided plugin slug is a valid Performance Lab plugin.
+ *
+ * Note that an enum is not being used because additional PHP files have to be required to access the necessary functions,
+ * and this would not be ideal to do at rest_api_init.
+ *
+ * @since n.e.x.t
+ * @access private
+ *
+ * @param string $slug Plugin slug.
+ * @return bool Whether valid.
+ */
+function perflab_validate_slug_endpoint_arg( string $slug ): bool {
+	require_once ABSPATH . 'wp-admin/includes/plugin.php';
+	require_once PERFLAB_PLUGIN_DIR_PATH . 'includes/admin/load.php';
+	require_once PERFLAB_PLUGIN_DIR_PATH . 'includes/admin/plugins.php';
+	return in_array( $slug, perflab_get_standalone_plugins(), true );
+}
+
 /**
  * Handles REST API request to activate plugin.
  *
@@ -98,37 +123,12 @@ function perflab_register_endpoint(): void {
  * @return WP_REST_Response|WP_Error Response.
  */
 function perflab_handle_activate_plugin( WP_REST_Request $request ) {
-	require_once ABSPATH . 'wp-admin/includes/plugin.php';
 	require_once ABSPATH . 'wp-admin/includes/plugin-install.php';
 	require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
 	require_once ABSPATH . 'wp-admin/includes/class-wp-ajax-upgrader-skin.php';
 
-	// Require to make helper functions available.
-	require_once PERFLAB_PLUGIN_DIR_PATH . 'includes/admin/load.php';
-	require_once PERFLAB_PLUGIN_DIR_PATH . 'includes/admin/plugins.php';
-
-	$params = $request->get_json_params();
-
-	// Ensure the 'slug' parameter is present.
-	if ( ! isset( $params['slug'] ) ) {
-		return new WP_Error(
-			'missing_parameter',
-			__( 'Missing required parameter "slug".', 'performance-lab' ),
-			array( 'status' => 400 )
-		);
-	}
-
-	$plugin_slug = perflab_sanitize_plugin_slug( wp_unslash( $params['slug'] ) );
-	if ( null === $plugin_slug ) {
-		return new WP_Error(
-			'invalid_plugin',
-			__( 'Invalid plugin slug provided.', 'performance-lab' ),
-			array( 'status' => 400 )
-		);
-	}
-
 	// Install and activate the plugin and its dependencies.
-	$result = perflab_install_and_activate_plugin( $plugin_slug );
+	$result = perflab_install_and_activate_plugin( $request['slug'] );
 	if ( is_wp_error( $result ) ) {
 		return new WP_Error(
 			'plugin_activation_failed',
@@ -156,46 +156,14 @@ function perflab_handle_activate_plugin( WP_REST_Request $request ) {
  * @return WP_REST_Response|WP_Error Response.
  */
 function perflab_handle_get_plugin_settings_url( WP_REST_Request $request ) {
-	require_once ABSPATH . 'wp-admin/includes/plugin.php';
-
-	// Require to make helper functions available.
-	require_once PERFLAB_PLUGIN_DIR_PATH . 'includes/admin/load.php';
-	require_once PERFLAB_PLUGIN_DIR_PATH . 'includes/admin/plugins.php';
-
-	$params = $request->get_json_params();
-
-	// Ensure the 'slug' parameter is present.
-	if ( ! isset( $params['slug'] ) ) {
-		return new WP_Error(
-			'missing_parameter',
-			__( 'Missing required parameter "slug".', 'performance-lab' ),
-			array( 'status' => 400 )
-		);
-	}
-
-	$plugin_slug = perflab_sanitize_plugin_slug( wp_unslash( $params['slug'] ) );
-	if ( null === $plugin_slug ) {
-		return new WP_Error(
-			'invalid_plugin',
-			__( 'Invalid plugin slug provided.', 'performance-lab' ),
-			array( 'status' => 400 )
-		);
-	}
-
-	$plugin_settings_url = perflab_get_plugin_settings_url( $plugin_slug );
+	$plugin_settings_url = perflab_get_plugin_settings_url( $request['slug'] );
 	if ( null === $plugin_settings_url ) {
-		return new WP_REST_Response(
-			array(
-				'success'           => true,
-				'pluginSettingsURL' => false,
-			)
+		return new WP_Error(
+			'no_settings_url',
+			__( 'No settings URL', 'performance-lab' ),
+			array( 'status' => 404 )
 		);
 	}
 
-	return new WP_REST_Response(
-		array(
-			'success'           => true,
-			'pluginSettingsURL' => esc_url_raw( $plugin_settings_url ),
-		)
-	);
+	return new WP_REST_Response( $plugin_settings_url );
 }

From 369487fd7cf282523b69b312c1ee05be4e3629e0 Mon Sep 17 00:00:00 2001
From: b1ink0 <aditya.dhade@rtcamp.com>
Date: Fri, 15 Nov 2024 11:40:00 +0530
Subject: [PATCH 13/14] Update REST API routes, Update JavaScript code to use
 updated REST API routes

---
 .../includes/admin/plugin-activate-ajax.js    | 46 +++++++++----------
 .../includes/admin/rest-api.php               | 44 +++++++++---------
 2 files changed, 44 insertions(+), 46 deletions(-)

diff --git a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
index eb2c14399..907bbe2c7 100644
--- a/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
+++ b/plugins/performance-lab/includes/admin/plugin-activate-ajax.js
@@ -38,12 +38,33 @@
 		const pluginSlug = target.dataset.pluginSlug;
 
 		try {
-			// Activate the plugin via the REST API.
+			// Activate the plugin/feature via the REST API.
 			await apiFetch( {
-				path: `/performance-lab/v1/plugins/${ pluginSlug }:activate`,
+				path: `/performance-lab/v1/features/${ pluginSlug }:activate`,
 				method: 'POST',
 			} );
 
+			// Fetch the plugin/feature information via the REST API.
+			const featureInfo = await apiFetch( {
+				path: `/performance-lab/v1/features/${ pluginSlug }`,
+				method: 'GET',
+			} );
+
+			if ( featureInfo?.settingsUrl ) {
+				const actionButtonList = document.querySelector(
+					`.plugin-card-${ pluginSlug } .plugin-action-buttons`
+				);
+
+				const listItem = document.createElement( 'li' );
+				const anchor = document.createElement( 'a' );
+
+				anchor.href = featureInfo.settingsUrl;
+				anchor.textContent = __( 'Settings', 'performance-lab' );
+
+				listItem.appendChild( anchor );
+				actionButtonList.appendChild( listItem );
+			}
+
 			a11y.speak( __( 'Plugin activated.', 'performance-lab' ) );
 
 			target.textContent = __( 'Active', 'performance-lab' );
@@ -55,27 +76,6 @@
 			target.classList.remove( 'updating-message' );
 			target.textContent = __( 'Activate', 'performance-lab' );
 		}
-
-		try {
-			// Fetch the plugin settings URL via the REST API.
-			const settingsResponse = await apiFetch( {
-				path: `/performance-lab/v1/plugin-settings-url/${ pluginSlug }`,
-				method: 'GET',
-			} );
-
-			const actionButtonList = document.querySelector(
-				`.plugin-card-${ pluginSlug } .plugin-action-buttons`
-			);
-
-			const listItem = document.createElement( 'li' );
-			const anchor = document.createElement( 'a' );
-
-			anchor.href = settingsResponse.pluginSettingsURL;
-			anchor.textContent = __( 'Settings', 'performance-lab' );
-
-			listItem.appendChild( anchor );
-			actionButtonList.appendChild( listItem );
-		} catch ( error ) {}
 	}
 
 	// Attach the event listeners.
diff --git a/plugins/performance-lab/includes/admin/rest-api.php b/plugins/performance-lab/includes/admin/rest-api.php
index 474186eac..e805353a6 100644
--- a/plugins/performance-lab/includes/admin/rest-api.php
+++ b/plugins/performance-lab/includes/admin/rest-api.php
@@ -18,7 +18,7 @@
 const PERFLAB_REST_API_NAMESPACE = 'performance-lab/v1';
 
 /**
- * Route for activating plugin.
+ * Route for activating plugin/feature.
  *
  * Note the `:activate` art of the endpoint follows Google's guidance in AIP-136 for the use of the POST method in a way
  * that does not strictly follow the standard usage.
@@ -26,14 +26,14 @@
  * @link https://google.aip.dev/136
  * @var string
  */
-const PERFLAB_ACTIVATE_PLUGIN_ROUTE = '/plugins/(?P<slug>[a-z0-9_-]+):activate';
+const PERFLAB_FEATURES_ACTIVATE_ROUTE = '/features/(?P<slug>[a-z0-9_-]+):activate';
 
 /**
- * Route for fetching plugin settings URL.
+ * Route for fetching plugin/feature information.
  *
  * @var string
  */
-const PERFLAB_PLUGIN_SETTINGS_URL_ROUTE = '/plugin-settings-url/(?P<slug>[a-z0-9_-]+)';
+const PERFLAB_FEATURES_INFORMATION_ROUTE = '/features/(?P<slug>[a-z0-9_-]+)';
 
 /**
  * Registers endpoint for performance-lab REST API.
@@ -44,18 +44,18 @@
 function perflab_register_endpoint(): void {
 	register_rest_route(
 		PERFLAB_REST_API_NAMESPACE,
-		PERFLAB_ACTIVATE_PLUGIN_ROUTE,
+		PERFLAB_FEATURES_ACTIVATE_ROUTE,
 		array(
 			'methods'             => 'POST',
 			'args'                => array(
 				'slug' => array(
 					'type'              => 'string',
-					'description'       => __( 'Plugin slug of plugin that needs to be activated.', 'performance-lab' ),
+					'description'       => __( 'Plugin slug of plugin/feature that needs to be activated.', 'performance-lab' ),
 					'required'          => true,
 					'validate_callback' => 'perflab_validate_slug_endpoint_arg',
 				),
 			),
-			'callback'            => 'perflab_handle_activate_plugin',
+			'callback'            => 'perflab_handle_feature_activation',
 			'permission_callback' => static function () {
 				if ( current_user_can( 'install_plugins' ) ) {
 					return true;
@@ -68,18 +68,18 @@ function perflab_register_endpoint(): void {
 
 	register_rest_route(
 		PERFLAB_REST_API_NAMESPACE,
-		PERFLAB_PLUGIN_SETTINGS_URL_ROUTE,
+		PERFLAB_FEATURES_INFORMATION_ROUTE,
 		array(
 			'methods'             => 'GET',
 			'args'                => array(
 				'slug' => array(
 					'type'              => 'string',
-					'description'       => __( 'Plugin slug of plugin whose settings URL is needed.', 'performance-lab' ),
+					'description'       => __( 'Plugin slug of plugin/feature whose settings URL is needed.', 'performance-lab' ),
 					'required'          => true,
 					'validate_callback' => 'perflab_validate_slug_endpoint_arg',
 				),
 			),
-			'callback'            => 'perflab_handle_get_plugin_settings_url',
+			'callback'            => 'perflab_handle_get_feature_information',
 			'permission_callback' => static function () {
 				if ( current_user_can( 'manage_options' ) ) {
 					return true;
@@ -112,7 +112,7 @@ function perflab_validate_slug_endpoint_arg( string $slug ): bool {
 }
 
 /**
- * Handles REST API request to activate plugin.
+ * Handles REST API request to activate plugin/feature.
  *
  * @since n.e.x.t
  * @access private
@@ -122,7 +122,7 @@ function perflab_validate_slug_endpoint_arg( string $slug ): bool {
  * @param WP_REST_Request $request Request.
  * @return WP_REST_Response|WP_Error Response.
  */
-function perflab_handle_activate_plugin( WP_REST_Request $request ) {
+function perflab_handle_feature_activation( WP_REST_Request $request ) {
 	require_once ABSPATH . 'wp-admin/includes/plugin-install.php';
 	require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
 	require_once ABSPATH . 'wp-admin/includes/class-wp-ajax-upgrader-skin.php';
@@ -145,7 +145,7 @@ function perflab_handle_activate_plugin( WP_REST_Request $request ) {
 }
 
 /**
- * Handles REST API request to get plugin settings URL.
+ * Handles REST API request to get plugin/feature information.
  *
  * @since n.e.x.t
  * @access private
@@ -153,17 +153,15 @@ function perflab_handle_activate_plugin( WP_REST_Request $request ) {
  * @phpstan-param WP_REST_Request<array<string, mixed>> $request
  *
  * @param WP_REST_Request $request Request.
- * @return WP_REST_Response|WP_Error Response.
+ * @return WP_REST_Response Response.
  */
-function perflab_handle_get_plugin_settings_url( WP_REST_Request $request ) {
+function perflab_handle_get_feature_information( WP_REST_Request $request ): WP_REST_Response {
 	$plugin_settings_url = perflab_get_plugin_settings_url( $request['slug'] );
-	if ( null === $plugin_settings_url ) {
-		return new WP_Error(
-			'no_settings_url',
-			__( 'No settings URL', 'performance-lab' ),
-			array( 'status' => 404 )
-		);
-	}
 
-	return new WP_REST_Response( $plugin_settings_url );
+	return new WP_REST_Response(
+		array(
+			'slug'        => $request['slug'],
+			'settingsUrl' => $plugin_settings_url,
+		)
+	);
 }

From 9bee27edeee959300df16a464034b6a866eed7f2 Mon Sep 17 00:00:00 2001
From: b1ink0 <aditya.dhade@rtcamp.com>
Date: Fri, 15 Nov 2024 11:46:59 +0530
Subject: [PATCH 14/14] Fix inline comments and error messages

---
 plugins/performance-lab/includes/admin/rest-api.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/plugins/performance-lab/includes/admin/rest-api.php b/plugins/performance-lab/includes/admin/rest-api.php
index e805353a6..89fe3a1f7 100644
--- a/plugins/performance-lab/includes/admin/rest-api.php
+++ b/plugins/performance-lab/includes/admin/rest-api.php
@@ -74,7 +74,7 @@ function perflab_register_endpoint(): void {
 			'args'                => array(
 				'slug' => array(
 					'type'              => 'string',
-					'description'       => __( 'Plugin slug of plugin/feature whose settings URL is needed.', 'performance-lab' ),
+					'description'       => __( 'Plugin slug of plugin/feature whose information is needed.', 'performance-lab' ),
 					'required'          => true,
 					'validate_callback' => 'perflab_validate_slug_endpoint_arg',
 				),
@@ -85,7 +85,7 @@ function perflab_register_endpoint(): void {
 					return true;
 				}
 
-				return new WP_Error( 'cannot_access_plugin_settings_url', __( 'Sorry, you are not allowed to access plugin settings URL on this site.', 'performance-lab' ) );
+				return new WP_Error( 'cannot_access_plugin_settings_url', __( 'Sorry, you are not allowed to access plugin/feature information on this site.', 'performance-lab' ) );
 			},
 		)
 	);
@@ -127,7 +127,7 @@ function perflab_handle_feature_activation( WP_REST_Request $request ) {
 	require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
 	require_once ABSPATH . 'wp-admin/includes/class-wp-ajax-upgrader-skin.php';
 
-	// Install and activate the plugin and its dependencies.
+	// Install and activate the plugin/feature and its dependencies.
 	$result = perflab_install_and_activate_plugin( $request['slug'] );
 	if ( is_wp_error( $result ) ) {
 		return new WP_Error(