-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing additional arg seperator required to run Codecov coverage. #1653
base: trunk
Are you sure you want to change the base?
Add missing additional arg seperator required to run Codecov coverage. #1653
Conversation
The test is still failing, even after adding an additional arg seperator I'm not able to debug and stuck here, any help or insights would be instrumental. cc : @thelovekesh @westonruter |
I see this https://github.com/WordPress/performance/actions/runs/11825633049/job/32949852740?pr=1653#step:12:49 which seems to be the problem:
|
Yes, there's no coverage file to upload and hence the test is failing, however the WorkFlow before uploading is running (where xml file is generated ) and the hash is also same I verified. cc : @westonruter |
I believe @thelovekesh has in mind what is wrong there. |
Summary
This PR fixes the currently broken automated codecov coverage in github workflow.
Fixes #
Issue : #1284
Problem Reference - #1652 (comment)
Additional Technical Details Required
As mentioned here - #1586 (comment)
Currently the xml file name is being generated like
coverage-multisite-${{ github.sha }}.xml
, so if it's getting overwritten for each plugin, what different identifier can we use here so that it's unique for each plugin ?cc : @thelovekesh @westonruter