Add WP_ENV_MULTISITE envoriment variable. #68792
Open
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new `multisite` option in `wp-env` to enable multisite setups. This can be specified via the `WP_ENV_MULTISITE` environment variable or in the configuration file. Updated documentation to include usage instructions.
spacedmonkey
requested review from
ObliviousHarmony and
t-hamano
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
spacedmonkey
added
[Type] Enhancement
spacedmonkey
requested review from
mcsf,
cbravobernal,
youknowriad and
swissspidy
spacedmonkey
commented
Jan 20, 2025
swissspidy
reviewed
Jan 20, 2025
swissspidy
reviewed
Jan 20, 2025
|
This should probably be added to the changelog file too |
Co-authored-by: Pascal Birchler <[email protected]>
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
This enhancement allows overriding the `multisite` option using the `WP_ENV_MULTISITE` variable. It provides greater flexibility for customizing environment configurations.
@swissspidy Fixed. |
|
Flaky tests detected in 3e48949. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12888006442
|
Corrected the JSDoc type annotation for the multisite property from `bool` to `boolean` for consistency. Added a minor formatting adjustment to the multisite environment variable processing logic.
|
We discussed this in the original PR. For me it's not really clear why some config should support an environment variable while others shouldn't. (I know this is already the case). So my opinion is that, I'd prefer to be consistent. Can we avoid having to handle every config option manually and instead have a naming convention. I know some tools that do that. |
I agree for consisancy all or none should have envoriment variable. This PR comes out of necessity, I have a requirement to use wp-env in CI to run E2E tests. I need to run the tests against single and multisite. This envoriemnt varible fixes that. |
|
swissspidy
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #67845 support for
multisitewas added in option inwp-envsetups.Related: #68125
What?
This PR, it adds the functionality to can be specified via the
WP_ENV_MULTISITEenvironment variable or in the configuration file.Why?
It makes it easier to define it the site is multisite in a CI context.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast