Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-dupe messages properly #98

Open
HarryET opened this issue Feb 6, 2023 · 1 comment
Open

De-dupe messages properly #98

HarryET opened this issue Feb 6, 2023 · 1 comment
Labels

Comments

@HarryET
Copy link
Contributor

HarryET commented Feb 6, 2023

We shouldn't reject if we already stored a notification, we should check if the notification exists and if it does see if this notification has been processed before, if so: return 200 early else continue with normal processing and store the notification after we have processed to prevent duplicates.

@HarryET HarryET added C-bug help wanted Extra attention is needed labels Feb 6, 2023
@xav xav added area-stores Stores and removed A-stores help wanted Extra attention is needed labels Jun 8, 2023
@xav xav changed the title bug: De-dupe messages properly De-dupe messages properly Jun 8, 2023
@chris13524
Copy link
Member

chris13524 commented Sep 30, 2023

Some work will be required to identity and differentiate between a temporary provider error (e.g. failed network request), and permanent ones, so that permeant ones aren't unnecessarily retried. Some initial work here: https://walletconnect.slack.com/archives/C03SPNLG39P/p1696087208180819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants