Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inplace_function] benchmark #139

Open
user706 opened this issue Nov 16, 2018 · 4 comments
Open

[inplace_function] benchmark #139

user706 opened this issue Nov 16, 2018 · 4 comments

Comments

@user706
Copy link

user706 commented Nov 16, 2018

Just to let you know:
https://github.com/user706/CxxFunctionBenchmark/tree/feature/sg14_inplace_function

(awaiting pull request... to main benchmark project here)

@user706
Copy link
Author

user706 commented Nov 18, 2018

Usage:

#!/usr/bin/env bash

git clone https://github.com/user706/CxxFunctionBenchmark.git
cd CxxFunctionBenchmark

mkdir build
cd    build

git checkout feature/sg14_inplace_function
cmake -D GNR=ON   \
      -D FOLLY=ON \
      -D BDE=ON    `# will clone into git submodule CxxFunctionBenchmark/bde/bde` \
      -D BOOST_ROOT=/my/path/to/boost/install/dir `# only needed if boost is in non-standard place`\
      ..
cmake --build .

./various   # run program

@Quuxplusone
Copy link
Contributor

Quuxplusone commented Nov 18, 2018

FYI @user706, you should rebase on https://github.com/jamboree/CxxFunctionBenchmark master, which has recently fixed an utter mess on non-case-sensitive filesystems (e.g. OS X and Windows).

EDIT: You should rebase your master branch. Or else change the git clone command-line above to clone directly into your feature branch.

@user706
Copy link
Author

user706 commented Nov 18, 2018

branch feature/sg14_inplace_function (https://github.com/user706/CxxFunctionBenchmark/tree/feature/sg14_inplace_function) is on top of the latest commit of jamboree's master (i.e. if there were any fixes by jamboree [as you imply above], they are in the branch feature/sg14_inplace_function as well)

@user706
Copy link
Author

user706 commented Nov 19, 2018

jamboree merged it into his repo.

Thus usage:

#!/usr/bin/env bash

git clone https://github.com/jamboree/CxxFunctionBenchmark.git
cd CxxFunctionBenchmark

mkdir build
cd    build

cmake -D GNR=ON   \
      -D FOLLY=ON \
      -D BDE=ON    `# will clone into git submodule CxxFunctionBenchmark/bde/bde` \
      -D BOOST_ROOT=/my/path/to/boost/install/dir `# only needed if boost is in non-standard place`\
      ..
cmake --build .

./various   # run program

What results do you get on your platforms? Is speed a goal? If yes: what kind of goal-> as fast as possible (unsurpassable) vs fast enough (what is fast enough?). Where should the main speed-focus be: construction, function-call or destruction? etc.

How does it correlate with your expectations? etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants