Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize naming of the parameters #141

Open
Perevalov opened this issue Feb 7, 2023 · 1 comment
Open

Generalize naming of the parameters #141

Perevalov opened this issue Feb 7, 2023 · 1 comment

Comments

@Perevalov
Copy link
Collaborator

When running the pipeline e.g., via Docker Compose, one needs to specify the parameters:

  qanary_pipeline:
    image: qanary/qanary-pipeline:3.3.4
    ports:
             - 8888:8888
    restart: unless-stopped
    environment:
            - SERVER_PORT=8888
            - STARDOG_URL=http://stardog-host:6868/
            - STARDOG_USERNAME=admin
            - STARDOG_PASSWORD=admin
            - QANARY_PROCESS_ALLOW-ADDITIONAL-TRIPLES=false
            - SERVER_HOST=http://server-host
            - QANARY_QUESTIONS_DIRECTORY=/qanary-questions

The parameters: STARDOG_URL, STARDOG_USERNAME, STARDOG_PASSWORD include the name STARDOG, but as I understand, the pipeline can work with any other triplestore.

Suggestion: replace STARDOG_ with TRIPLESTORE_

@anbo-de
Copy link
Member

anbo-de commented Feb 8, 2023

@Perevalov Actually the parameters are specific to the triplestore connectors within the Qanary system. In general, you are correct that the endpoint name might be reused. However, given a very clear context via the parameter prefixes might help the developers to know exactly what they are configuring and how the parameters are intended to work together. Additionally, most of the parameters might be quite different regarding the used system. For example, currently a triplestore connector is provided for Stardog and Openlink Virtuoso (and an experimental TBD-based In-Memory Triplestore). While some of the parameters have equal semantics, other ones are only used in one specific triplestore (e.g., stardog.reasoningType).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants