Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse similar codepaths, and create a mapping for single-scale simulations #101

Open
Samuel-amap opened this issue Oct 11, 2024 · 3 comments

Comments

@Samuel-amap
Copy link
Collaborator

Similarly to issue #67 , there are other places in the codebase that could benefit from being streamlined into a single codepath.

A few functions call similar-but-not-quite-the-same codepaths, which introduces extra complexity in understanding program state. Perhaps some functions could benefit from being renamed, or not overloaded, too.

ModelLists and mappings also have many similar stages, but sometimes call different functions due to the multi scale handling. It seems like it might be worthwhile to consider ModelLists as multi-scale models with only a single implicit scale (without making the API more complex on the user side). There is at least one difference worth keeping, which is that with a single scale the size of the output data can be known exactly and preallocated in advance.

@Samuel-amap
Copy link
Collaborator Author

Issues such as issue #85 might also arise less often in the future with code flow that only splits right when specialization is needed, instead of having two more distinct but still functionally similar codepaths

@VEZY
Copy link
Member

VEZY commented Oct 24, 2024

Related to #67

@Samuel-amap
Copy link
Collaborator Author

Returning to this issue :

Given that there are some distinct differences between single and multiscale use cases, and that there is a modellist to mapping comparison that should help ensure the two cases don't desynchronise, it might be worth calling this issue closed.

See #125 and #123, and PR #122.

That being said, #67 is still a valid concern. Some codepaths might still be collapsible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants