Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug found in dMCdROfRhodMusDetector #145

Closed
hayakawa16 opened this issue Apr 30, 2024 · 1 comment · Fixed by #146
Closed

Bug found in dMCdROfRhodMusDetector #145

hayakawa16 opened this issue Apr 30, 2024 · 1 comment · Fixed by #146
Assignees
@hayakawa16

Comments

@hayakawa16
Copy link
Member

In AbsorbDiscrete method, the derivative code is incorrect.

Correct code, create/update unit tests, and check other derivative detector, dMCdROfRhodMuaDetector for any errors.
@hayakawa16 hayakawa16 self-assigned this Apr 30, 2024
@hayakawa16
Copy link
Member Author

hayakawa16 commented Apr 30, 2024 •
edited
Loading

I have written up the perturbation Monte Carlo equations and their derivatives for reference.
notes.pdf
I updated for case when (j=1) because in code.

@hayakawa16 hayakawa16 linked a pull request May 2, 2024 that will close this issue
Bugfix/145 bug found in dmcdrofrhodmusdetector #146
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hayakawa16 hayakawa16

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/145 bug found in dmcdrofrhodmusdetector VirtualPhotonics/VTS
1 participant
@hayakawa16