Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bungee] 1.7 Duplicate Scoreboard Crash #5

Open
linsaftw opened this issue Apr 24, 2021 · 11 comments
Open

[Bungee] 1.7 Duplicate Scoreboard Crash #5

linsaftw opened this issue Apr 24, 2021 · 11 comments

Comments

@linsaftw
Copy link
Contributor

linsaftw commented Apr 24, 2021

Environment:
Proxy: FlameCord (Travertine)
Server: SportPaper 1.8
Affected Client: Vanilla 1.7.10
Running ViaRewind (1.5.3) & ViaVersion (3.2.1) on Bungee

Steps:

  1. Join a server that defines a scoreboard objective.
  2. Switch to a server that defines a scoreboard objective with the same name.
  3. Client crashes because of "Duplicate" scoreboard entry.

This doesn't happen when using ViaRewind on all Spigot servers. This only happens on Bungee version.

@linsaftw
Copy link
Contributor Author

linsaftw commented Apr 24, 2021

Logger - ViaRewind Objective Handler:

image

One of this crashes appear randomly when switching servers.

Crash 1:
java.lang.IllegalArgumentException: A team with the name 'line: §c1§8/§420' already exists!

Crash 2:
java.lang.IllegalArgumentException: An objective with the name '2LSScoreboard' already exists!

As you can see in the log, the objective is added twice without it getting removed.

@linsaftw linsaftw reopened this Apr 24, 2021
@creeper123123321 creeper123123321 added wontfix This will not be worked on and removed wontfix This will not be worked on labels Apr 24, 2021
@linsaftw
Copy link
Contributor Author

linsaftw commented Apr 24, 2021

Alright, the problem seems to be that the connection re-inits on server switch which causes Bungee to not detect the old objectives before the switch was done so it can't remove the old objective.

Before adding the "crashing" objective i am receiving a scoreboard packet (mode 1) which means the server is trying to remove the objective but ViaRewind doesn't detect it as an existing objective.

I think this can be fixed by passing the old UserConnection scoreboard values to the new one or removing all scoreboard values before switching to a new server.

@BF138
Copy link

BF138 commented Jul 27, 2021

Same issue here

@TidySnakeSL-alt
Copy link

TidySnakeSL-alt commented Jul 27, 2021

Please fix it! I have the same issue here :(

@Jojanyu15
Copy link

Same issue anyone knows?

@iLucasUS

This comment was marked as spam.

@linsaftw
Copy link
Contributor Author

linsaftw commented Mar 5, 2022

The issue is still happening. The plugin cannot be run in BungeeCord if the sub-servers have same Scoreboards.

@TidySnakeSL-alt
Copy link

Good luck!

@HowardZHY
Copy link

Try Protocol Support?

@linsaftw
Copy link
Contributor Author

linsaftw commented Mar 5, 2022

Try Protocol Support?

I just switched to ProtocolSupport on all Spigot servers and ViaVersion on BungeeCord. CPU Usage is lower for some reason.

@FlorianMichael FlorianMichael transferred this issue from ViaVersion/ViaRewind Jun 1, 2024
@FlorianMichael
Copy link
Member

Can this be reproduced on latest Via* components?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants