Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Margus Veanes regarding merging changes to upstream #3

Open
michkot opened this issue Dec 10, 2020 · 1 comment
Open

Contact Margus Veanes regarding merging changes to upstream #3

michkot opened this issue Dec 10, 2020 · 1 comment
Assignees
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@michkot
Copy link
Member

michkot commented Dec 10, 2020

  • Is he willing to do that / review it / let someone review it ?
  • Are they willing to merge-in their own cross-platform changes they learned in https://github.com/AutomataDotNet/srm/ ?
  • Are they willing to back-port any fixes and code clean-up made for the SRM project? (see commits in the repo https://github.com/AutomataDotNet/srm/commits/master )
  • Are they willing to merge our cross-platform changes ? (current version is not nearly enough!)
  • Are they wiling to merge our feature changes (e.g. new IAutomata interface) ?
@michkot michkot added help wanted Extra attention is needed question Further information is requested labels Dec 10, 2020
@michkot
Copy link
Member Author

michkot commented Dec 15, 2020

Adding details:

list of cross-platform and maintenance changes made by me:

  • manually converted (only) Automata project to .NET Standard
  • hack-around a timing function in Automaton.cs that calls to Windows-specific dlls via pinvoke so it works in linux (needs better fix and/or elimination of the native call; the reason for the native call is not obvious in the first place)
  • fixed DGML showing for newer VS versions (and make it work for all editions)
  • breaking API changes by correcting TYPOs in method names

list of feature changes:

  • add new non-generic IAutomaton interface that copies IAutomaton<>-method-wise; it is need when a label-type-agnostic handling of automata is desired and knowing the generic label-parameter would poison the code, or when deserialization takes place
  • adding useful methods to IAutomaton<> and IAutomaton interfaces, like getFinalStates() (and adding implementation to all AutomataDotNet internal dependencies)
  • modification of regex character-ranges serialization to make it more readable when using ToString() on BDDs (note that RegexToAutomatonConverter.cs would need quite a lot of cleanup...)
  • AutomatonToDot converter/printer enhancements
  • other...

code changes overview (except project changes)
VeriFIT:project-cleanup-done...VeriFIT:asma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants