Disable the option to automatically inline functions by compiler to improve modding with tools #3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mprove modding with tools
|
Yeah, VALVe's devs should not change their compiler settings regarding this, because that will cause all hooking addons not anymore capable to catch a lot of functions for their plugins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3845
Yes, on the one hand, when using maximum optimization, automatic inline functions might be slightly affect performance, but at the same time it gives a huge problem to modders who used to make changes to each individual function using third-party tools (HLAE, bxt-rs, Orpheu, amxmodx and etc). So automatic inlines should be always disabled (unless if they are not forced in the code itself by the developer in the form of
inline voide.g.).@shawns-valve - these changes should also be applied to the engine as well, not just to game libraries!
-fno-inline: https://gcc.gnu.org/onlinedocs/gcc-5.4.0/gcc/Optimize-Options.htmlOnlyExplicitInline(/Ob1): https://learn.microsoft.com/en-us/cpp/build/reference/ob-inline-function-expansion?view=msvc-170