Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertical gap between elements in HTMX destinations page #1081

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

stveit
Copy link
Contributor

@stveit stveit commented Dec 10, 2024

Fixes #1080

Relies on #1078. #1078 is in my own fork, so I cant base this PR on that, so most of the commits in the commit log of this PR belongs to #1078

@stveit stveit self-assigned this Dec 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.83%. Comparing base (73bac64) to head (3cecbe2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1081   +/-   ##
=======================================
  Coverage   79.83%   79.83%           
=======================================
  Files         145      145           
  Lines        5267     5267           
=======================================
  Hits         4205     4205           
  Misses       1062     1062           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@podliashanyk podliashanyk added the blocked Another thing/issue has to be resolved before tackling this label Dec 10, 2024
Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🙌
Let's also add a gap between the collapse elements themselves

@stveit stveit force-pushed the htmx-destinations-add-vertical-gap branch from e655dc8 to f061029 Compare January 9, 2025 13:20
Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@stveit stveit force-pushed the htmx-destinations-add-vertical-gap branch from f061029 to 6540994 Compare January 14, 2025 14:01
Gap between create form and the first collapse
element, and gap between the collapse
elements themselves
@stveit stveit force-pushed the htmx-destinations-add-vertical-gap branch from 6540994 to 3cecbe2 Compare January 14, 2025 14:11
@stveit stveit merged commit 84da7a2 into Uninett:master Jan 14, 2025
14 checks passed
@stveit stveit deleted the htmx-destinations-add-vertical-gap branch January 14, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Another thing/issue has to be resolved before tackling this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vertical gap between collapse element and create form on HTMX destinations page
4 participants