Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test failures due to httpservice credential handling changes #44

Closed
lesserwhirls opened this issue Sep 21, 2019 · 1 comment
Closed

Comments

@lesserwhirls
Copy link
Collaborator

With the changes made to httpservices in Unidata/netcdf-java/#117 (changes summarized in the PR and documented here), we have new failures in these TDS tests:

thredds.tds.FreshTdsInstallSpec
thredds.server.services.TestAdminDebug
ucar.nc2.util.net.TestSSH
ucar.nc2.util.net.TestTomcatAuth

The issue seems to revolve the way the following two classes work with credentials:

  1. tds/it/src/test/java/thredds/TestOnLocalServer.java
  2. TestProvider inner class of tds/it/src/test/java/ucar/nc2/util/net/TestSSH.java

None of these seem to indicate actual failures in the functionality of the TDS (for example, I can still access the admin/debug interface through a browser), but rather the way in which we utilize httpservices in some helper methods/classes related to setting up the client side of the tests.

@lesserwhirls
Copy link
Collaborator Author

These are no longer failures and were addressed, but not sure exactly when. Closing unless they show up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant