You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I suggest adding Letter.TextRenderingMode, Letter.StrokeColor and Letter.FillColor and adding them as constructor arguments. We populating it with currentState.FontState.TextRenderingMode, currentState.CurrentStrokingColor and currentState.CurrentNonStrokingColor inside ContentStreamProcessor. Likely other places as well.
You can use the TextRenderingMode to detect hidden text (see also #446) and process the fill and stroke colors using your own logic, instead of flattening it into Letter.Color.
I suggest keeping Letter.Color, which takes either fill or stroke color based on the TextRenderingMode, using the current logic inside ContentStreamProcessor:
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I suggest adding Letter.TextRenderingMode, Letter.StrokeColor and Letter.FillColor and adding them as constructor arguments. We populating it with currentState.FontState.TextRenderingMode, currentState.CurrentStrokingColor and currentState.CurrentNonStrokingColor inside ContentStreamProcessor. Likely other places as well.
You can use the TextRenderingMode to detect hidden text (see also #446) and process the fill and stroke colors using your own logic, instead of flattening it into Letter.Color.
I suggest keeping Letter.Color, which takes either fill or stroke color based on the TextRenderingMode, using the current logic inside ContentStreamProcessor:
If this is a good idea, I can create a PR.
Beta Was this translation helpful? Give feedback.
All reactions