Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more notes on how to do HTML render #50

Open
PythonCHB opened this issue Dec 31, 2020 · 0 comments
Open

Add some more notes on how to do HTML render #50

PythonCHB opened this issue Dec 31, 2020 · 0 comments

Comments

@PythonCHB
Copy link
Contributor

Now that the HTML render assignment is now the last exercise (generally a good move) -- there's no chance, at least in the in-sync version to review it with he students after they've done it.

But there were a few "gotcha's" that showed up in their work this time, so it would be good to put some more notes in there. about it.

I need to review again their submissions, but one I rember is that a few folks put code like:

if self.tag == 'html':
    do_something_special

which really defeats the purpose of subclassing :-)

Also: it would be good to refactor that instructions (and tests) a bit to put a placeholder tag for the Element base class -- students get a bit confused about what it's for if it has an "html" tag, then why do you make an Html subclass?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant