Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adding submodules #9

Open
NicMcPhee opened this issue Aug 11, 2020 · 2 comments
Open

Add adding submodules #9

NicMcPhee opened this issue Aug 11, 2020 · 2 comments
Assignees
Labels

Comments

@NicMcPhee
Copy link
Contributor

NicMcPhee commented Aug 11, 2020

The new bats-core implementation of Bats is heavily dependency on git sub-modules for its libraries. "Forking" repos using templates (which is the default for GitHub Classroom) mangles/loses some sub-module information, though, so something will have to be changed to make the labs that use Bats work with bats-core.

One option is to use the "source import" option in GitHub Classroom, but that's slow and not super reliable.

Another, suggested by @floogulinc, is to use this as an opportunity to explain a little about git sub-modules and have them (re)add the modules after they make their copy via GitHub Classroom. I like this idea, and think it would make a lot of sense.

@NicMcPhee NicMcPhee self-assigned this Aug 11, 2020
@NicMcPhee NicMcPhee added the bug label Aug 11, 2020
@NicMcPhee NicMcPhee added this to the Start of Fall 2019 milestone Aug 11, 2020
@NicMcPhee NicMcPhee removed this from the Start of Fall 2019 milestone Aug 11, 2022
@NicMcPhee
Copy link
Contributor Author

This is now pretty old, so it's possible that submodules are better handled when making copies from templates. We should confirm what does or doesn't happen in GitHub Classroom before we start making a bunch of changes.

@NicMcPhee
Copy link
Contributor Author

May want to link to the bats-core tutorial, which at least mentions that the submodules are there.

If we do add some documentation on sub-modules, maybe that should be in a separate file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant