Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable logging for incoming server requests #14

Closed
wants to merge 5 commits into from

Conversation

purusharths
Copy link
Contributor

The server now prints out incoming requests with some associated metadata
Function call changed to: UMBridge.serve_models([testmodel], 5232, true) with the last Bool argument acting as a trigger to initiate logging (default argument is false).

As of now, there's an extra level of verbosity with all Evaluate calls being printed out -> a possible resolution could be to export the logs to file instead. tail -f <filename> | grep "keywords" can then be used to filter for incoming requests. OR use a separate argument to enalbe logging for evaluate all together?
@linusseelinger thoughts?

@annereinarz
Copy link
Member

@purusharths Can you explain the todo note on changing input to evaluate? I'd prefer not to merge in code with active todos.

@purusharths
Copy link
Contributor Author

@annereinarz the TODO mentioned in the code is the same as my comment in this PR:

As of now, there's an extra level of verbosity with all Evaluate calls being printed out ->  ... 
use a separate argument to enalbe logging for evaluate all together?

PS: I'll close this PR and add a new one without duplicate commits from #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants