Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500 error caused by app crit search within original text create form #471

Open
tcouch opened this issue Aug 5, 2024 · 0 comments
Open

Comments

@tcouch
Copy link
Collaborator

tcouch commented Aug 5, 2024

Describe the bug
The text editor on the original text create form (used in fragment, anonymous fragment, and testimonium create views) has the mentions plugin enabled for apparatus criticus searching. This sends a get request to /search/ajax/apparatus-criticus/ whenever the hash key '#' is pressed. Unfortunately, this request needs to include an object_id as one of the parameters, but object_id=null because this is a yet to be created object. As a result we get a 500 error.

It's not a massive problem in terms of user experience as you'd only actually see the ajax request response if you are looking at the network pane, but it does mean we get emails when it happens in production.

Recommendation: App crit search should probably be disabled on this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Technical
Development

No branches or pull requests

1 participant