Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace StringFormatter with libfmt #726

Closed
zhjwpku opened this issue Nov 4, 2024 · 1 comment
Closed

replace StringFormatter with libfmt #726

zhjwpku opened this issue Nov 4, 2024 · 1 comment
Labels
feature request a new feature is requested

Comments

@zhjwpku
Copy link
Member

zhjwpku commented Nov 4, 2024

Is your feature request related to a problem? Please describe.

fma_common::StringFormatter is easy but lack advanced feature, for example, we can not do the following:

double a = 3.1415926;
StringFormatter.format(buf, "{.2lf}", a);

So I propose replace it with libfmt and formalize the LOG structure.

C++20 has libfmt as a built-in lib, we can easily switch to format after we update to C++20 with few changes.

@zhangwh807 zhangwh807 added the feature request a new feature is requested label Nov 4, 2024
@zhjwpku
Copy link
Member Author

zhjwpku commented Nov 8, 2024

We have already used the speedlog embeded fmt in v5.x, so close this issue.

@zhjwpku zhjwpku closed this as completed Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request a new feature is requested
Projects
None yet
Development

No branches or pull requests

2 participants