Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR-02 Authorization Logic Missing in Critical Functions #67

Open
xoloki opened this issue May 8, 2024 · 0 comments
Open

CR-02 Authorization Logic Missing in Critical Functions #67

xoloki opened this issue May 8, 2024 · 0 comments
Assignees
Labels

Comments

@xoloki
Copy link
Collaborator

xoloki commented May 8, 2024

The coordinator and signer methods process_inbound_mesages() will receive messages
from signers or coordinator, and pass down the messages to other methods depending on
its current state and the message's type. However, this information does not suffice for
proper authorization.
For example, in frost.rs at the gather_public_shares() method the coordinator
inserts shares into self.dkg_public_shares for a signer_id without actually validating
these shares came (i.e., were signed) by a signer underlying this signer_id. Hence the
coordinator will add these shares for the signer_id and remove the signer_id from the
ids_to_wait vector even if this signer never sent his shares

@xoloki xoloki added the audit label May 8, 2024
@xoloki xoloki self-assigned this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant