New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search #110

Open

1 of 9 tasks

lloydhumphreys opened this issue Jul 16, 2019 · 0 comments

Assignees

Labels

Milestone

lloydhumphreys commented Jul 16, 2019 •

edited by Kian-Esmaeilpour

Loading

Within the aside, we need a search that is consistent with the menu.

Design requirements

Search should play nice with the header, note and menu beneath
Search icon should align with menu icons if they're present
Search icon could turn into a spinner when searching, if we don't clear the menu immediately
Placeholder text design
Highlight/active/etc. states

Considerations

Perhaps it hijacks the cmd+f
It should be possible to have it highlighted immediately when opening a panel
Placeholder text should be (a) customizable (b) defaulted and translateable
RTL support should support reversing the panel

lloydhumphreys added this to the panels.js as webcomponents milestone

Kian-Esmaeilpour added the enhancement label

Kian-Esmaeilpour assigned Kian-Esmaeilpour and aleks-elkin

zdlm modified the milestones: panels.js as webcomponents, Work from home

aleks-elkin mentioned this issue

Add search component #176

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment