defaultNoteValue Used as Default for Velocity #181
LiamGallagherBC
started this conversation in
General
Replies: 1 comment
-
The honest answer is "it depends". Occasionally poor variable names slip under the code review radar and it's fine to update them. But we usually look at the impact that change would have before doing so. In this case, it's probably a good idea to update is to |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This is a two part query.
The first part, is being a zero-th time contributor, I was wondering if feedback about variable name choice is within the scope of considerations for contributions to the repository. What's the etiquette here?
The second part is that as seen in tracktion_StepClip.h's enum Defaults, and then used in tracktion_StepClip.cpp (and else where), defaultNoteValue is used as the default velocity value. I should think that defaultNoteVelocity is a more appropriate identifier, more so since note value and note number are often used interchangeably when talking about MIDI.
Let me know if these types of contributions are welcome, and I can put a PR together. If there's a contribution guide please let me know so I can make my PR fit, I wasn't able to find any mention of that in the ReadMe.
Thanks,
Liam Gallagher
Beta Was this translation helpful? Give feedback.
All reactions