Sodium compatibility issue #4

Fefedu973 · 2022-09-21T10:22:10Z

No description provided.

RaptaG · 2022-09-21T10:38:47Z

1.18.2 and Fabric yes, for Sodium you should try and see.

Fefedu973 · 2022-09-21T10:49:47Z

Crash with sodium
Description: Initializing game

java.lang.RuntimeException: Mixin transformation of net.minecraft.class_761 failed
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:418)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:322)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:145)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
	at net.minecraft.class_310.<init>(class_310.java:573)
	at net.minecraft.client.main.Main.main(Main.java:197)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:460)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392)
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:413)
	... 9 more
Caused by: org.spongepowered.asm.mixin.throwables.MixinApplyError: Mixin [smooth-chunks.mixins.json:WorldRendererMixin from mod smooth-chunks] from phase [DEFAULT] in config [smooth-chunks.mixins.json] FAILED during APPLY
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinError(MixinProcessor.java:638)
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinApplyError(MixinProcessor.java:589)
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:379)
	... 12 more
Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: @At("INVOKE") on net/minecraft/class_761::renderChunkBefore with priority 1000 cannot inject into net/minecraft/class_761::method_3251(Lnet/minecraft/class_1921;Lnet/minecraft/class_4587;DDDLnet/minecraft/class_1159;)V merged by me.jellysquid.mods.sodium.mixin.features.chunk_rendering.MixinWorldRenderer with priority 1000 [PREINJECT Applicator Phase -> smooth-chunks.mixins.json:WorldRendererMixin from mod smooth-chunks -> Prepare Injections ->  -> handler$dkg000$renderChunkBefore(Lnet/minecraft/class_1921;Lnet/minecraft/class_4587;DDDLnet/minecraft/class_1159;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;ZLit/unimi/dsi/fastutil/objects/ObjectListIterator;Lnet/minecraft/class_293;Lnet/minecraft/class_5944;Lnet/minecraft/class_284;ZLnet/minecraft/class_761$class_762;Lnet/minecraft/class_846$class_851;)V -> Prepare]
	at org.spongepowered.asm.mixin.injection.code.Injector.findTargetNodes(Injector.java:305)
	at org.spongepowered.asm.mixin.injection.code.Injector.find(Injector.java:240)
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.prepare(InjectionInfo.java:421)
	at org.spongepowered.asm.mixin.transformer.MixinTargetContext.prepareInjections(MixinTargetContext.java:1338)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.prepareInjections(MixinApplicatorStandard.java:1043)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:393)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:325)
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421)
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
	... 12 more

RaptaG · 2022-09-21T10:52:41Z

Maybe rename this issue to: Sodium compatibility

Fefedu973 · 2022-09-21T10:55:45Z

Maybe rename this issue to: Sodium compatibility

I tested with my modpack (+200 mods) so I will retest with sodium and phosphorus only to be sure because it could be due to another mod

RaptaG · 2022-09-21T10:56:53Z

Try with Sodium and Smooth Chunks only then

Fefedu973 · 2022-09-21T11:07:14Z

Yes same issue not compatible

PLS add iris (sodium) compatiblity sodium is the new optifine even more with fabric. this is really crucial and it would be awesome thanks

RaptaG · 2022-09-21T11:09:30Z

Sodium is not the new OptiFine, it lacks cosmetic features, but https://github.com/Fabulously-Optimized/fabulously-optimized is. (which includes it)

TopchetoEU · 2022-09-21T13:29:28Z

this is a planned feature, still i want to bring the mod to a more complete state before taking a look at sodium/iris support.

Fefedu973 · 2022-09-21T13:35:02Z

this is a planned feature, still i want to bring the mod to a more complete state before taking a look at sodium/iris support.

thank you very much I really hope that this compatibility will come one day

Fefedu973 · 2022-09-21T13:35:12Z

this is a planned feature, still i want to bring the mod to a more complete state before taking a look at sodium/iris support.

thank you very much I really hope that this compatibility will come one day

mads985 · 2022-09-21T21:37:00Z

Been waiting over a year now, jaw dropped when I saw this on Modrinth, really hope the Sodium compat can be worked out! This mod is great. - But I haven't been able to use it/alternatives since 1.13.2 D:

TopchetoEU · 2022-09-22T12:21:41Z

im going to try to work out sodium compatibility some time this week

ghost · 2022-09-25T13:30:16Z

Hello, I'm really happy to see this mod for newer versions.
THANK YOU! Looking forward to the Sodium compatibility 🥰

PinkGoosik · 2022-09-25T19:06:24Z

sodium compat will be a banger

EysseW · 2022-10-03T13:18:17Z

Dang I like to see this thread.

TopchetoEU · 2022-10-03T14:46:01Z

im sorry, but life's being going on and i barely have free time. for now, i won't be able to work on this

ghost · 2022-10-03T15:11:33Z

Take your time @TopchetoEU, the origin mod was last updated for 1.16 - we can wait 😊

EysseW · 2022-10-03T15:36:36Z

Is it very complicated? I am starting mod minecraft. Could I help with some easier parts?

EysseW · 2022-10-03T16:10:13Z

I do have to add, though, there is no pressure at all. We can absolutely wait. I'd just like to offer my help.

TopchetoEU · 2022-10-10T16:22:00Z

I do have to add, though, there is no pressure at all. We can absolutely wait. I'd just like to offer my help.

If you'd like, try to adapt it to Sodium, just don't do anything stupid with the code. Also TBH, this is complicated, so if you're just starting out, I wouldn't make you go trough this

RaptaG · 2022-10-10T17:30:19Z

Any progress with this so far?

EysseW · 2022-10-10T21:03:13Z

Okay, I'm not going to try then. I'll only confused myself.

RaptaG · 2022-10-30T15:13:03Z

It's been a while.. Any progress?

EysseW · 2022-11-30T17:26:37Z

Greetings! It's been a while. How are you doing in this? Any progress?

ghost · 2022-12-01T02:18:19Z

Hello @TopchetoEU, could a little donation for your awesome work, speed up the progress may? 😝
Greetings.

TopchetoEU · 2022-12-07T16:26:03Z

@mrniddala I don't really want donations, I just really don't know how to approach the problem. What I really need is someone who has experience with development for Sodium

TopchetoEU · 2023-01-15T10:17:50Z

hey everybody! sorry for keeping you waiting, but as of today, i've started the sodium compatibility development. it should be done by the end of the day, or tomorrow, idk.

EysseW · 2023-01-15T10:19:25Z

No worries! Good luck and have fun coding!

TopchetoEU · 2023-01-15T18:58:00Z

i'm trying to fix sodium support, but it seems as if sodium is at best incompatible with this mod. still, i'm going to try my best to port the functionality to sodium. thanks for waiting!

TopchetoEU · 2023-01-15T19:38:44Z

Sodium compatibility is impossible, because sodium seems to render whole regions at the same time (why does it do that is beyond me), and since chunk animations have to occur before each chunk animation call, sodium compatibility is impossible (almost). i could rewrite how sodium builds its chunks, but 1. this wouldn't be sodium compatibility, but sodium integration, 2. it would be unnecessarily hard for diminishing returns and 3. i could make sodium slower. so, sodium support is not planned. i'm aware that no sodium support is pretty much a deal-breaker for some of you (me included), but i can't do anything about it.

still, if you'd like to try to implement it yourself, go ahead, be my guest, make a PR.

thanks for supporting this mod!

PinkGoosik · 2023-01-15T19:54:23Z

Sodium users might look into chunks fade in as an alternative

TopchetoEU · 2023-01-18T08:03:40Z

seems like a good alternative. for now, i'll just keep updating the mod. if i figure out a way to do chunk animations i'll be sure to update the mod

i'm sorry to let you down

TopchetoEU · 2023-01-18T08:10:41Z

i will have one more shot at this issue, i'll keep you posted on the progress

EysseW · 2023-01-18T08:18:25Z

I understand the difficulty. Thanks for the great mod, anyway!

TopchetoEU · 2023-03-27T06:58:51Z

so far, I've made almost no progress, since i'm currently making multiple projects with far higher priority than this. i hope that i can get back to this project, and get it to support sodium and iris, however, the developers of sodium have made sure that my life is as hard as possible

TopchetoEU · 2023-03-27T07:02:26Z

if anyone wants to give this a shot, i will leave a hint that using shaders is (i think) the way to go.

Fefedu973 · 2023-03-27T07:16:47Z

Check this mod that is the fork of the same mod as yours and have sodium support if you need help https://github.com/kerudion/chunksfadein

Fefedu973 changed the title ~~Is it 1.18.2 compatible? Fabric + sodium~~ Sodium compatibility issue Sep 21, 2022

TopchetoEU linked a pull request Jan 15, 2023 that will close this issue

Topcheto eu/sodium compatibility issue #19

Merged

TopchetoEU closed this as completed in #19 Jan 15, 2023

TopchetoEU reopened this Jan 15, 2023

TopchetoEU closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2023

TopchetoEU reopened this Jan 18, 2023

TopchetoEU self-assigned this Jan 18, 2023

TopchetoEU linked a pull request Mar 27, 2023 that will close this issue

Remake animations using shaders #22

Open

Sodium compatibility issue #4

Sodium compatibility issue #4

Comments

Fefedu973 commented Sep 21, 2022

RaptaG commented Sep 21, 2022

Fefedu973 commented Sep 21, 2022

RaptaG commented Sep 21, 2022 • edited Loading

Fefedu973 commented Sep 21, 2022

RaptaG commented Sep 21, 2022

Fefedu973 commented Sep 21, 2022

RaptaG commented Sep 21, 2022

TopchetoEU commented Sep 21, 2022

Fefedu973 commented Sep 21, 2022

Fefedu973 commented Sep 21, 2022

mads985 commented Sep 21, 2022 • edited Loading

TopchetoEU commented Sep 22, 2022

ghost commented Sep 25, 2022

PinkGoosik commented Sep 25, 2022

EysseW commented Oct 3, 2022

TopchetoEU commented Oct 3, 2022

ghost commented Oct 3, 2022

EysseW commented Oct 3, 2022

EysseW commented Oct 3, 2022

TopchetoEU commented Oct 10, 2022 • edited Loading

RaptaG commented Oct 10, 2022

EysseW commented Oct 10, 2022

RaptaG commented Oct 30, 2022

EysseW commented Nov 30, 2022

ghost commented Dec 1, 2022

TopchetoEU commented Dec 7, 2022

TopchetoEU commented Jan 15, 2023

EysseW commented Jan 15, 2023

TopchetoEU commented Jan 15, 2023

TopchetoEU commented Jan 15, 2023 • edited Loading

PinkGoosik commented Jan 15, 2023

TopchetoEU commented Jan 18, 2023 • edited Loading

TopchetoEU commented Jan 18, 2023

EysseW commented Jan 18, 2023

TopchetoEU commented Mar 27, 2023

TopchetoEU commented Mar 27, 2023

Fefedu973 commented Mar 27, 2023

RaptaG commented Sep 21, 2022 •

edited

Loading

mads985 commented Sep 21, 2022 •

edited

Loading

TopchetoEU commented Oct 10, 2022 •

edited

Loading

TopchetoEU commented Jan 15, 2023 •

edited

Loading

TopchetoEU commented Jan 18, 2023 •

edited

Loading