-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser file-ending display error #366
Comments
Which browser am I looking at? Do you have some extensions installed that could cause this? I've just tested Firefox 128, Chrome 128 and Edge 127 and the filter did work as expected. (to be fair: on Windows 10; the dialog in your screenshot has rounded buttons, so I'm assuming this is Windows 11?) |
Chrome 128 with no extensions installed, and you are right, it is Windows 11. |
With Chrome on Windows 11 on my colleague's PC, it's still working: I'm not fundamentally opposed to changing accept=".bin" to ".bin,.BIN", but
The replacement char garbage that you see really confuses me, because this smells like a bug in Chrome. I would have expected to see the same behaviour on our machine. |
This is really strange behavior. It's not related to the case sensitivity. For me, it helps if a second value is also specified, such as '.jpg,.bin'. I only tried it with '.BIN,.bin' because that way it only shows '.bin' files. Btw ".bin,.bin" also fix this. You don't have to fix it for me, I thought it is a global problem. I know, I know ... my fault is to use Windows ... 😄 |
I'm the first to blame Windows for everything, but in this case it's working on two Windows machines :D I've build a test page, with some more accept-variants: input_file.zip If you open each one of those file pickers and navigate into the input_file directory:
|
.bin: is broken as above with garbage characters in the file type selector?
.bin,.BIN: works but calls the selected file type "Benutzerdefinierte Dateien"?
.gif: Do you get the broken behaviour here?
.gif,.png works but calls the selected file type "Benutzerdefinierte Dateien"?
text/html: Do you get the broken behaviour here?
text/html,application/zip works but calls the selected file. type "Benutzerdefinierte Dateien"?
application/octet-stream: Do you get the broken behaviour here?
.bin,application/octet-stream: Does this
By the way, Chrome and Microsoft Edge exhibit the same behavior. Firefox works as expected. |
Hi,
In today's update, I found a bug that may occur in Windows browsers. I haven't tested it on Linux yet.
When selecting the update file (ending with .bin), the browser shows me this:
You use this for the pre-selection:
esp32-firmware/software/web/src/modules/firmware_update/main.tsx
Line 187 in 20fdf4a
In my tests, wenn you change this to
accept=".BIN,.bin"
it looks much better:
The text was updated successfully, but these errors were encountered: