Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootbox won't accept reactive templates as the "message" parameter #28

Open
timesync opened this issue May 6, 2015 · 3 comments
Open

Comments

@timesync
Copy link

timesync commented May 6, 2015

Here's how I'm getting around it for now without me having to deal with giving you a pull request with a complete fix: https://gist.github.com/1ba557e380008a0050f1

@mizzao
Copy link
Collaborator

mizzao commented May 6, 2015

Pull requests are what GitHub is all about :) You should definitely take the time to learn them!

@timesync
Copy link
Author

timesync commented May 6, 2015

Oh I know them… Well. Just didn’t feel like digging in to the Bootbox code, forking it, and blah blah blah. So I threw up a quick hack around it. Don’t have time to do much else right now… On deadline. ;-)

@timesync timesync changed the title Boombox won't accept reactive templates as the "message" parameter Bootbox won't accept reactive templates as the "message" parameter May 6, 2015
@mizzao
Copy link
Collaborator

mizzao commented Jul 11, 2015

I believe that being a good programmer means learning to do things the "right" way despite the constant parade of deadlines :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants