Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined behavior in chunk_reader #2

Open
ThomasMiz opened this issue Nov 19, 2024 · 0 comments
Open

Undefined behavior in chunk_reader #2

ThomasMiz opened this issue Nov 19, 2024 · 0 comments
Assignees

Comments

@ThomasMiz
Copy link
Owner

While this is currently working fine as is, there is actually UB in this code, in both the read_chunked_utf8_string and the read_domainname function, as calling set_len on a vector before filling up that vector means that area of the vector, which is now considered initialized, is actually uninitialized.

Fix by using Vec::spare_capacity_mut.

@ThomasMiz ThomasMiz self-assigned this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant