Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 19 Support #1374

Open
tordans opened this issue Dec 6, 2024 · 0 comments
Open

React 19 Support #1374

tordans opened this issue Dec 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@tordans
Copy link
Contributor

tordans commented Dec 6, 2024

Testing a Astro + Keystatic Setup with React 19 I get a few warnings, some of them related to Keystatic:

npm warn Could not resolve dependency:
npm warn peer react@"^18.2.0" from @keystatic/[email protected]
npm warn node_modules/@keystatic/astro
npm warn   @keystatic/astro@"^5.0.3" from the root project
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/react
npm warn   react@"^19.0.0" from the root project
npm warn   113 more (@astrojs/react, @floating-ui/react, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer react@"^18.2.0" from @keystatic/[email protected]
npm warn node_modules/@keystatic/core
npm warn   @keystatic/core@"^0.5.42" from the root project
npm warn   1 more (@keystatic/astro)
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/react
npm warn   react@"^19.0.0" from the root project
npm warn   113 more (@astrojs/react, @floating-ui/react, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer react@"^18.2.0" from @keystatic/[email protected]
npm warn node_modules/@keystatic/core
npm warn   @keystatic/core@"^0.5.42" from the root project
npm warn   1 more (@keystatic/astro)
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/react
npm warn   react@"^19.0.0" from the root project
npm warn   113 more (@astrojs/react, @floating-ui/react, ...)
…
npm warn Could not resolve dependency:
npm warn peer react-dom@"^18.2.0" from @keystatic/[email protected]
npm warn node_modules/@keystatic/astro
npm warn   @keystatic/astro@"^5.0.3" from the root project
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/react-dom
npm warn   react-dom@"^19.0.0" from the root project
npm warn   31 more (@astrojs/react, @floating-ui/react, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer react-dom@"^18.2.0" from @keystatic/[email protected]
npm warn node_modules/@keystatic/core
npm warn   @keystatic/core@"^0.5.42" from the root project
npm warn   1 more (@keystatic/astro)
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/react-dom
npm warn   react-dom@"^19.0.0" from the root project
npm warn   31 more (@astrojs/react, @floating-ui/react, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer react-dom@"^18.2.0" from @keystatic/[email protected]
npm warn node_modules/@keystatic/core
npm warn   @keystatic/core@"^0.5.42" from the root project
npm warn   1 more (@keystatic/astro)

And errors:

% npm install
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @keystatic/[email protected]
npm error Found: [email protected]
npm error node_modules/react
npm error   react@"^19.0.0" from the root project
npm error   peer react@"^17.0.2 || ^18.0.0 || ^19.0.0-beta" from @astrojs/[email protected]
npm error   node_modules/@astrojs/react
npm error     @astrojs/react@"^4.0.0" from the root project
npm error   107 more (@floating-ui/react, @floating-ui/react-dom, ...)
npm error
npm error Could not resolve dependency:
npm error peer react@"^18.2.0" from @keystatic/[email protected]
npm error node_modules/@keystatic/astro
npm error   @keystatic/astro@"^5.0.3" from the root project
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/react
npm error   peer react@"^18.2.0" from @keystatic/[email protected]
npm error   node_modules/@keystatic/astro
npm error     @keystatic/astro@"^5.0.3" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
diff --git a/package-lock.json b/package-lock.json
index 727e546..2ef53e6 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -31,8 +31,8 @@
         "maplibre-gl": "^4.7.1",
         "nanostores": "^0.11.3",
         "pmtiles": "^4.0.1",
-        "react": "^18.3.1",
-        "react-dom": "^18.3.1",
+        "react": "^19.0.0",
+        "react-dom": "^19.0.0",
@emmatown emmatown added the enhancement New feature or request label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants