Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tstat_uuid not updated in thermostats table #64

Open
Lerrissirrel opened this issue Feb 2, 2015 · 3 comments
Open

tstat_uuid not updated in thermostats table #64

Lerrissirrel opened this issue Feb 2, 2015 · 3 comments

Comments

@Lerrissirrel
Copy link
Collaborator

I did a clean install of the latest code for fear that I'd screw up my running instance. I found that some things didn't work because the tstat_uuid is never updated in the thermostats table. I vaguely remember running into this once before on a clean install. Uncommenting the lines in thermo_update_status.php does the trick but clearly there were some concerns about that (given the notes there and it being commented out). Do you remember what the issue was? Unless I missed something in the install, it seems that things would never work...?

@ThermoMan
Copy link
Owner

The reason that was commented out was because I was having network problems at home. The error detection in the code was (is?) inadequate and so it thought it HAD connected and wanted to update the uuid with a new value. The new value was an empty string and once that was updated it broke pretty much everything else.
Commenting out the update was the shortest path to not breaking the system.

The right solution would be a more robust error detection. I do recall that I did some work to that end, but don't remember how far along I got.

I also wanted to separate the update of thermostat data from the update of zip code data because a broken connection at home stopped the thing from looking for the zip code data. And if location were split out from thermostat (with a foreign key) then for multiple thermostats in the same area, only one call to the weather underground (or wherever) library would be needed.

@ThermoMan
Copy link
Owner

When the system detects a change in the system ID it should alert the user.

@ThermoMan
Copy link
Owner

ThermoMan commented Jun 22, 2018

I added the enhancement label - the software ought to communicate to the user that something is up. This could (should?) take two forms. An instant email alert and/or a note on the dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants