Propagate TheHive deprecation warnings

[JuanTecedor]

After working in "Fix deprecations in the query filters" (issue, PR), it'd be nice to propagate the TheHive deprecation warnings to TheHive4py, so that they could be more easily detected. I'm thinking of using the pytest_sessionfinish hook:

tests/utils.py

def propagate_thehive_warnings(container_name: str):
    output_lines = subprocess.run(
        shlex.split(f"docker logs {container_name}"),
        capture_output=True,
        text=True
    ).stdout.lower().splitlines()
    for output_line in output_lines:
        if "deprecated" in output_line:
            warnings.warn(output_line)

tests/conftest.py

def pytest_sessionfinish(session, exitstatus):
    propagate_thehive_warnings(CONTAINER_NAME)

Thoughts?

[Kamforka]

Interesting idea, but I don't think that the internal logs of TheHive should be the concern of thehive4py, I believe we should stop at the API level.

[JuanTecedor]

You're right that this falls outside the scope of TheHive4py's responsibilities.

Also, the deprecation checks are likely only relevant when the TheHive image tag is updated.

Feel free to close this issue