Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: doc-phone support href link #411

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

fennghuang
Copy link
Contributor

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

背景

目前 doc-phone 组件不支持新窗口直接打开链接,不方便调试

方案

增加 href 属性,设置该属性后显示新窗口打开图标
image

📝 更新日志

  • feat(doc-phone): support href link

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@uyarn
Copy link
Collaborator

uyarn commented Oct 20, 2023

@Wen1kang 看看这个视觉是否OK

@uyarn uyarn requested a review from Wen1kang October 20, 2023 13:27
@Wen1kang
Copy link
Collaborator

@Wen1kang 看看这个视觉是否OK

我这边看没问题呀

@uyarn uyarn merged commit cd4e724 into Tencent:main Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants