Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popconfirm/Dialog/Drawer] 确认按钮功能升级 #4883

Closed
MinMr opened this issue Jan 1, 2025 · 2 comments
Closed

[Popconfirm/Dialog/Drawer] 确认按钮功能升级 #4883

MinMr opened this issue Jan 1, 2025 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@MinMr
Copy link

MinMr commented Jan 1, 2025

这个功能解决了什么问题

在点击这个三个组件确认按钮的时候,loading和组件的隐藏交由组件内部去控制

你建议的方案是什么

如果点击确认按钮的时候,事件返回的是一个promise,确认按钮的loading直接为true,如果promise的状态为resolve,关闭组件取消loading,如果promise返回的是reject,确认按钮loading取消,组件不关闭。这样体验会好很多很多,参考ant-design-vue/arco-design都是这样实现的

Copy link
Contributor

github-actions bot commented Jan 1, 2025

👋 @MinMr,感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善,我们将调查并尽快回复你。

@uyarn
Copy link
Collaborator

uyarn commented Jan 1, 2025

duplicate of #4884

@uyarn uyarn closed this as completed Jan 1, 2025
@uyarn uyarn added the duplicate This issue or pull request already exists label Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants