Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu not aligned in Arab #4225

Open
getgo-nobugs opened this issue Jul 22, 2024 · 7 comments
Open

Menu not aligned in Arab #4225

getgo-nobugs opened this issue Jul 22, 2024 · 7 comments
Labels
Area-Internationalization Issue-Easy (good first issue) Beginners welcome! Issues with relative low difficulty. Issue-Glitch Graphical issue

Comments

@getgo-nobugs
Copy link

Describe the bug
Menu text does not aligned consistently in arab

To Reproduce
Steps to reproduce the behavior:

  1. Open the app
  2. Click "menu" button

Expected behavior
Menu text does not aligned consistently in arab.

Screenshots
image

Smartphone (please complete the following information):

  • Device: Small Phone
  • OS: Android 12
@VishnuSanal VishnuSanal added Issue-Easy (good first issue) Beginners welcome! Issues with relative low difficulty. Issue-Glitch Graphical issue Area-Internationalization fosshack easy labels Jul 25, 2024
@sanjai0py
Copy link

I have identified the issue; it seems that there are some values that don't have proper translations. I believe that adding the correctly translated values will solve this. Please give a thumbs up if I am heading in the right direction!

image

@VishnuSanal
Copy link
Member

@sanjai0py hi, thanks for your interest in contributing to amaze! the solution you suggested would work -- but it is practically almost impossible to achieve 100% translation coverage. to fix this issue, try settingsupportsRtl to true in the manifest.

@sanjai0py
Copy link

sanjai0py commented Jul 28, 2024

Hey @VishnuSanal, thanks for the reply. I understand that setting the android:supportsRtl="true" will only right-to-left align the contents, but it won't provide proper translation/internalization, right? I am new to Android.

image

@VishnuSanal
Copy link
Member

@sanjai0py appreciate your enthusiasm in contributing to amaze!

I understand that setting the android:supportsRtl="true" will only right-to-left align the contents

yess - and, that's what this issue is about!

but it won't provide proper translation/internalization

we can't rely on having 100% translation for every language. itt is practically impossible to achieve that coverage. android falls back to the default strings in english in case of the non availability of translated strings.

this issue was that the text gets misaligned for those such strings. and, your new screenshot fixes this issue. please make a PR & we are good to go. :)

PS: if my assumptions are wrong, please correct me. ;)

@hammadrfq3
Copy link
Contributor

Hi VishnuSanal,
Can i work on this issue?
Also there were some strings not localized, now I have localized them

فيديوهات
تحليل التخزين
سلة المهملات

@VishnuSanal
Copy link
Member

hi @hammadrfq3, thanks for your interest in contributing to amaze! please wait for a few hours to confirm that @sanjai0py is no longer working on this issue. if not, you can proceed with this issue. :)

@sanjai0py
Copy link

Hey @VishnuSanal, I’m tied up with work and won’t be able to address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Internationalization Issue-Easy (good first issue) Beginners welcome! Issues with relative low difficulty. Issue-Glitch Graphical issue
Projects
None yet
Development

No branches or pull requests

4 participants