5 - rank system #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
yusung103
reviewed
Nov 11, 2024
There was a problem hiding this comment.
redis 부분은 제가 만들어 놨는데 또 만드신 이유가 있나요????????
There was a problem hiding this comment.
35e0844
수정했습니다!
| this.rankService = rankService; | ||
| this.userService = userService; | ||
| this.jwtService = jwtService; | ||
| } |
There was a problem hiding this comment.
@Autowired를 쓰는거 보다 클래스에 @requiredargsconstructor로 생성자 생성 할 수 있습니다
수정해주세요
| import com.example.domaserver.domain.user.entity.User; | ||
| import java.util.List; | ||
|
|
||
| public interface RankService { |
yusung103
reviewed
Nov 18, 2024
|
|
||
|
|
||
| @ServiceWithTransaction | ||
| @ServiceWithReadOnlyTransactional |
There was a problem hiding this comment.
get service는 ReadOnly 씁니다. 두개 붙일 필요 없이 ReadOnly만 남겨주세요
There was a problem hiding this comment.
수정했습니다!
|
|
||
| public GetRankingServiceImpl(RedisTemplate redisTemplate) { | ||
| this.redisTemplate = redisTemplate; | ||
| } |
There was a problem hiding this comment.
생성자는 코드 스타일에 맞춰서 어노테이션을 사용해서 만들어주세요
|
|
||
|
|
||
| @ServiceWithTransaction | ||
| @ServiceWithReadOnlyTransactional |
There was a problem hiding this comment.
get service는 ReadOnly 씁니다. 두개 붙일 필요 없이 ReadOnly만 남겨주세요
There was a problem hiding this comment.
수정했습니다!
yusung103
reviewed
Nov 21, 2024
| @Override | ||
| public User findByUsername(String username) { | ||
| return userRepository.findByUsername(username) | ||
| .orElseThrow(() -> new UsernameNotFoundException("User not found with username: " + username)); |
There was a problem hiding this comment.
custom exception을 만들어서 예외처리를 해보는건 어떨까요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
Redis를 사용하여 Rank 기능 구현
✨ 작업 내용