PendingMs 0 and shouldPending true

[OrlovAlexei]

I noticed that even with pendingMs: 0, shouldPending is still true. Is this the expected behavior?

router/packages/react-router/src/router.ts

Line 2167 in 581ebe3

const shouldPending = !!(

[schiller-manuel]

maybe? can you please provide a complete minimal example where that matters?

[OrlovAlexei]

Looking at the code further, there are setTimeout calls with timeout=0. Could we skip such setTimeout calls (similar to how we handle Infinity timeout)?

Suggestion: We could potentially optimize by treating timeout=0 similar to timeout=Infinity, since both are edge cases. This would mean skipping the timeout set up completely when timeout=0.

[schiller-manuel]

can you come to our discord to discuss this there? https://discord.com/invite/WrRKjPJ

[OrlovAlexei]

I noticed that the Task for handling searchParams updates is quite large/complex.
https://stackblitz.com/edit/tanstack-router-fh1cv3?file=src%2Fmain.tsx