From b4f38913818fcef278dfa728055cc206aad49783 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Uzna=C5=84ski?= Date: Tue, 25 Jul 2023 13:08:32 +0200 Subject: [PATCH 1/3] Add templates (#633) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Add templates Co-authored-by: Krzysztof Gutkowski Co-authored-by: Łukasz Uznański --- .github/ISSUE_TEMPLATE/bug_report.md | 30 +++++++++++++++++++++++ .github/ISSUE_TEMPLATE/feature_request.md | 20 +++++++++++++++ 2 files changed, 50 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md create mode 100644 .github/ISSUE_TEMPLATE/feature_request.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 00000000..f010b675 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,30 @@ +--- +name: Bug report +about: Report a broken functionality. +title: '' +labels: bug +assignees: '' + +--- + +**Describe the bug** +A clear and concise description of what the bug is. + +**To Reproduce** +Steps to reproduce the behavior: +1. Go to '...' +2. Click on '....' +3. Scroll down to '....' +4. See error + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots** +If applicable, add screenshots to help explain your problem. + +**TYPO3 version and TYPO3 Headless version** + Please provide the exact version of TYPO3 and TYPO3 Headless + +**Additional context** +Add any other information related to the problem here. diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 00000000..bbcbbe7d --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,20 @@ +--- +name: Feature request +about: Suggest an idea for this project +title: '' +labels: '' +assignees: '' + +--- + +**Is your feature request related to a problem? Please describe.** +A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] + +**Describe the solution you'd like** +A clear and concise description of what you want to happen. + +**Describe alternatives you've considered** +A clear and concise description of any alternative solutions or features you've considered. + +**Additional context** +Add any other context or screenshots about the feature request here. From 986f7ffb42a06adef167e5e9f47c2d28c53143a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Uzna=C5=84ski?= Date: Wed, 26 Jul 2023 10:38:09 +0200 Subject: [PATCH 2/3] Add contributing stats (#635) * Add contributing stats --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index cb2f90a4..99c9237f 100644 --- a/README.md +++ b/README.md @@ -70,6 +70,10 @@ Then, you should include extension typoscript template, and you are ready to go. ## Documentation [Extension documentation](https://docs.typo3.org/p/friendsoftypo3/headless/master/en-us/Index.html) + +## Contributing +![Alt](https://repobeats.axiom.co/api/embed/197db91cad9195bb15a06c91fda5a215bff26cba.svg) + ## JSON Content Object In headless extension we implemented new JSON Content Object, which allows you to specify what fields you want to output, and how they will look. First, let's take a look at simple example ``` From 16c80eb26971cbcbc5ee54911254e377f0dd9072 Mon Sep 17 00:00:00 2001 From: parallaxis-mcgoldrick <43951441+parallaxis-mcgoldrick@users.noreply.github.com> Date: Wed, 26 Jul 2023 10:49:32 +0200 Subject: [PATCH 3/3] =?UTF-8?q?[FIX]=20Import=20custom=20GalleryProcessor?= =?UTF-8?q?=20instead=20of=20processor=20from=20fluid=5F=E2=80=A6=20(#634)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I get the following error in TYPO3 v12: #1427455378 UnexpectedValueException Processor class or service name "gallery" does not exist! This has to do with fluid_styled_content now using identifiers for setting the DataProcessors inside the TypoScript configuration and not the full class name anymore. The origin of this error seems to be that in your Services.php you register "headless-gallery" as an identifier for "TYPO3\CMS\Frontend\DataProcessing\GalleryProcessor" and not for your custom DataProcessor "FriendsOfTYPO3\Headless\DataProcessing\GalleryProcessor" so the identifier is overridden and the DataProcessing of the regular images stops working. --- Configuration/Services.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Configuration/Services.php b/Configuration/Services.php index 9b45a400..b3f3ce34 100644 --- a/Configuration/Services.php +++ b/Configuration/Services.php @@ -17,6 +17,7 @@ use FriendsOfTYPO3\Headless\DataProcessing\DatabaseQueryProcessor; use FriendsOfTYPO3\Headless\DataProcessing\FilesProcessor; use FriendsOfTYPO3\Headless\DataProcessing\FlexFormProcessor; +use FriendsOfTYPO3\Headless\DataProcessing\GalleryProcessor; use FriendsOfTYPO3\Headless\DataProcessing\MenuProcessor; use FriendsOfTYPO3\Headless\DataProcessing\RootSitesProcessor; use FriendsOfTYPO3\Headless\Event\Listener\AfterLinkIsGeneratedListener; @@ -31,7 +32,6 @@ use TYPO3\CMS\Core\Configuration\Features; use TYPO3\CMS\Core\Utility\GeneralUtility; use TYPO3\CMS\Form\Controller\FormFrontendController; -use TYPO3\CMS\Frontend\DataProcessing\GalleryProcessor; use TYPO3\CMS\FrontendLogin\Controller\LoginController; use function Symfony\Component\DependencyInjection\Loader\Configurator\service;