chore: support ivy based partial compilation for @ngqp/core #225
Conversation
package.json
Outdated
| "@angular/platform-browser-dynamic": "~11.0.7", | ||
| "@angular/router": "~11.0.7", | ||
| "@angular/service-worker": "~11.0.7", | ||
| "@angular/animations": "~14.0.0", |
There was a problem hiding this comment.
This also updates ngqp-demo. What about the issues with Webpack? For me this doesn't run locally.
There was a problem hiding this comment.
That is because you use raw-loader for load ts files as string for examples. That raw-loader is removed from webpack 5 and angular cli 14 uses webpack 5
There was a problem hiding this comment.
I'm well aware of the problem, but I don't understand the change. If this simply doesn't work we of course can't merge it.
projects/ngqp/core/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@ngqp/core", | |||
| "version": "14.1.0", | |||
| "version": "15.0.0", | |||
There was a problem hiding this comment.
Please undo this change, this is done during release. Also, move the
BREAKING CHANGE: due to partial ivy compilation it's not supported by angular before 11.1 so bump version to 15
comment into the commit message, because that is where conventional commits need it. But leave out the "version 15" there, that is decided during release. Just an explanation of why it is breaking: the dependencies bump. 🙂
pumano
force-pushed
the
feature/angular-14-partial-compilation-support
branch
from
979f038
to
e6fc605
Compare
|
@Airblader OK I revert my work, just changed to |
|
Can you please try to get the sign-off to work? The DCO is a company requirement. The commit message currently also doesn't really make much sense; it talks about reverting a commit. |
Library should be compiled using "compilationMode": "partial" for not using ngcc
Also default target for 14 angular is es2020
Update browserlist to actual due to bugs with old data
Change legacy "fullTemplateTypeCheck" to actual "strictTemplates"
BREAKING CHANGE: due to partial ivy compilation it's not supported by angular before 11.1 so bump version to 15
closes #224
This pull request relates to or closes the following issues:
I have verified that…